Fix api-routes-apollo-server-and-client-auth Example #10334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`client.resetStore()` must be called after SignIn, SignOut actions
Otherwise, even the current basic auth is not working 100% of the time...
For example, as caching occurs here:
```
const { data, loading } = useQuery(ViewerQuery)
```
it sometimes (race conditions!) prevents a user from signing in
the current code base.
Check apollographql/apollo-cache-persist#34 (comment) comment for more info.
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: c26aaaf |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: 8d7285c |
timneutkens
approved these changes
Jan 30, 2020
chibicode
pushed a commit
to chibicode/next.js
that referenced
this pull request
Feb 11, 2020
* Fix api-routes-apollo-server-and-client-auth Example
`client.resetStore()` must be called after SignIn, SignOut actions
Otherwise, even the current basic auth is not working 100% of the time...
For example, as caching occurs here:
```
const { data, loading } = useQuery(ViewerQuery)
```
it sometimes (race conditions!) prevents a user from signing in
the current code base.
Check apollographql/apollo-cache-persist#34 (comment) comment for more info.
* Fix api-routes-apollo-server-and-client-auth Example (linting)
This was referenced Mar 13, 2020
This was referenced Mar 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apolloClient.resetStore()must be called after SignIn, SignOut actionsOtherwise, even the current basic auth is not working 100% of the time...
For example, as caching occurs here:
it sometimes (race conditions!) prevents a user from logging in.
Another source of possible bugs is that authenticated and anonymous users
most probably have different data models (different visible fields) so you want to refetch models
as you switch user roles.
The underline is that we absolutely need to reset all client caches on login and logout actions.
Check apollographql/apollo-cache-persist#34 (comment) comment for more info.