Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect Invalid Pages Before Optimize #10418

Merged
merged 1 commit into from Feb 4, 2020
Merged

Detect Invalid Pages Before Optimize #10418

merged 1 commit into from Feb 4, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Feb 4, 2020

Follow up to #10403

@Timer Timer added this to the 9.2.2 milestone Feb 4, 2020
@ijjk
Copy link
Member

ijjk commented Feb 4, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary Timer/next.js invalid-pages-2 Change
buildDuration 11.8s 11.8s -66ms
nodeModulesSize 52.2 MB 52.2 MB ⚠️ +735 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js invalid-pages-2 Change
main-HASH.js gzip 5.12 kB 5.12 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..d6ae.js gzip 16.2 kB 16.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 69.9 kB 69.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js invalid-pages-2 Change
main-HASH.module.js gzip 4.12 kB 4.12 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 15.1 kB 15.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 64.6 kB 64.6 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js invalid-pages-2 Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary Timer/next.js invalid-pages-2 Change
_app.js gzip 1.15 kB 1.15 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.89 kB 2.89 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.68 kB 9.68 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js invalid-pages-2 Change
_app.module.js gzip 576 B 576 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.22 kB 7.22 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js invalid-pages-2 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary Timer/next.js invalid-pages-2 Change
index.html gzip 1.02 kB 1.02 kB ✓
link.html gzip 1.03 kB 1.03 kB ✓
withRouter.html gzip 1.02 kB 1.02 kB ✓
Overall change 3.07 kB 3.07 kB ✓
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary Timer/next.js invalid-pages-2 Change
buildDuration 12.3s 12.4s ⚠️ +151ms
nodeModulesSize 52.2 MB 52.2 MB ⚠️ +735 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js invalid-pages-2 Change
main-HASH.js gzip 5.12 kB 5.12 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..d6ae.js gzip 16.2 kB 16.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 69.9 kB 69.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js invalid-pages-2 Change
main-HASH.module.js gzip 4.12 kB 4.12 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 15.1 kB 15.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 64.6 kB 64.6 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js invalid-pages-2 Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary Timer/next.js invalid-pages-2 Change
_app.js gzip 1.15 kB 1.15 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.89 kB 2.89 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.68 kB 9.68 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js invalid-pages-2 Change
_app.module.js gzip 576 B 576 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.22 kB 7.22 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js invalid-pages-2 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary Timer/next.js invalid-pages-2 Change
_error.js gzip 46.5 kB 46.5 kB ✓
404.html gzip 1.43 kB 1.43 kB ✓
hooks.html gzip 1.07 kB 1.07 kB ✓
index.js gzip 46.5 kB 46.5 kB ✓
link.js gzip 72 kB 72 kB ✓
routerDirect.js gzip 70.3 kB 70.3 kB ✓
withRouter.js gzip 70.1 kB 70.1 kB ✓
Overall change 308 kB 308 kB ✓

Commit: 0d1eac2

@Timer Timer merged commit bc81379 into vercel:canary Feb 4, 2020
@Timer Timer deleted the invalid-pages-2 branch February 4, 2020 18:57
chibicode pushed a commit to chibicode/next.js that referenced this pull request Feb 11, 2020
@Timer @chibicode
Detect Invalid Pages Before Optimize (vercel#10418)
ce0a0a0
This was referenced Mar 13, 2020
Closed
Open
This was referenced Mar 22, 2020
Merged
Merged
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.2.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Timer @ijjk @timneutkens