Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused devdependency @types/babel-types #10448

Merged
merged 1 commit into from Feb 7, 2020
Merged

Remove unused devdependency @types/babel-types #10448

merged 1 commit into from Feb 7, 2020

Conversation

Janpot
Copy link
Contributor

@Janpot Janpot commented Feb 7, 2020

@types/babel-types doesn't seem to be in use anymore. babel-types is not used anywhere and @babel/types has its own typings included.

@Janpot
Remove unused dependency @types/babel-types
611c895 
`@types/babel-types` doesn't seem to be in use anymore. `babel-types` is not used anywhere and `@babel/types` has its own typings included.
@ijjk
Copy link
Member

ijjk commented Feb 7, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary Janpot/next.js remove-types-babel-types Change
buildDuration 11.3s 11.3s -82ms
nodeModulesSize 52.6 MB 52.6 MB -35 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js remove-types-babel-types Change
main-HASH.js gzip 5.12 kB 5.12 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..b50f.js gzip 13.6 kB 13.6 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.3 kB 67.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js remove-types-babel-types Change
main-HASH.module.js gzip 4.12 kB 4.12 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.4 kB 12.4 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 61.9 kB 61.9 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js remove-types-babel-types Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary Janpot/next.js remove-types-babel-types Change
_app.js gzip 1.15 kB 1.15 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.89 kB 2.89 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.68 kB 9.68 kB ✓
Client Pages Modern
zeit/next.js canary Janpot/next.js remove-types-babel-types Change
_app.module.js gzip 576 B 576 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.22 kB 7.22 kB ✓
Client Build Manifests
zeit/next.js canary Janpot/next.js remove-types-babel-types Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary Janpot/next.js remove-types-babel-types Change
index.html gzip 1.02 kB 1.02 kB ✓
link.html gzip 1.03 kB 1.03 kB ✓
withRouter.html gzip 1.02 kB 1.02 kB ✓
Overall change 3.07 kB 3.07 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary Janpot/next.js remove-types-babel-types Change
buildDuration 11.6s 11.8s ⚠️ +239ms
nodeModulesSize 52.6 MB 52.6 MB -35 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js remove-types-babel-types Change
main-HASH.js gzip 5.12 kB 5.12 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..b50f.js gzip 13.6 kB 13.6 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.3 kB 67.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js remove-types-babel-types Change
main-HASH.module.js gzip 4.12 kB 4.12 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.4 kB 12.4 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 61.9 kB 61.9 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js remove-types-babel-types Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary Janpot/next.js remove-types-babel-types Change
_app.js gzip 1.15 kB 1.15 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.89 kB 2.89 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.68 kB 9.68 kB ✓
Client Pages Modern
zeit/next.js canary Janpot/next.js remove-types-babel-types Change
_app.module.js gzip 576 B 576 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.22 kB 7.22 kB ✓
Client Build Manifests
zeit/next.js canary Janpot/next.js remove-types-babel-types Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary Janpot/next.js remove-types-babel-types Change
_error.js gzip 46.5 kB 46.5 kB ✓
404.html gzip 1.43 kB 1.43 kB ✓
hooks.html gzip 1.07 kB 1.07 kB ✓
index.js gzip 46.5 kB 46.5 kB ✓
link.js gzip 72 kB 72 kB ✓
routerDirect.js gzip 70.2 kB 70.2 kB ✓
withRouter.js gzip 70 kB 70 kB ✓
Overall change 308 kB 308 kB ✓

Commit: 611c895

@timneutkens timneutkens merged commit 5e4850c into vercel:canary Feb 7, 2020
@timneutkens timneutkens changed the title Remove unused dependency @types/babel-types Remove unused devdependency @types/babel-types Feb 7, 2020
@Janpot Janpot deleted the remove-types-babel-types branch February 7, 2020 10:22
chibicode pushed a commit to chibicode/next.js that referenced this pull request Feb 11, 2020
@Janpot @chibicode
Remove unused dependency @types/babel-types (vercel#10448)
9319465 
`@types/babel-types` doesn't seem to be in use anymore. `babel-types` is not used anywhere and `@babel/types` has its own typings included.
This was referenced Mar 13, 2020
Closed
Open
This was referenced Mar 22, 2020
Merged
Merged
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Janpot @ijjk @timneutkens