Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error message when rewriting to dynamic SSG page #10458

Merged
merged 3 commits into from Feb 8, 2020
Merged

Add error message when rewriting to dynamic SSG page #10458

merged 3 commits into from Feb 8, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 8, 2020

This makes sure to show an error message when rewriting to dynamic SSG page as this could cause the fallback to fail to fetch the /_next/data route which causes the /_error page to show.

Currently we use the asPath when fetching the /_next/data route for SSG and getServerProps. This can cause problems since they may be rewritten to and the /_next/data route might not have the same rewrite causing the data request to fail.

One solution is to ship the rewrites to the client so we can know what the destination should be and use that for the data request. This would also solve rewriting to auto-exported dynamic pages since we could then know how to parse the params.

Another potential solution for the /_next/data route rewrite error specifically is we could attempt all the rewrites with the /_next/data/BUILD_ID/ prefix stripped and use the destination instead.

@ijjk ijjk added this to the 9.2.x milestone Feb 8, 2020
@ijjk
Copy link
Member Author

ijjk commented Feb 8, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
buildDuration 13.2s 13.4s ⚠️ +115ms
nodeModulesSize 52.6 MB 52.6 MB ⚠️ +635 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
main-HASH.js gzip 5.13 kB 5.13 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..e781.js gzip 13.8 kB 13.8 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.5 kB 67.5 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
main-HASH.module.js gzip 4.13 kB 4.13 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB 12.5 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 62.1 kB 62.1 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
_app.js gzip 1.15 kB 1.15 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.89 kB 2.89 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.68 kB 9.68 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
_app.module.js gzip 576 B 576 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.22 kB 7.22 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
index.html gzip 1.03 kB 1.03 kB ✓
link.html gzip 1.04 kB 1.04 kB ✓
withRouter.html gzip 1.03 kB 1.03 kB ✓
Overall change 3.11 kB 3.11 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
buildDuration 13.7s 13.8s ⚠️ +82ms
nodeModulesSize 52.6 MB 52.6 MB ⚠️ +635 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
main-HASH.js gzip 5.13 kB 5.13 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..e781.js gzip 13.8 kB 13.8 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.5 kB 67.5 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
main-HASH.module.js gzip 4.13 kB 4.13 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB 12.5 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 62.1 kB 62.1 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
_app.js gzip 1.15 kB 1.15 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.89 kB 2.89 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.68 kB 9.68 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
_app.module.js gzip 576 B 576 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.22 kB 7.22 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
_error.js gzip 46.6 kB 46.6 kB ⚠️ +17 B
404.html gzip 1.45 kB 1.45 kB ✓
hooks.html gzip 1.08 kB 1.08 kB ✓
index.js gzip 46.7 kB 46.7 kB ⚠️ +20 B
link.js gzip 72.6 kB 72.6 kB ⚠️ +18 B
routerDirect.js gzip 70.8 kB 70.8 kB ⚠️ +18 B
withRouter.js gzip 70.6 kB 70.6 kB ⚠️ +20 B
Overall change 310 kB 310 kB ⚠️ +93 B

Commit: 51ee4b0

@Timer Timer modified the milestones: 9.2.x, 9.2.2 Feb 8, 2020
@ijjk
Copy link
Member Author

ijjk commented Feb 8, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
buildDuration 12.3s 11.3s -1s
nodeModulesSize 52.6 MB 52.6 MB ⚠️ +635 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
main-HASH.js gzip 5.13 kB 5.13 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..e781.js gzip 13.8 kB 13.8 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.5 kB 67.5 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
main-HASH.module.js gzip 4.13 kB 4.13 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB 12.5 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 62.1 kB 62.1 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
_app.js gzip 1.15 kB 1.15 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.89 kB 2.89 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.68 kB 9.68 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
_app.module.js gzip 576 B 576 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.22 kB 7.22 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
index.html gzip 1.03 kB 1.03 kB ✓
link.html gzip 1.04 kB 1.04 kB ✓
withRouter.html gzip 1.03 kB 1.03 kB ✓
Overall change 3.11 kB 3.11 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
buildDuration 11.7s 12.2s ⚠️ +536ms
nodeModulesSize 52.6 MB 52.6 MB ⚠️ +635 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
main-HASH.js gzip 5.13 kB 5.13 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..e781.js gzip 13.8 kB 13.8 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.5 kB 67.5 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
main-HASH.module.js gzip 4.13 kB 4.13 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB 12.5 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 62.1 kB 62.1 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
_app.js gzip 1.15 kB 1.15 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.89 kB 2.89 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.68 kB 9.68 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
_app.module.js gzip 576 B 576 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.22 kB 7.22 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary ijjk/next.js add/ssg-rewrite-error Change
_error.js gzip 46.6 kB 46.6 kB ⚠️ +17 B
404.html gzip 1.45 kB 1.45 kB ✓
hooks.html gzip 1.08 kB 1.08 kB ✓
index.js gzip 46.7 kB 46.7 kB ⚠️ +20 B
link.js gzip 72.6 kB 72.6 kB ⚠️ +18 B
routerDirect.js gzip 70.8 kB 70.8 kB ⚠️ +18 B
withRouter.js gzip 70.6 kB 70.6 kB ⚠️ +20 B
Overall change 310 kB 310 kB ⚠️ +93 B

Commit: eddab69

@Timer Timer merged commit cbb9c2c into vercel:canary Feb 8, 2020
chibicode pushed a commit to chibicode/next.js that referenced this pull request Feb 11, 2020
@ijjk @Timer @chibicode
Add error message when rewriting to dynamic SSG page (vercel#10458)
1c930a8 
* Add error message when rewriting to dynamic SSG page

* Update comment

Co-authored-by: Joe Haddad <timer150@gmail.com>
This was referenced Mar 13, 2020
Closed
Open
This was referenced Mar 22, 2020
Merged
Merged
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.2.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @Timer