Add handling for default as named export in SSG transform #10486

ijjk · 2020-02-11T02:40:11Z

While implementing SSG on an app @lfades noticed we aren't handling a certain syntax in our SSG transform which causes the page to handle incorrectly since it isn't marked as an SSG page.

The syntax we are failing to handle in our transform is:

export function unstable_getStaticProps() {
  return { props: {} };
}

function El() {
  return <div />;
}


export { El as default };

ijjk · 2020-02-11T02:46:16Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
buildDuration	12.2s	12.1s	-60ms
nodeModulesSize	52.7 MB	52.7 MB	⚠️ +1.28 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
main-HASH.js gzip	5.13 kB	5.13 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..e781.js gzip	13.8 kB	13.8 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.5 kB	67.5 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
main-HASH.module.js gzip	4.13 kB	4.13 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
index.html gzip	1.03 kB	1.03 kB	✓
link.html gzip	1.04 kB	1.04 kB	✓
withRouter.html gzip	1.03 kB	1.03 kB	✓
Overall change	3.11 kB	3.11 kB	✓

Serverless Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
buildDuration	12.7s	12.7s	⚠️ +44ms
nodeModulesSize	52.7 MB	52.7 MB	⚠️ +1.28 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
main-HASH.js gzip	5.13 kB	5.13 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..e781.js gzip	13.8 kB	13.8 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.5 kB	67.5 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
main-HASH.module.js gzip	4.13 kB	4.13 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_error.js gzip	46.6 kB	46.6 kB	✓
404.html gzip	1.45 kB	1.45 kB	✓
hooks.html gzip	1.08 kB	1.08 kB	✓
index.js gzip	46.7 kB	46.7 kB	✓
link.js gzip	72.6 kB	72.6 kB	✓
routerDirect.js gzip	70.8 kB	70.8 kB	✓
withRouter.js gzip	70.6 kB	70.6 kB	✓
Overall change	310 kB	310 kB	✓

Commit: f606222

ijjk · 2020-02-11T19:25:10Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
buildDuration	11.3s	11s	-394ms
nodeModulesSize	52.7 MB	52.7 MB	⚠️ +1.28 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
main-HASH.js gzip	5.13 kB	5.13 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..e781.js gzip	13.8 kB	13.8 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.5 kB	67.5 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
main-HASH.module.js gzip	4.13 kB	4.13 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
index.html gzip	1.03 kB	1.03 kB	✓
link.html gzip	1.04 kB	1.04 kB	✓
withRouter.html gzip	1.03 kB	1.03 kB	✓
Overall change	3.11 kB	3.11 kB	✓

Serverless Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
buildDuration	12s	11.1s	-931ms
nodeModulesSize	52.7 MB	52.7 MB	⚠️ +1.28 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
main-HASH.js gzip	5.13 kB	5.13 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..e781.js gzip	13.8 kB	13.8 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.5 kB	67.5 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
main-HASH.module.js gzip	4.13 kB	4.13 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_error.js gzip	46.6 kB	46.6 kB	✓
404.html gzip	1.45 kB	1.45 kB	✓
hooks.html gzip	1.08 kB	1.08 kB	✓
index.js gzip	46.7 kB	46.7 kB	✓
link.js gzip	72.6 kB	72.6 kB	✓
routerDirect.js gzip	70.8 kB	70.8 kB	✓
withRouter.js gzip	70.6 kB	70.6 kB	✓
Overall change	310 kB	310 kB	✓

Commit: b3ca361

packages/next/build/babel/plugins/next-ssg-transform.ts

ijjk · 2020-02-13T05:08:55Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
buildDuration	9.5s	9.4s	-36ms
nodeModulesSize	52.9 MB	52.9 MB	⚠️ +1.28 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
main-HASH.js gzip	5.13 kB	5.13 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..c95c.js gzip	13.6 kB	13.6 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.4 kB	67.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
main-HASH.module.js gzip	4.13 kB	4.13 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.4 kB	12.4 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62 kB	62 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
index.html gzip	1.03 kB	1.03 kB	✓
link.html gzip	1.04 kB	1.04 kB	✓
withRouter.html gzip	1.03 kB	1.03 kB	✓
Overall change	3.11 kB	3.11 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
buildDuration	10.4s	10.2s	-245ms
nodeModulesSize	52.9 MB	52.9 MB	⚠️ +1.28 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
main-HASH.js gzip	5.13 kB	5.13 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..c95c.js gzip	13.6 kB	13.6 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.4 kB	67.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
main-HASH.module.js gzip	4.13 kB	4.13 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.4 kB	12.4 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62 kB	62 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_error.js gzip	290 kB	290 kB	⚠️ +445 B
404.html gzip	1.44 kB	1.44 kB	✓
hooks.html gzip	1.08 kB	1.08 kB	✓
index.js gzip	289 kB	290 kB	⚠️ +1.04 kB
link.js gzip	319 kB	319 kB	-185 B
routerDirect.js gzip	316 kB	316 kB	-53 B
withRouter.js gzip	315 kB	317 kB	⚠️ +1.52 kB
Overall change	1.53 MB	1.53 MB	⚠️ +2.76 kB

Commit: d3121c4

ijjk · 2020-02-13T05:12:55Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
buildDuration	11.2s	11.4s	⚠️ +297ms
nodeModulesSize	52.9 MB	52.9 MB	⚠️ +1.13 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
main-HASH.js gzip	5.13 kB	5.13 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..c95c.js gzip	13.6 kB	13.6 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.4 kB	67.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
main-HASH.module.js gzip	4.13 kB	4.13 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.4 kB	12.4 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62 kB	62 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
index.html gzip	1.03 kB	1.03 kB	✓
link.html gzip	1.04 kB	1.04 kB	✓
withRouter.html gzip	1.03 kB	1.03 kB	✓
Overall change	3.11 kB	3.11 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
buildDuration	12.4s	12.7s	⚠️ +290ms
nodeModulesSize	52.9 MB	52.9 MB	⚠️ +1.13 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
main-HASH.js gzip	5.13 kB	5.13 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..c95c.js gzip	13.6 kB	13.6 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.4 kB	67.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
main-HASH.module.js gzip	4.13 kB	4.13 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.4 kB	12.4 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62 kB	62 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_error.js gzip	290 kB	289 kB	-812 B
404.html gzip	1.44 kB	1.44 kB	✓
hooks.html gzip	1.08 kB	1.08 kB	✓
index.js gzip	290 kB	289 kB	-587 B
link.js gzip	320 kB	318 kB	-1.36 kB
routerDirect.js gzip	316 kB	316 kB	⚠️ +189 B
withRouter.js gzip	316 kB	315 kB	-820 B
Overall change	1.53 MB	1.53 MB	-3.4 kB

Commit: 07c4b77

ijjk · 2020-02-13T05:19:53Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
buildDuration	12.2s	12.5s	⚠️ +236ms
nodeModulesSize	52.9 MB	52.9 MB	⚠️ +1.13 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
main-HASH.js gzip	5.13 kB	5.13 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..c95c.js gzip	13.6 kB	13.6 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.4 kB	67.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
main-HASH.module.js gzip	4.13 kB	4.13 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.4 kB	12.4 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62 kB	62 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
index.html gzip	1.03 kB	1.03 kB	✓
link.html gzip	1.04 kB	1.04 kB	✓
withRouter.html gzip	1.03 kB	1.03 kB	✓
Overall change	3.11 kB	3.11 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
buildDuration	13.6s	13.6s	-87ms
nodeModulesSize	52.9 MB	52.9 MB	⚠️ +1.13 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
main-HASH.js gzip	5.13 kB	5.13 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..c95c.js gzip	13.6 kB	13.6 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.4 kB	67.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
main-HASH.module.js gzip	4.13 kB	4.13 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.4 kB	12.4 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62 kB	62 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/ssg-transform-bug	Change
_error.js gzip	289 kB	289 kB	-1 B
404.html gzip	1.44 kB	1.44 kB	✓
hooks.html gzip	1.08 kB	1.08 kB	✓
index.js gzip	289 kB	290 kB	⚠️ +685 B
link.js gzip	319 kB	319 kB	⚠️ +22 B
routerDirect.js gzip	316 kB	316 kB	⚠️ +719 B
withRouter.js gzip	315 kB	316 kB	⚠️ +1.18 kB
Overall change	1.53 MB	1.53 MB	⚠️ +2.61 kB

Commit: 80c2a2b

ijjk added 2 commits February 10, 2020 20:21

Add failing SSG syntax

f7cc57d

Add handling for default as named export in SSG transform

f606222

ijjk added the kind: bug Confirmed bug that is on the backlog label Feb 11, 2020

ijjk added this to the 9.2.2 milestone Feb 11, 2020

ijjk requested review from lfades, Timer and timneutkens as code owners February 11, 2020 02:40

Merge branch 'canary' into fix/ssg-transform-bug

b3ca361

Timer requested changes Feb 13, 2020

View reviewed changes

packages/next/build/babel/plugins/next-ssg-transform.ts Show resolved Hide resolved

Timer mentioned this pull request Feb 13, 2020

Fix export { _ as default } for SSG #10515

Closed

Timer added 3 commits February 13, 2020 00:03

Revert [comment].js

3875886

Revert index.js

d3121c4

adjust

07c4b77

Timer approved these changes Feb 13, 2020

View reviewed changes

Timer added ready to land labels Feb 13, 2020

Merge branch 'canary' into fix/ssg-transform-bug

80c2a2b

Timer merged commit 4617950 into vercel:canary Feb 13, 2020

ijjk deleted the fix/ssg-transform-bug branch February 13, 2020 05:25

This was referenced Mar 13, 2020

[Snyk] Upgrade next from 9.2.1 to 9.2.2 pixeldrew/hero-masq#10

Closed

[Snyk] Upgrade @next/mdx from 9.0.5 to 9.2.2 shahinalzahrani/docs#1

Open

This was referenced Mar 22, 2020

[Snyk] Upgrade next from 9.1.5 to 9.2.2 evantahler/next-static-hosting#3

Merged

[Snyk] Upgrade next from 9.2.1 to 9.2.2 grouparoo/next-plugins-example#3

Merged

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add handling for default as named export in SSG transform #10486

Add handling for default as named export in SSG transform #10486

ijjk commented Feb 11, 2020 •

edited by Timer

ijjk commented Feb 11, 2020

ijjk commented Feb 11, 2020

ijjk commented Feb 13, 2020

ijjk commented Feb 13, 2020

ijjk commented Feb 13, 2020

Add handling for default as named export in SSG transform #10486

Add handling for default as named export in SSG transform #10486

Conversation

ijjk commented Feb 11, 2020 • edited by Timer

ijjk commented Feb 11, 2020

Stats from current PR

ijjk commented Feb 11, 2020

Stats from current PR

ijjk commented Feb 13, 2020

Stats from current PR

ijjk commented Feb 13, 2020

Stats from current PR

ijjk commented Feb 13, 2020

Stats from current PR

ijjk commented Feb 11, 2020 •

edited by Timer