Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add global CSS styles to example/with-stripe-typescript #10520

Merged
merged 9 commits into from Feb 13, 2020
Merged

Add global CSS styles to example/with-stripe-typescript #10520

merged 9 commits into from Feb 13, 2020

Conversation

thorsten-stripe
Copy link
Contributor

r? @lfades

Adds a little lick of paint via global CSS styles.

@ijjk
Copy link
Member

ijjk commented Feb 13, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
buildDuration 13.8s 13.2s -602ms
nodeModulesSize 52.9 MB 52.9 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
main-HASH.js gzip 5.13 kB 5.13 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..c95c.js gzip 13.6 kB 13.6 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.4 kB 67.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
main-HASH.module.js gzip 4.13 kB 4.13 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.4 kB 12.4 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 62 kB 62 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
_app.js gzip 1.15 kB 1.15 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.89 kB 2.89 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.68 kB 9.68 kB ✓
Client Pages Modern
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
_app.module.js gzip 576 B 576 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.22 kB 7.22 kB ✓
Client Build Manifests
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
index.html gzip 1.03 kB 1.03 kB ✓
link.html gzip 1.04 kB 1.04 kB ✓
withRouter.html gzip 1.03 kB 1.03 kB ✓
Overall change 3.11 kB 3.11 kB ✓
Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
buildDuration 14.2s 15s ⚠️ +793ms
nodeModulesSize 52.9 MB 52.9 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
main-HASH.js gzip 5.13 kB 5.13 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..c95c.js gzip 13.6 kB 13.6 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.4 kB 67.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
main-HASH.module.js gzip 4.13 kB 4.13 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.4 kB 12.4 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 62 kB 62 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
_app.js gzip 1.15 kB 1.15 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.89 kB 2.89 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.68 kB 9.68 kB ✓
Client Pages Modern
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
_app.module.js gzip 576 B 576 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.22 kB 7.22 kB ✓
Client Build Manifests
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
_error.js gzip 290 kB 289 kB -792 B
404.html gzip 1.44 kB 1.44 kB ✓
hooks.html gzip 1.08 kB 1.08 kB ✓
index.js gzip 289 kB 289 kB -83 B
link.js gzip 319 kB 318 kB -842 B
routerDirect.js gzip 315 kB 316 kB ⚠️ +643 B
withRouter.js gzip 315 kB 316 kB ⚠️ +719 B
Overall change 1.53 MB 1.53 MB -355 B

Commit: 9365aa6

@ijjk
Copy link
Member

ijjk commented Feb 13, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
buildDuration 13.2s 12.8s -393ms
nodeModulesSize 52.9 MB 52.9 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
main-HASH.js gzip 5.13 kB 5.13 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..c95c.js gzip 13.6 kB 13.6 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.4 kB 67.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
main-HASH.module.js gzip 4.13 kB 4.13 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.4 kB 12.4 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 62 kB 62 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
_app.js gzip 1.15 kB 1.15 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.89 kB 2.89 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.68 kB 9.68 kB ✓
Client Pages Modern
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
_app.module.js gzip 576 B 576 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.22 kB 7.22 kB ✓
Client Build Manifests
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
index.html gzip 1.03 kB 1.03 kB ✓
link.html gzip 1.04 kB 1.04 kB ✓
withRouter.html gzip 1.03 kB 1.03 kB ✓
Overall change 3.11 kB 3.11 kB ✓
Serverless Mode (Increase detected ⚠️)
General
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
buildDuration 13.7s 13.9s ⚠️ +177ms
nodeModulesSize 52.9 MB 52.9 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
main-HASH.js gzip 5.13 kB 5.13 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..c95c.js gzip 13.6 kB 13.6 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.4 kB 67.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
main-HASH.module.js gzip 4.13 kB 4.13 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.4 kB 12.4 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 62 kB 62 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
_app.js gzip 1.15 kB 1.15 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.89 kB 2.89 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.68 kB 9.68 kB ✓
Client Pages Modern
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
_app.module.js gzip 576 B 576 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.22 kB 7.22 kB ✓
Client Build Manifests
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
_error.js gzip 290 kB 290 kB -8 B
404.html gzip 1.44 kB 1.44 kB ✓
hooks.html gzip 1.08 kB 1.08 kB ✓
index.js gzip 289 kB 290 kB ⚠️ +772 B
link.js gzip 319 kB 319 kB -506 B
routerDirect.js gzip 316 kB 316 kB -840 B
withRouter.js gzip 315 kB 316 kB ⚠️ +925 B
Overall change 1.53 MB 1.53 MB ⚠️ +343 B

Commit: 25bd1e6

@ijjk
Copy link
Member

ijjk commented Feb 13, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
buildDuration 12.9s 13.1s ⚠️ +204ms
nodeModulesSize 52.9 MB 52.9 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
main-HASH.js gzip 5.13 kB 5.13 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..c95c.js gzip 13.6 kB 13.6 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.4 kB 67.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
main-HASH.module.js gzip 4.13 kB 4.13 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.4 kB 12.4 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 62 kB 62 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
_app.js gzip 1.15 kB 1.15 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.89 kB 2.89 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.68 kB 9.68 kB ✓
Client Pages Modern
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
_app.module.js gzip 576 B 576 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.22 kB 7.22 kB ✓
Client Build Manifests
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
index.html gzip 1.03 kB 1.03 kB ✓
link.html gzip 1.04 kB 1.04 kB ✓
withRouter.html gzip 1.03 kB 1.03 kB ✓
Overall change 3.11 kB 3.11 kB ✓
Serverless Mode (Increase detected ⚠️)
General
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
buildDuration 15.2s 15.4s ⚠️ +148ms
nodeModulesSize 52.9 MB 52.9 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
main-HASH.js gzip 5.13 kB 5.13 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..c95c.js gzip 13.6 kB 13.6 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.4 kB 67.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
main-HASH.module.js gzip 4.13 kB 4.13 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.4 kB 12.4 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 62 kB 62 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
_app.js gzip 1.15 kB 1.15 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.89 kB 2.89 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.68 kB 9.68 kB ✓
Client Pages Modern
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
_app.module.js gzip 576 B 576 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.22 kB 7.22 kB ✓
Client Build Manifests
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary thorsten-stripe/next.js update-stripe-typescript-example Change
_error.js gzip 289 kB 290 kB ⚠️ +681 B
404.html gzip 1.44 kB 1.44 kB ✓
hooks.html gzip 1.08 kB 1.08 kB ✓
index.js gzip 289 kB 289 kB -183 B
link.js gzip 318 kB 319 kB ⚠️ +951 B
routerDirect.js gzip 316 kB 316 kB ⚠️ +58 B
withRouter.js gzip 316 kB 316 kB -200 B
Overall change 1.53 MB 1.53 MB ⚠️ +1.31 kB

Commit: 1bda24b

lfades
lfades approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thorsten-stripe Thank you! 💯

@lfades lfades merged commit d5222f8 into vercel:canary Feb 13, 2020
This was referenced Mar 13, 2020
Closed
Open
This was referenced Mar 22, 2020
Merged
Merged
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfades lfades lfades approved these changes

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thorsten-stripe @ijjk @lfades