Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use clearInterval instead of clearTimer on a timer #10597

Merged
merged 2 commits into from Feb 19, 2020
Merged

Use clearInterval instead of clearTimer on a timer #10597

merged 2 commits into from Feb 19, 2020

Conversation

TheRusskiy
Copy link
Contributor

This "timer" is created via setInterval, not setTimeout, but being cleared via clearTimeout.
https://github.com/TheRusskiy/next.js/blob/a480e6344793c54ae2b8c89ac5783a77095155b8/packages/next/client/dev/error-overlay/eventsource.js#L13

Sinon was complaining about it, and I traced back the source of the error back to next.js
https://github.com/sinonjs/sinon/blob/c8901e7bdfd95bc34daf509fa3cc56d3100fb206/docs/releases/sinon-1.17.7.js#L1046-L1056

@ijjk
Copy link
Member

ijjk commented Feb 19, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary TheRusskiy/next.js patch-1 Change
buildDuration 10s 10.1s ⚠️ +184ms
nodeModulesSize 53.8 MB 53.8 MB ⚠️ +2 B
Client Bundles (main, webpack, commons)
zeit/next.js canary TheRusskiy/next.js patch-1 Change
main-HASH.js gzip 5.05 kB 5.05 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..abdd.js gzip 12.2 kB 12.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary TheRusskiy/next.js patch-1 Change
main-HASH.module.js gzip 4.14 kB 4.14 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 9.2 kB 9.2 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary TheRusskiy/next.js patch-1 Change
polyfills-HASH.js gzip 20.3 kB 20.3 kB ✓
Overall change 20.3 kB 20.3 kB ✓
Client Pages
zeit/next.js canary TheRusskiy/next.js patch-1 Change
_app.js gzip 1.06 kB 1.06 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary TheRusskiy/next.js patch-1 Change
_app.module.js gzip 577 B 577 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary TheRusskiy/next.js patch-1 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary TheRusskiy/next.js patch-1 Change
index.html gzip 925 B 925 B ✓
link.html gzip 933 B 933 B ✓
withRouter.html gzip 922 B 922 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary TheRusskiy/next.js patch-1 Change
buildDuration 10.9s 10.8s -77ms
nodeModulesSize 53.8 MB 53.8 MB ⚠️ +2 B
Client Bundles (main, webpack, commons)
zeit/next.js canary TheRusskiy/next.js patch-1 Change
main-HASH.js gzip 5.05 kB 5.05 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..abdd.js gzip 12.2 kB 12.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary TheRusskiy/next.js patch-1 Change
main-HASH.module.js gzip 4.14 kB 4.14 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 9.2 kB 9.2 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary TheRusskiy/next.js patch-1 Change
polyfills-HASH.js gzip 20.3 kB 20.3 kB ✓
Overall change 20.3 kB 20.3 kB ✓
Client Pages
zeit/next.js canary TheRusskiy/next.js patch-1 Change
_app.js gzip 1.06 kB 1.06 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary TheRusskiy/next.js patch-1 Change
_app.module.js gzip 577 B 577 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary TheRusskiy/next.js patch-1 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary TheRusskiy/next.js patch-1 Change
_error.js gzip 289 kB 289 kB -29 B
404.html gzip 1.33 kB 1.33 kB ✓
hooks.html gzip 964 B 964 B ✓
index.js gzip 289 kB 290 kB ⚠️ +375 B
link.js gzip 299 kB 297 kB -1.43 kB
routerDirect.js gzip 297 kB 296 kB -367 B
withRouter.js gzip 296 kB 296 kB ⚠️ +376 B
Overall change 1.47 MB 1.47 MB -1.08 kB

Commit: a480e63

ijjk
ijjk approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for the PR!

@ijjk ijjk added this to the 9.3.0 milestone Feb 19, 2020
@ijjk
Copy link
Member

ijjk commented Feb 19, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary TheRusskiy/next.js patch-1 Change
buildDuration 11s 11s ⚠️ +13ms
nodeModulesSize 54.4 MB 54.4 MB ⚠️ +2 B
Client Bundles (main, webpack, commons)
zeit/next.js canary TheRusskiy/next.js patch-1 Change
main-HASH.js gzip 5.05 kB 5.05 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..9ee3.js gzip 12.2 kB 12.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary TheRusskiy/next.js patch-1 Change
main-HASH.module.js gzip 4.14 kB 4.14 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 9.2 kB 9.2 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary TheRusskiy/next.js patch-1 Change
polyfills-HASH.js gzip 20.3 kB 20.3 kB ✓
Overall change 20.3 kB 20.3 kB ✓
Client Pages
zeit/next.js canary TheRusskiy/next.js patch-1 Change
_app.js gzip 1.06 kB 1.06 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary TheRusskiy/next.js patch-1 Change
_app.module.js gzip 577 B 577 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary TheRusskiy/next.js patch-1 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary TheRusskiy/next.js patch-1 Change
index.html gzip 925 B 925 B ✓
link.html gzip 933 B 933 B ✓
withRouter.html gzip 924 B 924 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary TheRusskiy/next.js patch-1 Change
buildDuration 11.8s 11.8s ⚠️ +76ms
nodeModulesSize 54.4 MB 54.4 MB ⚠️ +2 B
Client Bundles (main, webpack, commons)
zeit/next.js canary TheRusskiy/next.js patch-1 Change
main-HASH.js gzip 5.05 kB 5.05 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..9ee3.js gzip 12.2 kB 12.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary TheRusskiy/next.js patch-1 Change
main-HASH.module.js gzip 4.14 kB 4.14 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 9.2 kB 9.2 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary TheRusskiy/next.js patch-1 Change
polyfills-HASH.js gzip 20.3 kB 20.3 kB ✓
Overall change 20.3 kB 20.3 kB ✓
Client Pages
zeit/next.js canary TheRusskiy/next.js patch-1 Change
_app.js gzip 1.06 kB 1.06 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary TheRusskiy/next.js patch-1 Change
_app.module.js gzip 577 B 577 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary TheRusskiy/next.js patch-1 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary TheRusskiy/next.js patch-1 Change
_error.js gzip 289 kB 290 kB ⚠️ +1 kB
404.html gzip 1.33 kB 1.33 kB ✓
hooks.html gzip 965 B 965 B ✓
index.js gzip 290 kB 290 kB -53 B
link.js gzip 299 kB 297 kB -1.44 kB
routerDirect.js gzip 296 kB 298 kB ⚠️ +1.39 kB
withRouter.js gzip 296 kB 298 kB ⚠️ +1.32 kB
Overall change 1.47 MB 1.47 MB ⚠️ +2.22 kB

Commit: ec9fd90

@Timer Timer merged commit b3fad60 into vercel:canary Feb 19, 2020
@snyk-bot snyk-bot mentioned this pull request Apr 9, 2020
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TheRusskiy @ijjk @Timer