Remove next/link from Example: With Chakra UI
#10625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adithwip
changed the title
next/link from Example: With Chakra UI
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Increase detected
|
| zeit/next.js canary | adithwip/next.js improvement-example-with-chara-ui | Change | |
|---|---|---|---|
| buildDuration | 10.6s | 10.6s | |
| nodeModulesSize | 54.5 MB | 54.5 MB | ✓ |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | adithwip/next.js improvement-example-with-chara-ui | Change | |
|---|---|---|---|
| main-HASH.js gzip | 5.05 kB | 5.05 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..b61f.js gzip | 12.3 kB | 12.3 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 57.2 kB | 57.2 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | adithwip/next.js improvement-example-with-chara-ui | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.14 kB | 4.14 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 9.22 kB | 9.22 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 53.2 kB | 53.2 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | adithwip/next.js improvement-example-with-chara-ui | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 18.9 kB | 18.9 kB | ✓ |
| Overall change | 18.9 kB | 18.9 kB | ✓ |
Client Pages
| zeit/next.js canary | adithwip/next.js improvement-example-with-chara-ui | Change | |
|---|---|---|---|
| _app.js gzip | 1.06 kB | 1.06 kB | ✓ |
| _error.js gzip | 2.98 kB | 2.98 kB | ✓ |
| hooks.js gzip | 664 B | 664 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 1.9 kB | 1.9 kB | ✓ |
| routerDirect.js gzip | 279 B | 279 B | ✓ |
| withRouter.js gzip | 278 B | 278 B | ✓ |
| Overall change | 7.38 kB | 7.38 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | adithwip/next.js improvement-example-with-chara-ui | Change | |
|---|---|---|---|
| _app.module.js gzip | 577 B | 577 B | ✓ |
| _error.module.js gzip | 2.08 kB | 2.08 kB | ✓ |
| hooks.module.js gzip | 370 B | 370 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 1.48 kB | 1.48 kB | ✓ |
| routerDirect..dule.js gzip | 271 B | 271 B | ✓ |
| withRouter.m..dule.js gzip | 270 B | 270 B | ✓ |
| Overall change | 5.26 kB | 5.26 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | adithwip/next.js improvement-example-with-chara-ui | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
| zeit/next.js canary | adithwip/next.js improvement-example-with-chara-ui | Change | |
|---|---|---|---|
| _error.js gzip | 289 kB | 290 kB | |
| 404.html gzip | 1.33 kB | 1.33 kB | ✓ |
| hooks.html gzip | 964 B | 964 B | ✓ |
| index.js gzip | 289 kB | 289 kB | |
| link.js gzip | 297 kB | 297 kB | -81 B |
| routerDirect.js gzip | 297 kB | 296 kB | -341 B |
| withRouter.js gzip | 296 kB | 296 kB | -53 B |
| Overall change | 1.47 MB | 1.47 MB |
Commit: a8c821a
timneutkens
approved these changes
Feb 21, 2020
|
Displayed in changelogs as "Remove next/link" which costed me a few heartbeats 😥 |
|
Yeah I couldn't change it after merging 🤦♂ It has to do with github sanitization of backticks |
|
Updated the release notes! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When the example is run, it'll show an error that tells an invalid
hrefin<Link>from thenext/linkcomponent.Culprit
At first, I thought it has a connection with the Next version in the example dependencies.
But it turns out because, in the example, it used two
Linkcomponents:next/link@chakra-ui/coreSo
Because the intention from the original creator of the example is to make the link to redirect to another page (not SPA). So I think, removing the
next/linkand only use theLinkfrom@chakra-ui-coreis sufficient.Screenshot