Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview Mode Should Not Cache #10636

Merged
merged 6 commits into from Feb 22, 2020
Merged

Preview Mode Should Not Cache #10636

merged 6 commits into from Feb 22, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Feb 22, 2020

This fixes a bug where preview mode would respond with server-side caching headers.

@Timer Timer added the kind: bug Confirmed bug that is on the backlog label Feb 22, 2020
@Timer Timer added this to the 9.3.0 milestone Feb 22, 2020
@ijjk
Copy link
Member

ijjk commented Feb 22, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
buildDuration 10.3s 10.3s ⚠️ +21ms
nodeModulesSize 54.5 MB 54.5 MB ⚠️ +1.94 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
main-HASH.js gzip 5.05 kB 5.05 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..b61f.js gzip 12.3 kB 12.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
main-HASH.module.js gzip 4.14 kB 4.14 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
_app.js gzip 1.06 kB 1.06 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
_app.module.js gzip 577 B 577 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
index.html gzip 923 B 923 B ✓
link.html gzip 933 B 933 B ✓
withRouter.html gzip 921 B 921 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
buildDuration 11.1s 10.5s -579ms
nodeModulesSize 54.5 MB 54.5 MB ⚠️ +1.94 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
main-HASH.js gzip 5.05 kB 5.05 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..b61f.js gzip 12.3 kB 12.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
main-HASH.module.js gzip 4.14 kB 4.14 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
_app.js gzip 1.06 kB 1.06 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
_app.module.js gzip 577 B 577 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
_error.js gzip 289 kB 289 kB -47 B
404.html gzip 1.33 kB 1.33 kB ✓
hooks.html gzip 963 B 963 B ✓
index.js gzip 289 kB 290 kB ⚠️ +859 B
link.js gzip 297 kB 298 kB ⚠️ +213 B
routerDirect.js gzip 297 kB 297 kB ⚠️ +42 B
withRouter.js gzip 297 kB 296 kB -244 B
Overall change 1.47 MB 1.47 MB ⚠️ +823 B

Commit: 7070d39

@ijjk
Copy link
Member

ijjk commented Feb 22, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
buildDuration 10.7s 10.9s ⚠️ +239ms
nodeModulesSize 54.5 MB 54.5 MB ⚠️ +1.94 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
main-HASH.js gzip 5.05 kB 5.05 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..b61f.js gzip 12.3 kB 12.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
main-HASH.module.js gzip 4.14 kB 4.14 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
_app.js gzip 1.06 kB 1.06 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
_app.module.js gzip 577 B 577 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
index.html gzip 923 B 923 B ✓
link.html gzip 933 B 933 B ✓
withRouter.html gzip 921 B 921 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
buildDuration 11.8s 12s ⚠️ +154ms
nodeModulesSize 54.5 MB 54.5 MB ⚠️ +1.94 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
main-HASH.js gzip 5.05 kB 5.05 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..b61f.js gzip 12.3 kB 12.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
main-HASH.module.js gzip 4.14 kB 4.14 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
_app.js gzip 1.06 kB 1.06 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
_app.module.js gzip 577 B 577 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
_error.js gzip 289 kB 289 kB -80 B
404.html gzip 1.33 kB 1.33 kB ✓
hooks.html gzip 963 B 963 B ✓
index.js gzip 290 kB 289 kB -734 B
link.js gzip 298 kB 298 kB -526 B
routerDirect.js gzip 296 kB 296 kB ⚠️ +58 B
withRouter.js gzip 297 kB 296 kB -161 B
Overall change 1.47 MB 1.47 MB -1.44 kB

Commit: 53938d5

@Timer Timer requested a review from ijjk February 22, 2020 06:05
@ijjk
Copy link
Member

ijjk commented Feb 22, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
buildDuration 9.2s 9.6s ⚠️ +410ms
nodeModulesSize 54.5 MB 54.5 MB ⚠️ +2.28 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
main-HASH.js gzip 5.05 kB 5.05 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..b61f.js gzip 12.3 kB 12.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
main-HASH.module.js gzip 4.14 kB 4.14 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
_app.js gzip 1.06 kB 1.06 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
_app.module.js gzip 577 B 577 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
index.html gzip 923 B 923 B ✓
link.html gzip 933 B 933 B ✓
withRouter.html gzip 921 B 921 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
buildDuration 10.6s 10.7s ⚠️ +42ms
nodeModulesSize 54.5 MB 54.5 MB ⚠️ +2.28 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
main-HASH.js gzip 5.05 kB 5.05 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..b61f.js gzip 12.3 kB 12.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
main-HASH.module.js gzip 4.14 kB 4.14 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
_app.js gzip 1.06 kB 1.06 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
_app.module.js gzip 577 B 577 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary Timer/next.js hotfix/preview-is-private Change
_error.js gzip 289 kB 290 kB ⚠️ +623 B
404.html gzip 1.33 kB 1.33 kB ✓
hooks.html gzip 963 B 963 B ✓
index.js gzip 289 kB 290 kB ⚠️ +819 B
link.js gzip 298 kB 298 kB ⚠️ +82 B
routerDirect.js gzip 297 kB 296 kB -335 B
withRouter.js gzip 296 kB 296 kB ⚠️ +59 B
Overall change 1.47 MB 1.47 MB ⚠️ +1.25 kB

Commit: 5e80ddb

@timneutkens timneutkens merged commit 89c792f into vercel:canary Feb 22, 2020
@Timer Timer deleted the hotfix/preview-is-private branch February 22, 2020 16:10
@snyk-bot snyk-bot mentioned this pull request Apr 9, 2020
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@lfades lfades Awaiting requested review from lfades

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

Assignees
No one assigned
Labels
kind: bug Confirmed bug that is on the backlog
Projects
None yet
Milestone
9.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Timer @ijjk @timneutkens