Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example "with-typescript-graphql" #10637

Merged
merged 3 commits into from Feb 25, 2020
Merged

Conversation

piglovesyou
Copy link
Contributor

  • Utilize resolver types by @graphql-codegen/typescript-resolvers to implement resolvers robustly
  • Enable respectGitIgnore option to ignore directories easily
  • Preparing graphql-let 0.9.0 update that will move @graphql-codegen/cli to peerDependencies
  • Update other deps

@ijjk
Copy link
Member

ijjk commented Feb 22, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary piglovesyou/next.js update-deps Change
buildDuration 10s 9.9s -54ms
nodeModulesSize 54.5 MB 54.5 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary piglovesyou/next.js update-deps Change
main-HASH.js gzip 5.05 kB 5.05 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..b61f.js gzip 12.3 kB 12.3 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary piglovesyou/next.js update-deps Change
main-HASH.module.js gzip 4.14 kB 4.14 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary piglovesyou/next.js update-deps Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary piglovesyou/next.js update-deps Change
_app.js gzip 1.06 kB 1.06 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary piglovesyou/next.js update-deps Change
_app.module.js gzip 577 B 577 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary piglovesyou/next.js update-deps Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary piglovesyou/next.js update-deps Change
index.html gzip 923 B 923 B
link.html gzip 933 B 933 B
withRouter.html gzip 921 B 921 B
Overall change 2.78 kB 2.78 kB

Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary piglovesyou/next.js update-deps Change
buildDuration 10.8s 11s ⚠️ +185ms
nodeModulesSize 54.5 MB 54.5 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary piglovesyou/next.js update-deps Change
main-HASH.js gzip 5.05 kB 5.05 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..b61f.js gzip 12.3 kB 12.3 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary piglovesyou/next.js update-deps Change
main-HASH.module.js gzip 4.14 kB 4.14 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary piglovesyou/next.js update-deps Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary piglovesyou/next.js update-deps Change
_app.js gzip 1.06 kB 1.06 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary piglovesyou/next.js update-deps Change
_app.module.js gzip 577 B 577 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary piglovesyou/next.js update-deps Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall decrease ✓
zeit/next.js canary piglovesyou/next.js update-deps Change
_error.js gzip 290 kB 289 kB -716 B
404.html gzip 1.33 kB 1.33 kB
hooks.html gzip 963 B 963 B
index.js gzip 290 kB 289 kB -525 B
link.js gzip 299 kB 297 kB -1.4 kB
routerDirect.js gzip 298 kB 296 kB -1.43 kB
withRouter.js gzip 296 kB 296 kB ⚠️ +11 B
Overall change 1.48 MB 1.47 MB -4.06 kB

Commit: d4f4961

Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @piglovesyou

@lfades lfades merged commit ccb42b0 into vercel:canary Feb 25, 2020
@piglovesyou piglovesyou deleted the update-deps branch February 26, 2020 08:54
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants