Update url prop handling for pages with new data methods #10653

ijjk · 2020-02-23T22:58:32Z

This makes sure to show an error if a user tries to use the url prop name as it is reserved by Next.js currently. It also adds an err.sh explaining where this is being returned from and adds tests making sure the error is shown correctly for getServerProps and getStaticProps

ijjk · 2020-02-23T23:03:12Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
buildDuration	7.8s	7.3s	-484ms
nodeModulesSize	54.5 MB	54.5 MB	⚠️ +585 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.js gzip	5.05 kB	5.05 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..b61f.js gzip	12.3 kB	12.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.module.js gzip	4.14 kB	4.14 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	9.22 kB	9.22 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	53.2 kB	53.2 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.js gzip	1.06 kB	1.06 kB	✓
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.9 kB	1.9 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.module.js gzip	577 B	577 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.26 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
index.html gzip	923 B	923 B	✓
link.html gzip	933 B	933 B	✓
withRouter.html gzip	922 B	922 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
buildDuration	8s	8s	-11ms
nodeModulesSize	54.5 MB	54.5 MB	⚠️ +585 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.js gzip	5.05 kB	5.05 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..b61f.js gzip	12.3 kB	12.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.module.js gzip	4.14 kB	4.14 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	9.22 kB	9.22 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	53.2 kB	53.2 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.js gzip	1.06 kB	1.06 kB	✓
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.9 kB	1.9 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.module.js gzip	577 B	577 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.26 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_error.js gzip	289 kB	290 kB	⚠️ +691 B
404.html gzip	1.33 kB	1.33 kB	✓
hooks.html gzip	963 B	963 B	✓
index.js gzip	289 kB	290 kB	⚠️ +189 B
link.js gzip	298 kB	299 kB	⚠️ +1.2 kB
routerDirect.js gzip	297 kB	298 kB	⚠️ +1.42 kB
withRouter.js gzip	298 kB	296 kB	-1.39 kB
Overall change	1.47 MB	1.47 MB	⚠️ +2.11 kB

Commit: 929f963

ijjk · 2020-02-23T23:15:51Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
buildDuration	9.6s	9.5s	-85ms
nodeModulesSize	54.5 MB	54.5 MB	⚠️ +659 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.js gzip	5.05 kB	5.05 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..b61f.js gzip	12.3 kB	12.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.module.js gzip	4.14 kB	4.14 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	9.22 kB	9.22 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	53.2 kB	53.2 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.js gzip	1.06 kB	1.06 kB	✓
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.9 kB	1.9 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.module.js gzip	577 B	577 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.26 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
index.html gzip	923 B	923 B	✓
link.html gzip	933 B	933 B	✓
withRouter.html gzip	922 B	922 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
buildDuration	10.3s	10.3s	⚠️ +24ms
nodeModulesSize	54.5 MB	54.5 MB	⚠️ +659 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.js gzip	5.05 kB	5.05 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..b61f.js gzip	12.3 kB	12.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.module.js gzip	4.14 kB	4.14 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	9.22 kB	9.22 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	53.2 kB	53.2 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.js gzip	1.06 kB	1.06 kB	✓
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.9 kB	1.9 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.module.js gzip	577 B	577 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.26 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_error.js gzip	290 kB	290 kB	⚠️ +685 B
404.html gzip	1.33 kB	1.33 kB	✓
hooks.html gzip	963 B	963 B	✓
index.js gzip	290 kB	290 kB	⚠️ +110 B
link.js gzip	297 kB	298 kB	⚠️ +128 B
routerDirect.js gzip	297 kB	296 kB	-895 B
withRouter.js gzip	296 kB	298 kB	⚠️ +1.42 kB
Overall change	1.47 MB	1.47 MB	⚠️ +1.44 kB

Commit: 7c0ae39

Timer

Why do we set the url prop? Is it only for legacy reasons?

We should get rid of this (and any other props we send) when using the new data fetching methods IMO.

packages/next/next-server/server/render.tsx

Co-Authored-By: Tim Neutkens <tim@timneutkens.nl>

ijjk · 2020-02-24T16:25:44Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
buildDuration	10s	10.2s	⚠️ +258ms
nodeModulesSize	56.2 MB	56.2 MB	⚠️ +695 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.js gzip	5.05 kB	5.05 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..b61f.js gzip	12.3 kB	12.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.module.js gzip	4.14 kB	4.14 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	9.22 kB	9.22 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	53.2 kB	53.2 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.js gzip	1.06 kB	1.06 kB	✓
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.9 kB	1.9 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.module.js gzip	577 B	577 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.26 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
index.html gzip	923 B	923 B	✓
link.html gzip	933 B	933 B	✓
withRouter.html gzip	922 B	922 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
buildDuration	10.7s	11.1s	⚠️ +443ms
nodeModulesSize	56.2 MB	56.2 MB	⚠️ +695 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.js gzip	5.05 kB	5.05 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..b61f.js gzip	12.3 kB	12.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.module.js gzip	4.14 kB	4.14 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	9.22 kB	9.22 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	53.2 kB	53.2 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.js gzip	1.06 kB	1.06 kB	✓
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.9 kB	1.9 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.module.js gzip	577 B	577 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.26 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_error.js gzip	290 kB	289 kB	-664 B
404.html gzip	1.33 kB	1.33 kB	✓
hooks.html gzip	963 B	963 B	✓
index.js gzip	290 kB	290 kB	⚠️ +620 B
link.js gzip	298 kB	299 kB	⚠️ +1.26 kB
routerDirect.js gzip	297 kB	296 kB	-613 B
withRouter.js gzip	296 kB	296 kB	⚠️ +33 B
Overall change	1.47 MB	1.47 MB	⚠️ +633 B

Commit: 8704ff0

ijjk · 2020-02-24T19:03:42Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
buildDuration	8.7s	8.6s	-90ms
nodeModulesSize	56.2 MB	56.2 MB	⚠️ +695 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.js gzip	5.05 kB	5.05 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..b61f.js gzip	12.3 kB	12.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.module.js gzip	4.14 kB	4.14 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	9.22 kB	9.22 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	53.2 kB	53.2 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.js gzip	1.06 kB	1.06 kB	✓
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.9 kB	1.9 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.module.js gzip	577 B	577 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.26 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
index.html gzip	924 B	924 B	✓
link.html gzip	934 B	934 B	✓
withRouter.html gzip	922 B	922 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
buildDuration	9.2s	9.3s	⚠️ +192ms
nodeModulesSize	56.2 MB	56.2 MB	⚠️ +695 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.js gzip	5.05 kB	5.05 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..b61f.js gzip	12.3 kB	12.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.module.js gzip	4.14 kB	4.14 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	9.22 kB	9.22 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	53.2 kB	53.2 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.js gzip	1.06 kB	1.06 kB	✓
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.9 kB	1.9 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.module.js gzip	577 B	577 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.26 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_error.js gzip	290 kB	290 kB	⚠️ +91 B
404.html gzip	1.33 kB	1.33 kB	✓
hooks.html gzip	963 B	963 B	✓
index.js gzip	290 kB	289 kB	-192 B
link.js gzip	298 kB	298 kB	⚠️ +83 B
routerDirect.js gzip	297 kB	298 kB	⚠️ +698 B
withRouter.js gzip	297 kB	296 kB	-295 B
Overall change	1.47 MB	1.47 MB	⚠️ +385 B

Commit: 41da9ec

ijjk · 2020-02-25T15:22:11Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
buildDuration	10s	9.8s	-247ms
nodeModulesSize	56.2 MB	56.2 MB	⚠️ +695 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.js gzip	5.05 kB	5.05 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..b61f.js gzip	12.3 kB	12.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.module.js gzip	4.14 kB	4.14 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	9.22 kB	9.22 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	53.2 kB	53.2 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.js gzip	1.06 kB	1.06 kB	✓
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.9 kB	1.9 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.module.js gzip	577 B	577 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.26 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
index.html gzip	924 B	924 B	✓
link.html gzip	934 B	934 B	✓
withRouter.html gzip	922 B	922 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
buildDuration	10.6s	11.1s	⚠️ +536ms
nodeModulesSize	56.2 MB	56.2 MB	⚠️ +695 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.js gzip	5.05 kB	5.05 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..b61f.js gzip	12.3 kB	12.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.module.js gzip	4.14 kB	4.14 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	9.22 kB	9.22 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	53.2 kB	53.2 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.js gzip	1.06 kB	1.06 kB	✓
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.9 kB	1.9 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.module.js gzip	577 B	577 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.26 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_error.js gzip	289 kB	290 kB	⚠️ +531 B
404.html gzip	1.33 kB	1.33 kB	✓
hooks.html gzip	963 B	963 B	✓
index.js gzip	290 kB	290 kB	⚠️ +535 B
link.js gzip	298 kB	298 kB	-542 B
routerDirect.js gzip	298 kB	297 kB	-1.41 kB
withRouter.js gzip	297 kB	297 kB	-481 B
Overall change	1.47 MB	1.47 MB	-1.36 kB

Commit: 76b25f3

ijjk · 2020-02-25T16:08:36Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
buildDuration	11.9s	11.6s	-310ms
nodeModulesSize	56.2 MB	56.2 MB	⚠️ +2.96 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.js gzip	5.05 kB	5.05 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..b61f.js gzip	12.3 kB	12.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.module.js gzip	4.14 kB	4.14 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	9.22 kB	9.22 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	53.2 kB	53.2 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.js gzip	1.06 kB	1.07 kB	⚠️ +14 B
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.9 kB	1.9 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.4 kB	⚠️ +14 B

Client Pages Modern Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.module.js gzip	577 B	589 B	⚠️ +12 B
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.27 kB	⚠️ +12 B

Client Build Manifests

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
index.html gzip	924 B	924 B	✓
link.html gzip	934 B	934 B	✓
withRouter.html gzip	922 B	922 B	✓
Overall change	2.78 kB	2.78 kB	✓

Diffs

Diff for _app.js

@@ -118,10 +118,11 @@ function (_react$default$Compon) {
           router = _this$props.router,
           Component = _this$props.Component,
           pageProps = _this$props.pageProps;
-      var url = createUrl(router);
-      return _react["default"].createElement(Component, Object.assign({}, pageProps, {
-        url: url
-      }));
+      return _react["default"].createElement(Component, Object.assign({}, pageProps, // we don't add the legacy URL prop if it's a using non-legacy
+      // methods like getStaticProps and getServerProps
+      !(Component.__N_SSG || Component.__N_SSP) ? {
+        url: createUrl(router)
+      } : {}));
     }
   }]);

Diff for _app.module.js

@@ -57,10 +57,11 @@ class App extends _react.default.Component {
       Component,
       pageProps
     } = this.props;
-    var url = createUrl(router);
-    return _react.default.createElement(Component, Object.assign({}, pageProps, {
-      url: url
-    }));
+    return _react.default.createElement(Component, Object.assign({}, pageProps, // we don't add the legacy URL prop if it's a using non-legacy
+    // methods like getStaticProps and getServerProps
+    !(Component.__N_SSG || Component.__N_SSP) ? {
+      url: createUrl(router)
+    } : {}));
   }
 
 }

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
buildDuration	12.8s	12.8s	⚠️ +27ms
nodeModulesSize	56.2 MB	56.2 MB	⚠️ +2.96 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.js gzip	5.05 kB	5.05 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..b61f.js gzip	12.3 kB	12.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.module.js gzip	4.14 kB	4.14 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	9.22 kB	9.22 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	53.2 kB	53.2 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.js gzip	1.06 kB	1.07 kB	⚠️ +14 B
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.9 kB	1.9 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.4 kB	⚠️ +14 B

Client Pages Modern Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.module.js gzip	577 B	589 B	⚠️ +12 B
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.27 kB	⚠️ +12 B

Client Build Manifests

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_error.js gzip	290 kB	290 kB	-77 B
404.html gzip	1.33 kB	1.33 kB	✓
hooks.html gzip	963 B	963 B	✓
index.js gzip	290 kB	291 kB	⚠️ +1.2 kB
link.js gzip	297 kB	299 kB	⚠️ +1.4 kB
routerDirect.js gzip	296 kB	297 kB	⚠️ +394 B
withRouter.js gzip	296 kB	297 kB	⚠️ +202 B
Overall change	1.47 MB	1.48 MB	⚠️ +3.13 kB

Commit: 4954648

ijjk · 2020-02-25T16:17:48Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
buildDuration	10.9s	11.2s	⚠️ +307ms
nodeModulesSize	56.2 MB	56.2 MB	⚠️ +2.96 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.js gzip	5.05 kB	5.05 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..b61f.js gzip	12.3 kB	12.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.module.js gzip	4.14 kB	4.14 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	9.22 kB	9.22 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	53.2 kB	53.2 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.js gzip	1.06 kB	1.07 kB	⚠️ +14 B
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.9 kB	1.9 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.4 kB	⚠️ +14 B

Client Pages Modern Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.module.js gzip	577 B	589 B	⚠️ +12 B
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.27 kB	⚠️ +12 B

Client Build Manifests

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
index.html gzip	924 B	924 B	✓
link.html gzip	934 B	934 B	✓
withRouter.html gzip	922 B	922 B	✓
Overall change	2.78 kB	2.78 kB	✓

Diffs

Diff for _app.js

@@ -118,10 +118,11 @@ function (_react$default$Compon) {
           router = _this$props.router,
           Component = _this$props.Component,
           pageProps = _this$props.pageProps;
-      var url = createUrl(router);
-      return _react["default"].createElement(Component, Object.assign({}, pageProps, {
-        url: url
-      }));
+      return _react["default"].createElement(Component, Object.assign({}, pageProps, // we don't add the legacy URL prop if it's a using non-legacy
+      // methods like getStaticProps and getServerProps
+      !(Component.__N_SSG || Component.__N_SSP) ? {
+        url: createUrl(router)
+      } : {}));
     }
   }]);

Diff for _app.module.js

@@ -57,10 +57,11 @@ class App extends _react.default.Component {
       Component,
       pageProps
     } = this.props;
-    var url = createUrl(router);
-    return _react.default.createElement(Component, Object.assign({}, pageProps, {
-      url: url
-    }));
+    return _react.default.createElement(Component, Object.assign({}, pageProps, // we don't add the legacy URL prop if it's a using non-legacy
+    // methods like getStaticProps and getServerProps
+    !(Component.__N_SSG || Component.__N_SSP) ? {
+      url: createUrl(router)
+    } : {}));
   }
 
 }

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
buildDuration	11.7s	11.9s	⚠️ +203ms
nodeModulesSize	56.2 MB	56.2 MB	⚠️ +2.96 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.js gzip	5.05 kB	5.05 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..b61f.js gzip	12.3 kB	12.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.module.js gzip	4.14 kB	4.14 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	9.22 kB	9.22 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	53.2 kB	53.2 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.js gzip	1.06 kB	1.07 kB	⚠️ +14 B
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.9 kB	1.9 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.4 kB	⚠️ +14 B

Client Pages Modern Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.module.js gzip	577 B	589 B	⚠️ +12 B
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.27 kB	⚠️ +12 B

Client Build Manifests

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_error.js gzip	289 kB	290 kB	⚠️ +1.03 kB
404.html gzip	1.33 kB	1.33 kB	✓
hooks.html gzip	963 B	963 B	✓
index.js gzip	289 kB	290 kB	⚠️ +911 B
link.js gzip	297 kB	298 kB	⚠️ +501 B
routerDirect.js gzip	297 kB	297 kB	-355 B
withRouter.js gzip	297 kB	297 kB	-20 B
Overall change	1.47 MB	1.47 MB	⚠️ +2.06 kB

Commit: 000838e

test/integration/client-navigation/test/rendering.js

test/integration/getserverprops/test/index.test.js

test/integration/prerender/test/index.test.js

packages/next/next-server/server/render.tsx

ijjk · 2020-02-26T15:31:32Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
buildDuration	11.6s	11.6s	-8ms
nodeModulesSize	56.2 MB	56.2 MB	⚠️ +2.93 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.js gzip	4.98 kB	4.98 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..b61f.js gzip	12.3 kB	12.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.1 kB	57.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.module.js gzip	4.1 kB	4.1 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	9.22 kB	9.22 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	53.2 kB	53.2 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.js gzip	1.06 kB	1.07 kB	⚠️ +14 B
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.9 kB	1.9 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.4 kB	⚠️ +14 B

Client Pages Modern Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.module.js gzip	577 B	589 B	⚠️ +12 B
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.27 kB	⚠️ +12 B

Client Build Manifests

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
index.html gzip	927 B	927 B	✓
link.html gzip	933 B	933 B	✓
withRouter.html gzip	924 B	924 B	✓
Overall change	2.78 kB	2.78 kB	✓

Diffs

Diff for _app.js

@@ -118,10 +118,11 @@ function (_react$default$Compon) {
           router = _this$props.router,
           Component = _this$props.Component,
           pageProps = _this$props.pageProps;
-      var url = createUrl(router);
-      return _react["default"].createElement(Component, Object.assign({}, pageProps, {
-        url: url
-      }));
+      return _react["default"].createElement(Component, Object.assign({}, pageProps, // we don't add the legacy URL prop if it's using non-legacy
+      // methods like getStaticProps and getServerProps
+      !(Component.__N_SSG || Component.__N_SSP) ? {
+        url: createUrl(router)
+      } : {}));
     }
   }]);

Diff for _app.module.js

@@ -57,10 +57,11 @@ class App extends _react.default.Component {
       Component,
       pageProps
     } = this.props;
-    var url = createUrl(router);
-    return _react.default.createElement(Component, Object.assign({}, pageProps, {
-      url: url
-    }));
+    return _react.default.createElement(Component, Object.assign({}, pageProps, // we don't add the legacy URL prop if it's using non-legacy
+    // methods like getStaticProps and getServerProps
+    !(Component.__N_SSG || Component.__N_SSP) ? {
+      url: createUrl(router)
+    } : {}));
   }
 
 }

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
buildDuration	12.4s	12.3s	-72ms
nodeModulesSize	56.2 MB	56.2 MB	⚠️ +2.93 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.js gzip	4.98 kB	4.98 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..b61f.js gzip	12.3 kB	12.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.1 kB	57.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.module.js gzip	4.1 kB	4.1 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	9.22 kB	9.22 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	53.2 kB	53.2 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.js gzip	1.06 kB	1.07 kB	⚠️ +14 B
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.9 kB	1.9 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.4 kB	⚠️ +14 B

Client Pages Modern Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.module.js gzip	577 B	589 B	⚠️ +12 B
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.27 kB	⚠️ +12 B

Client Build Manifests

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_error.js gzip	290 kB	290 kB	-202 B
404.html gzip	1.33 kB	1.33 kB	✓
hooks.html gzip	964 B	964 B	✓
index.js gzip	289 kB	290 kB	⚠️ +1.03 kB
link.js gzip	299 kB	298 kB	-975 B
routerDirect.js gzip	297 kB	297 kB	-315 B
withRouter.js gzip	298 kB	298 kB	⚠️ +154 B
Overall change	1.48 MB	1.48 MB	-305 B

Commit: 2772c48

packages/next/next-server/server/render.tsx

ijjk · 2020-02-26T15:51:49Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
buildDuration	9.5s	9.1s	-377ms
nodeModulesSize	56.2 MB	56.2 MB	⚠️ +3 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.js gzip	4.98 kB	4.98 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..b61f.js gzip	12.3 kB	12.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.1 kB	57.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.module.js gzip	4.1 kB	4.1 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	9.22 kB	9.22 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	53.2 kB	53.2 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.js gzip	1.06 kB	1.07 kB	⚠️ +14 B
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.9 kB	1.9 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.4 kB	⚠️ +14 B

Client Pages Modern Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.module.js gzip	577 B	589 B	⚠️ +12 B
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.27 kB	⚠️ +12 B

Client Build Manifests

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
index.html gzip	927 B	927 B	✓
link.html gzip	933 B	933 B	✓
withRouter.html gzip	924 B	924 B	✓
Overall change	2.78 kB	2.78 kB	✓

Diffs

Diff for _app.js

@@ -118,10 +118,11 @@ function (_react$default$Compon) {
           router = _this$props.router,
           Component = _this$props.Component,
           pageProps = _this$props.pageProps;
-      var url = createUrl(router);
-      return _react["default"].createElement(Component, Object.assign({}, pageProps, {
-        url: url
-      }));
+      return _react["default"].createElement(Component, Object.assign({}, pageProps, // we don't add the legacy URL prop if it's using non-legacy
+      // methods like getStaticProps and getServerProps
+      !(Component.__N_SSG || Component.__N_SSP) ? {
+        url: createUrl(router)
+      } : {}));
     }
   }]);

Diff for _app.module.js

@@ -57,10 +57,11 @@ class App extends _react.default.Component {
       Component,
       pageProps
     } = this.props;
-    var url = createUrl(router);
-    return _react.default.createElement(Component, Object.assign({}, pageProps, {
-      url: url
-    }));
+    return _react.default.createElement(Component, Object.assign({}, pageProps, // we don't add the legacy URL prop if it's using non-legacy
+    // methods like getStaticProps and getServerProps
+    !(Component.__N_SSG || Component.__N_SSP) ? {
+      url: createUrl(router)
+    } : {}));
   }
 
 }

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
buildDuration	9.9s	10s	⚠️ +156ms
nodeModulesSize	56.2 MB	56.2 MB	⚠️ +3 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.js gzip	4.98 kB	4.98 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..b61f.js gzip	12.3 kB	12.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.1 kB	57.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.module.js gzip	4.1 kB	4.1 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	9.22 kB	9.22 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	53.2 kB	53.2 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.js gzip	1.06 kB	1.07 kB	⚠️ +14 B
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.9 kB	1.9 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.4 kB	⚠️ +14 B

Client Pages Modern Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.module.js gzip	577 B	589 B	⚠️ +12 B
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.27 kB	⚠️ +12 B

Client Build Manifests

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_error.js gzip	289 kB	291 kB	⚠️ +1.09 kB
404.html gzip	1.33 kB	1.33 kB	✓
hooks.html gzip	964 B	964 B	✓
index.js gzip	290 kB	290 kB	⚠️ +356 B
link.js gzip	299 kB	298 kB	-798 B
routerDirect.js gzip	296 kB	298 kB	⚠️ +1.66 kB
withRouter.js gzip	296 kB	297 kB	⚠️ +396 B
Overall change	1.47 MB	1.48 MB	⚠️ +2.7 kB

Commit: fbdb90a

ijjk · 2020-02-26T18:20:45Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
buildDuration	10.5s	10.6s	⚠️ +171ms
nodeModulesSize	56.2 MB	56.2 MB	⚠️ +3 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.js gzip	4.98 kB	4.98 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..b61f.js gzip	12.3 kB	12.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.1 kB	57.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.module.js gzip	4.1 kB	4.1 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	9.22 kB	9.22 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	53.2 kB	53.2 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.js gzip	1.06 kB	1.07 kB	⚠️ +14 B
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.9 kB	1.9 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.4 kB	⚠️ +14 B

Client Pages Modern Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.module.js gzip	577 B	589 B	⚠️ +12 B
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.27 kB	⚠️ +12 B

Client Build Manifests

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
index.html gzip	927 B	927 B	✓
link.html gzip	933 B	933 B	✓
withRouter.html gzip	924 B	924 B	✓
Overall change	2.78 kB	2.78 kB	✓

Diffs

Diff for _app.js

@@ -118,10 +118,11 @@ function (_react$default$Compon) {
           router = _this$props.router,
           Component = _this$props.Component,
           pageProps = _this$props.pageProps;
-      var url = createUrl(router);
-      return _react["default"].createElement(Component, Object.assign({}, pageProps, {
-        url: url
-      }));
+      return _react["default"].createElement(Component, Object.assign({}, pageProps, // we don't add the legacy URL prop if it's using non-legacy
+      // methods like getStaticProps and getServerProps
+      !(Component.__N_SSG || Component.__N_SSP) ? {
+        url: createUrl(router)
+      } : {}));
     }
   }]);

Diff for _app.module.js

@@ -57,10 +57,11 @@ class App extends _react.default.Component {
       Component,
       pageProps
     } = this.props;
-    var url = createUrl(router);
-    return _react.default.createElement(Component, Object.assign({}, pageProps, {
-      url: url
-    }));
+    return _react.default.createElement(Component, Object.assign({}, pageProps, // we don't add the legacy URL prop if it's using non-legacy
+    // methods like getStaticProps and getServerProps
+    !(Component.__N_SSG || Component.__N_SSP) ? {
+      url: createUrl(router)
+    } : {}));
   }
 
 }

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
buildDuration	11.2s	11.3s	⚠️ +44ms
nodeModulesSize	56.2 MB	56.2 MB	⚠️ +3 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.js gzip	4.98 kB	4.98 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..b61f.js gzip	12.3 kB	12.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.1 kB	57.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
main-HASH.module.js gzip	4.1 kB	4.1 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	9.22 kB	9.22 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	53.2 kB	53.2 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.js gzip	1.06 kB	1.07 kB	⚠️ +14 B
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.9 kB	1.9 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.4 kB	⚠️ +14 B

Client Pages Modern Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_app.module.js gzip	577 B	589 B	⚠️ +12 B
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.27 kB	⚠️ +12 B

Client Build Manifests

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/SSG-url-prop	Change
_error.js gzip	292 kB	292 kB	-45 B
404.html gzip	1.33 kB	1.33 kB	✓
hooks.html gzip	964 B	964 B	✓
index.js gzip	291 kB	292 kB	⚠️ +810 B
link.js gzip	299 kB	299 kB	⚠️ +338 B
routerDirect.js gzip	298 kB	298 kB	⚠️ +26 B
withRouter.js gzip	297 kB	298 kB	⚠️ +223 B
Overall change	1.48 MB	1.48 MB	⚠️ +1.35 kB

Commit: bb9f7a2

Make sure to show error when url prop is returned for a page

Unverified

This user has not yet uploaded their public signing key.

GPG key ID: 6CFC4C3DAD69C3E4

Learn about vigilant mode

929f963

ijjk added this to the 9.3.0 milestone Feb 23, 2020

ijjk requested review from lfades, Timer and timneutkens as code owners February 23, 2020 22:58

ijjk added 2 commits February 23, 2020 17:08

Update test and handle undefined pageProps

Unverified

This user has not yet uploaded their public signing key.

GPG key ID: 6CFC4C3DAD69C3E4

Learn about vigilant mode

9236547

Handle empty props

Unverified

This user has not yet uploaded their public signing key.

GPG key ID: 6CFC4C3DAD69C3E4

Learn about vigilant mode

7c0ae39

Timer reviewed Feb 24, 2020

View reviewed changes

timneutkens reviewed Feb 24, 2020

View reviewed changes

packages/next/next-server/server/render.tsx Outdated Show resolved Hide resolved

ijjk and others added 2 commits February 24, 2020 10:17

Apply suggestions from code review

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

714db5d

Co-Authored-By: Tim Neutkens <tim@timneutkens.nl>

Merge remote-tracking branch 'upstream/canary' into error/SSG-url-prop

Unverified

This user has not yet uploaded their public signing key.

GPG key ID: 6CFC4C3DAD69C3E4

Learn about vigilant mode

8704ff0

ijjk requested a review from timneutkens February 24, 2020 16:19

ijjk added 2 commits February 24, 2020 12:55

Merge remote-tracking branch 'upstream/canary' into error/SSG-url-prop

Unverified

This user has not yet uploaded their public signing key.

GPG key ID: 6CFC4C3DAD69C3E4

Learn about vigilant mode

8b7e2eb

Update tests

Unverified

This user has not yet uploaded their public signing key.

GPG key ID: 6CFC4C3DAD69C3E4

Learn about vigilant mode

41da9ec

timneutkens approved these changes Feb 25, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/canary' into error/SSG-url-prop

Unverified

This user has not yet uploaded their public signing key.

GPG key ID: 6CFC4C3DAD69C3E4

Learn about vigilant mode

76b25f3

ijjk added 2 commits February 25, 2020 10:01

Update to not add url prop for SSG/SSP pages

Unverified

This user has not yet uploaded their public signing key.

GPG key ID: 6CFC4C3DAD69C3E4

Learn about vigilant mode

4954648

Update errsh for reserved prop

Unverified

This user has not yet uploaded their public signing key.

GPG key ID: 6CFC4C3DAD69C3E4

Learn about vigilant mode

ed1d96f

Update errsh wording some more

Unverified

This user has not yet uploaded their public signing key.

GPG key ID: 6CFC4C3DAD69C3E4

Learn about vigilant mode

000838e

ijjk requested a review from Timer February 25, 2020 17:25

Timer reviewed Feb 26, 2020

View reviewed changes

test/integration/client-navigation/test/rendering.js Outdated Show resolved Hide resolved

Timer reviewed Feb 26, 2020

View reviewed changes

test/integration/getserverprops/test/index.test.js Outdated Show resolved Hide resolved

Timer reviewed Feb 26, 2020

View reviewed changes

test/integration/prerender/test/index.test.js Outdated Show resolved Hide resolved

timneutkens reviewed Feb 26, 2020

View reviewed changes

packages/next/next-server/server/render.tsx Outdated Show resolved Hide resolved

ijjk added 3 commits February 26, 2020 09:21

Update tests and to warn instead of error

Unverified

This user has not yet uploaded their public signing key.

GPG key ID: 6CFC4C3DAD69C3E4

Learn about vigilant mode

4b6b99e

Merge remote-tracking branch 'upstream/canary' into error/SSG-url-prop

Unverified

This user has not yet uploaded their public signing key.

GPG key ID: 6CFC4C3DAD69C3E4

Learn about vigilant mode

d263218

Update reserved prop warning

Unverified

This user has not yet uploaded their public signing key.

GPG key ID: 6CFC4C3DAD69C3E4

Learn about vigilant mode

2772c48

ijjk changed the title ~~Make sure to show error when url prop is returned for a page~~ Update url prop handling for pages with new data methods Feb 26, 2020

timneutkens reviewed Feb 26, 2020

View reviewed changes

packages/next/next-server/server/render.tsx Show resolved Hide resolved

Include page in url prop warning

Unverified

This user has not yet uploaded their public signing key.

GPG key ID: 6CFC4C3DAD69C3E4

Learn about vigilant mode

fbdb90a

ijjk requested a review from Timer February 26, 2020 15:46

Timer approved these changes Feb 26, 2020

View reviewed changes

Timer added ready to land labels Feb 26, 2020

Merge branch 'canary' into error/SSG-url-prop

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

bb9f7a2

Timer merged commit 395714a into vercel:canary Feb 26, 2020

ijjk deleted the error/SSG-url-prop branch February 26, 2020 18:27

snyk-bot mentioned this pull request Apr 9, 2020

[Snyk] Upgrade next from 9.1.1 to 9.3.1 cds-snc/a11y-reporting#6

Open

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update url prop handling for pages with new data methods #10653

Update url prop handling for pages with new data methods #10653

ijjk commented Feb 23, 2020

ijjk commented Feb 23, 2020

ijjk commented Feb 23, 2020

Timer left a comment

ijjk commented Feb 24, 2020

ijjk commented Feb 24, 2020

ijjk commented Feb 25, 2020

ijjk commented Feb 25, 2020

Diffs

ijjk commented Feb 25, 2020

Diffs

ijjk commented Feb 26, 2020

Diffs

ijjk commented Feb 26, 2020

Diffs

ijjk commented Feb 26, 2020

Diffs

Update url prop handling for pages with new data methods #10653

Update url prop handling for pages with new data methods #10653

Conversation

ijjk commented Feb 23, 2020

ijjk commented Feb 23, 2020

Stats from current PR

ijjk commented Feb 23, 2020

Stats from current PR

Timer left a comment

Choose a reason for hiding this comment

ijjk commented Feb 24, 2020

Stats from current PR

ijjk commented Feb 24, 2020

Stats from current PR

ijjk commented Feb 25, 2020

Stats from current PR

ijjk commented Feb 25, 2020

Stats from current PR

Diffs

ijjk commented Feb 25, 2020

Stats from current PR

Diffs

ijjk commented Feb 26, 2020

Stats from current PR

Diffs

ijjk commented Feb 26, 2020

Stats from current PR

Diffs

ijjk commented Feb 26, 2020

Stats from current PR

Diffs