Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unstable_ prefix from new methods #10723

Merged
merged 8 commits into from Feb 27, 2020
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 27, 2020

As discussed, this stabilizes the new getStaticProps, getStaticPaths, and getServerSideProps methods and exposes their types in next/types. It also adds an error when the legacy methods are detected during a build

@ijjk ijjk added this to the 9.3.0 milestone Feb 27, 2020
@ijjk
Copy link
Member Author

ijjk commented Feb 27, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
buildDuration 9.1s 9s -65ms
nodeModulesSize 56.3 MB 56.3 MB -763 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
main-HASH.js gzip 4.98 kB 4.98 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..49f4.js gzip 12.3 kB 12.3 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.1 kB 57.1 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
main-HASH.module.js gzip 4.1 kB 4.1 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_app.js gzip 1.07 kB 1.07 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.4 kB 7.4 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_app.module.js gzip 589 B 589 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.27 kB 5.27 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
index.html gzip 924 B 924 B
link.html gzip 933 B 933 B
withRouter.html gzip 922 B 922 B
Overall change 2.78 kB 2.78 kB

Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
buildDuration 9.6s 9.7s ⚠️ +139ms
nodeModulesSize 56.3 MB 56.3 MB -763 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
main-HASH.js gzip 4.98 kB 4.98 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..49f4.js gzip 12.3 kB 12.3 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.1 kB 57.1 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
main-HASH.module.js gzip 4.1 kB 4.1 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_app.js gzip 1.07 kB 1.07 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.4 kB 7.4 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_app.module.js gzip 589 B 589 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.27 kB 5.27 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall decrease ✓
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_error.js gzip 292 kB 292 kB ⚠️ +207 B
404.html gzip 1.33 kB 1.33 kB
hooks.html gzip 963 B 963 B
index.js gzip 292 kB 292 kB -738 B
link.js gzip 299 kB 299 kB -277 B
routerDirect.js gzip 298 kB 298 kB ⚠️ +334 B
withRouter.js gzip 299 kB 298 kB -1.2 kB
Overall change 1.48 MB 1.48 MB -1.67 kB

Commit: c3ed0a7

packages/next/lib/constants.ts Outdated Show resolved Hide resolved
packages/next/lib/constants.ts Outdated Show resolved Hide resolved
@ijjk ijjk requested a review from Timer February 27, 2020 17:34
Co-Authored-By: Joe Haddad <joe.haddad@zeit.co>
@ijjk
Copy link
Member Author

ijjk commented Feb 27, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
buildDuration 9.5s 9.4s -63ms
nodeModulesSize 56.3 MB 56.3 MB -352 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
main-HASH.js gzip 4.98 kB 4.98 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..49f4.js gzip 12.3 kB 12.3 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.1 kB 57.1 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
main-HASH.module.js gzip 4.1 kB 4.1 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_app.js gzip 1.07 kB 1.07 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.4 kB 7.4 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_app.module.js gzip 589 B 589 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.27 kB 5.27 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
index.html gzip 924 B 924 B
link.html gzip 933 B 933 B
withRouter.html gzip 922 B 922 B
Overall change 2.78 kB 2.78 kB

Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
buildDuration 10.2s 10s -279ms
nodeModulesSize 56.3 MB 56.3 MB -352 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
main-HASH.js gzip 4.98 kB 4.98 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..49f4.js gzip 12.3 kB 12.3 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.1 kB 57.1 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
main-HASH.module.js gzip 4.1 kB 4.1 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_app.js gzip 1.07 kB 1.07 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.4 kB 7.4 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_app.module.js gzip 589 B 589 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.27 kB 5.27 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall decrease ✓
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_error.js gzip 292 kB 292 kB ⚠️ +54 B
404.html gzip 1.33 kB 1.33 kB
hooks.html gzip 963 B 963 B
index.js gzip 292 kB 292 kB -22 B
link.js gzip 300 kB 299 kB -534 B
routerDirect.js gzip 299 kB 298 kB -1.08 kB
withRouter.js gzip 298 kB 299 kB ⚠️ +1.02 kB
Overall change 1.48 MB 1.48 MB -563 B

Commit: 3eb91b9

@ijjk
Copy link
Member Author

ijjk commented Feb 27, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
buildDuration 9.8s 9.8s ⚠️ +12ms
nodeModulesSize 56.3 MB 56.3 MB -367 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
main-HASH.js gzip 4.98 kB 4.98 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..49f4.js gzip 12.3 kB 12.3 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.1 kB 57.1 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
main-HASH.module.js gzip 4.1 kB 4.1 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_app.js gzip 1.07 kB 1.07 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.4 kB 7.4 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_app.module.js gzip 589 B 589 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.27 kB 5.27 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
index.html gzip 924 B 924 B
link.html gzip 933 B 933 B
withRouter.html gzip 922 B 922 B
Overall change 2.78 kB 2.78 kB

Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
buildDuration 10.6s 10.8s ⚠️ +146ms
nodeModulesSize 56.3 MB 56.3 MB -367 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
main-HASH.js gzip 4.98 kB 4.98 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..49f4.js gzip 12.3 kB 12.3 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.1 kB 57.1 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
main-HASH.module.js gzip 4.1 kB 4.1 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_app.js gzip 1.07 kB 1.07 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.4 kB 7.4 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_app.module.js gzip 589 B 589 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.27 kB 5.27 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall decrease ✓
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_error.js gzip 292 kB 293 kB ⚠️ +266 B
404.html gzip 1.33 kB 1.33 kB
hooks.html gzip 963 B 963 B
index.js gzip 292 kB 292 kB -200 B
link.js gzip 300 kB 300 kB -127 B
routerDirect.js gzip 298 kB 298 kB -193 B
withRouter.js gzip 298 kB 298 kB -202 B
Overall change 1.48 MB 1.48 MB -456 B

Commit: 868a20d

@ijjk
Copy link
Member Author

ijjk commented Feb 27, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
buildDuration 8.2s 8.3s ⚠️ +127ms
nodeModulesSize 56.3 MB 56.3 MB -389 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
main-HASH.js gzip 4.98 kB 4.98 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..49f4.js gzip 12.3 kB 12.3 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.1 kB 57.1 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
main-HASH.module.js gzip 4.1 kB 4.1 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_app.js gzip 1.07 kB 1.07 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.4 kB 7.4 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_app.module.js gzip 589 B 589 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.27 kB 5.27 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
index.html gzip 924 B 924 B
link.html gzip 933 B 933 B
withRouter.html gzip 922 B 922 B
Overall change 2.78 kB 2.78 kB

Serverless Mode (Increase detected ⚠️)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
buildDuration 9s 8.7s -269ms
nodeModulesSize 56.3 MB 56.3 MB -389 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
main-HASH.js gzip 4.98 kB 4.98 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..49f4.js gzip 12.3 kB 12.3 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.1 kB 57.1 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
main-HASH.module.js gzip 4.1 kB 4.1 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_app.js gzip 1.07 kB 1.07 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.4 kB 7.4 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_app.module.js gzip 589 B 589 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.27 kB 5.27 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall increase ⚠️
zeit/next.js canary ijjk/next.js stabilize/new-methods Change
_error.js gzip 292 kB 293 kB ⚠️ +575 B
404.html gzip 1.33 kB 1.33 kB
hooks.html gzip 963 B 963 B
index.js gzip 292 kB 293 kB ⚠️ +1.18 kB
link.js gzip 300 kB 299 kB -833 B
routerDirect.js gzip 298 kB 298 kB ⚠️ +434 B
withRouter.js gzip 298 kB 298 kB ⚠️ +7 B
Overall change 1.48 MB 1.48 MB ⚠️ +1.37 kB

Commit: 75ec579

Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests are passing. :shipit:

@ijjk ijjk merged commit c9d9f11 into vercel:canary Feb 27, 2020
@ijjk ijjk deleted the stabilize/new-methods branch February 27, 2020 17:57
@orneryd
Copy link

orneryd commented Jan 6, 2021

Is it possible to not have SERVER_PROPS_SSG_CONFLICT forcing getStaticProps and getServerSideProps mutually exclusive and maybe behind a build-time flag? it stands to reason that if you have both defined, getServerSideProps should be used for ISR/SSR and getStaticProps would only be used at compile time in conjunction with getStaticPaths.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants