Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract sendPayload and prepareServerlessUrl #10732

Merged
merged 2 commits into from Feb 28, 2020
Merged

Extract sendPayload and prepareServerlessUrl #10732

merged 2 commits into from Feb 28, 2020

Conversation

devknoll
Copy link
Contributor

@devknoll devknoll commented Feb 28, 2020 •
edited by Timer

This is a step towards having renderToHTMLWithComponents behind the page interface.

@ijjk
Copy link
Member

ijjk commented Feb 28, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
buildDuration 7.9s 8.1s ⚠️ +152ms
nodeModulesSize 56.3 MB 56.3 MB ⚠️ +219 B
Client Bundles (main, webpack, commons)
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
main-HASH.js gzip 4.98 kB 4.98 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..7030.js gzip 9.68 kB 9.68 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 54.6 kB 54.6 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
main-HASH.module.js gzip 4.1 kB 4.1 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.63 kB 6.63 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 50.6 kB 50.6 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
index.html gzip 924 B 924 B ✓
link.html gzip 932 B 932 B ✓
withRouter.html gzip 923 B 923 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
buildDuration 9.2s 8.8s -432ms
nodeModulesSize 56.3 MB 56.3 MB ⚠️ +219 B
Client Bundles (main, webpack, commons)
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
main-HASH.js gzip 4.98 kB 4.98 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..7030.js gzip 9.68 kB 9.68 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 54.6 kB 54.6 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
main-HASH.module.js gzip 4.1 kB 4.1 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.63 kB 6.63 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 50.6 kB 50.6 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
_error.js gzip 292 kB 292 kB -18 B
404.html gzip 1.33 kB 1.33 kB ✓
hooks.html gzip 964 B 964 B ✓
index.js gzip 293 kB 292 kB -297 B
link.js gzip 300 kB 299 kB -590 B
routerDirect.js gzip 298 kB 298 kB ⚠️ +179 B
withRouter.js gzip 298 kB 298 kB ⚠️ +123 B
Overall change 1.48 MB 1.48 MB -603 B

Commit: cb3e4a7

@devknoll devknoll marked this pull request as ready for review February 28, 2020 04:21
@ijjk
Copy link
Member

ijjk commented Feb 28, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
buildDuration 8.1s 8.1s -11ms
nodeModulesSize 56.3 MB 56.3 MB ⚠️ +219 B
Client Bundles (main, webpack, commons)
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
main-HASH.js gzip 4.98 kB 4.98 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..7030.js gzip 9.68 kB 9.68 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 54.6 kB 54.6 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
main-HASH.module.js gzip 4.1 kB 4.1 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.63 kB 6.63 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 50.6 kB 50.6 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
index.html gzip 923 B 923 B ✓
link.html gzip 931 B 931 B ✓
withRouter.html gzip 922 B 922 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
buildDuration 8.8s 8.7s -47ms
nodeModulesSize 56.3 MB 56.3 MB ⚠️ +219 B
Client Bundles (main, webpack, commons)
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
main-HASH.js gzip 4.98 kB 4.98 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..7030.js gzip 9.68 kB 9.68 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 54.6 kB 54.6 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
main-HASH.module.js gzip 4.1 kB 4.1 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.63 kB 6.63 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 50.6 kB 50.6 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary devknoll/next.js extract-send-payload-serverless Change
_error.js gzip 293 kB 292 kB -1.17 kB
404.html gzip 1.33 kB 1.33 kB ✓
hooks.html gzip 963 B 963 B ✓
index.js gzip 292 kB 292 kB ⚠️ +252 B
link.js gzip 299 kB 299 kB ⚠️ +87 B
routerDirect.js gzip 298 kB 299 kB ⚠️ +1.19 kB
withRouter.js gzip 298 kB 298 kB -91 B
Overall change 1.48 MB 1.48 MB ⚠️ +269 B

Commit: 3f7fd8d

@Timer Timer added this to the 9.3.0 milestone Feb 28, 2020
@Timer Timer merged commit d4fa6af into vercel:canary Feb 28, 2020
@snyk-bot snyk-bot mentioned this pull request Apr 9, 2020
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@devknoll @ijjk @Timer