Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old eslint-ignores from unstable_ prefix #10740

Merged
merged 1 commit into from Feb 28, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 28, 2020

Now that we've removed this prefix we no longer need these ignores so this removes them as we're following the rule correctly now

@ijjk ijjk added this to the 9.3.0 milestone Feb 28, 2020
@ijjk
Copy link
Member Author

ijjk commented Feb 28, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js rm/old-ssg-comments Change
buildDuration 9.5s 9.4s -76ms
nodeModulesSize 56.3 MB 56.3 MB -162 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js rm/old-ssg-comments Change
main-HASH.js gzip 4.98 kB 4.98 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..7030.js gzip 9.68 kB 9.68 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 54.6 kB 54.6 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js rm/old-ssg-comments Change
main-HASH.module.js gzip 4.1 kB 4.1 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.63 kB 6.63 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 50.6 kB 50.6 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js rm/old-ssg-comments Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary ijjk/next.js rm/old-ssg-comments Change
_app.js gzip 1.07 kB 1.07 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.39 kB 7.39 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js rm/old-ssg-comments Change
_app.module.js gzip 589 B 589 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.27 kB 5.27 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js rm/old-ssg-comments Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary ijjk/next.js rm/old-ssg-comments Change
index.html gzip 923 B 923 B
link.html gzip 931 B 931 B
withRouter.html gzip 922 B 922 B
Overall change 2.78 kB 2.78 kB

Serverless Mode (Increase detected ⚠️)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js rm/old-ssg-comments Change
buildDuration 10s 10.2s ⚠️ +192ms
nodeModulesSize 56.3 MB 56.3 MB -162 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js rm/old-ssg-comments Change
main-HASH.js gzip 4.98 kB 4.98 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..7030.js gzip 9.68 kB 9.68 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 54.6 kB 54.6 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js rm/old-ssg-comments Change
main-HASH.module.js gzip 4.1 kB 4.1 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.63 kB 6.63 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 50.6 kB 50.6 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js rm/old-ssg-comments Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary ijjk/next.js rm/old-ssg-comments Change
_app.js gzip 1.07 kB 1.07 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.39 kB 7.39 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js rm/old-ssg-comments Change
_app.module.js gzip 589 B 589 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.27 kB 5.27 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js rm/old-ssg-comments Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall increase ⚠️
zeit/next.js canary ijjk/next.js rm/old-ssg-comments Change
_error.js gzip 292 kB 292 kB -492 B
404.html gzip 1.33 kB 1.33 kB
hooks.html gzip 963 B 963 B
index.js gzip 292 kB 292 kB -298 B
link.js gzip 299 kB 300 kB ⚠️ +869 B
routerDirect.js gzip 298 kB 299 kB ⚠️ +809 B
withRouter.js gzip 298 kB 299 kB ⚠️ +1.2 kB
Overall change 1.48 MB 1.48 MB ⚠️ +2.09 kB

Commit: 11f599e

@Timer Timer merged commit b262401 into vercel:canary Feb 28, 2020
@ijjk ijjk deleted the rm/old-ssg-comments branch February 28, 2020 17:40
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants