Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Dead Code from Next Server #10772

Merged
merged 4 commits into from Mar 1, 2020
Merged

Remove Dead Code from Next Server #10772

merged 4 commits into from Mar 1, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Mar 1, 2020

This removes dead code from next-server.

We had references to amphtml and hasAmp—these values are not used anywhere else in the code base.

@Timer Timer added this to the 9.3.0 milestone Mar 1, 2020
@ijjk
Copy link
Member

ijjk commented Mar 1, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary Timer/next.js remove/old-amp Change
buildDuration 9s 8.9s -78ms
nodeModulesSize 56.3 MB 56.3 MB -505 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js remove/old-amp Change
main-HASH.js gzip 5.41 kB 5.41 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..7030.js gzip 9.68 kB 9.68 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55 kB 55 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js remove/old-amp Change
main-HASH.module.js gzip 4.44 kB 4.44 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.63 kB 6.63 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51 kB 51 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js remove/old-amp Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary Timer/next.js remove/old-amp Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js remove/old-amp Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js remove/old-amp Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary Timer/next.js remove/old-amp Change
index.html gzip 924 B 924 B ✓
link.html gzip 934 B 934 B ✓
withRouter.html gzip 923 B 923 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall decrease ✓
zeit/next.js canary Timer/next.js remove/old-amp Change
buildDuration 9.9s 9.8s -19ms
nodeModulesSize 56.3 MB 56.3 MB -505 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js remove/old-amp Change
main-HASH.js gzip 5.41 kB 5.41 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..7030.js gzip 9.68 kB 9.68 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55 kB 55 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js remove/old-amp Change
main-HASH.module.js gzip 4.44 kB 4.44 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.63 kB 6.63 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51 kB 51 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js remove/old-amp Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary Timer/next.js remove/old-amp Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js remove/old-amp Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js remove/old-amp Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary Timer/next.js remove/old-amp Change
_error.js gzip 292 kB 292 kB ⚠️ +216 B
404.html gzip 1.33 kB 1.33 kB ✓
hooks.html gzip 963 B 963 B ✓
index.js gzip 292 kB 292 kB ⚠️ +126 B
link.js gzip 299 kB 300 kB ⚠️ +780 B
routerDirect.js gzip 298 kB 298 kB ⚠️ +6 B
withRouter.js gzip 298 kB 298 kB -124 B
Overall change 1.48 MB 1.48 MB ⚠️ +1 kB

Commit: cea136b

@ijjk
Copy link
Member

ijjk commented Mar 1, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary Timer/next.js remove/old-amp Change
buildDuration 8s 7.7s -253ms
nodeModulesSize 56.3 MB 56.3 MB -505 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js remove/old-amp Change
main-HASH.js gzip 5.41 kB 5.41 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..7030.js gzip 9.68 kB 9.68 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55 kB 55 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js remove/old-amp Change
main-HASH.module.js gzip 4.44 kB 4.44 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.63 kB 6.63 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51 kB 51 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js remove/old-amp Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary Timer/next.js remove/old-amp Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js remove/old-amp Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js remove/old-amp Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary Timer/next.js remove/old-amp Change
index.html gzip 924 B 924 B ✓
link.html gzip 934 B 934 B ✓
withRouter.html gzip 923 B 923 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary Timer/next.js remove/old-amp Change
buildDuration 8.6s 8.2s -409ms
nodeModulesSize 56.3 MB 56.3 MB -505 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js remove/old-amp Change
main-HASH.js gzip 5.41 kB 5.41 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..7030.js gzip 9.68 kB 9.68 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55 kB 55 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js remove/old-amp Change
main-HASH.module.js gzip 4.44 kB 4.44 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.63 kB 6.63 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51 kB 51 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js remove/old-amp Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary Timer/next.js remove/old-amp Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js remove/old-amp Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js remove/old-amp Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary Timer/next.js remove/old-amp Change
_error.js gzip 292 kB 292 kB -671 B
404.html gzip 1.33 kB 1.33 kB ✓
hooks.html gzip 963 B 963 B ✓
index.js gzip 292 kB 292 kB -221 B
link.js gzip 299 kB 299 kB ⚠️ +6 B
routerDirect.js gzip 299 kB 298 kB -1.15 kB
withRouter.js gzip 298 kB 298 kB -312 B
Overall change 1.48 MB 1.48 MB -2.35 kB

Commit: 88840d2

ijjk
ijjk approved these changes Mar 1, 2020
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@ijjk
Copy link
Member

ijjk commented Mar 1, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary Timer/next.js remove/old-amp Change
buildDuration 8s 8s -44ms
nodeModulesSize 56.3 MB 56.3 MB -505 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js remove/old-amp Change
main-HASH.js gzip 5.41 kB 5.41 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..7030.js gzip 9.68 kB 9.68 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55 kB 55 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js remove/old-amp Change
main-HASH.module.js gzip 4.44 kB 4.44 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.63 kB 6.63 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51 kB 51 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js remove/old-amp Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary Timer/next.js remove/old-amp Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js remove/old-amp Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js remove/old-amp Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary Timer/next.js remove/old-amp Change
index.html gzip 924 B 924 B ✓
link.html gzip 934 B 934 B ✓
withRouter.html gzip 923 B 923 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall decrease ✓
zeit/next.js canary Timer/next.js remove/old-amp Change
buildDuration 8.7s 8.9s ⚠️ +168ms
nodeModulesSize 56.3 MB 56.3 MB -505 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js remove/old-amp Change
main-HASH.js gzip 5.41 kB 5.41 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..7030.js gzip 9.68 kB 9.68 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55 kB 55 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js remove/old-amp Change
main-HASH.module.js gzip 4.44 kB 4.44 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.63 kB 6.63 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51 kB 51 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js remove/old-amp Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary Timer/next.js remove/old-amp Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js remove/old-amp Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js remove/old-amp Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary Timer/next.js remove/old-amp Change
_error.js gzip 292 kB 292 kB ✓
404.html gzip 1.33 kB 1.33 kB ✓
hooks.html gzip 963 B 963 B ✓
index.js gzip 292 kB 292 kB ⚠️ +160 B
link.js gzip 300 kB 300 kB ⚠️ +17 B
routerDirect.js gzip 298 kB 298 kB ⚠️ +98 B
withRouter.js gzip 298 kB 299 kB ⚠️ +1.33 kB
Overall change 1.48 MB 1.48 MB ⚠️ +1.6 kB

Commit: 7ea3928

@Timer Timer merged commit 8999ef2 into vercel:canary Mar 1, 2020
@Timer Timer deleted the remove/old-amp branch March 1, 2020 17:27
@snyk-bot snyk-bot mentioned this pull request Apr 9, 2020
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Timer @ijjk