Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: react-native-web: fix config to prefer .web.* exts #10774

Merged
merged 2 commits into from Mar 1, 2020

Conversation

MoOx
Copy link
Contributor

@MoOx MoOx commented Mar 1, 2020

Simple issue if you have Compo.js & Compo.web.js (eg 1st for iOS/android & second for web): with current config, .web are resolved after.
My change change this situation so web extensions are resolved before the others.

I removed the defaultLoaders since it was not used. Tell me if that was intentional so I can add it back.

…resolved before other

Simple issue if you have `Compo.js` & `Compo.web.js` (eg 1st for iOS/android & second for web): with current config, .web are resolved after.
My change change this situation so web extensions are resolved before the others.

I removed the `defaultLoaders` since it was not used. Tell me if that was intentional so I can add it back.
@MoOx MoOx requested review from lfades and Timer as code owners March 1, 2020 17:29
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Timer Timer added ready to land area: examples Anything inside the examples folder labels Mar 1, 2020
@Timer Timer added this to the 9.3.0 milestone Mar 1, 2020
@Timer Timer changed the title [examples/with-react-native-web] fix config to get .web.* extensions resolved before others [examples/with-react-native-web] fix config to prefer .web.* exts Mar 1, 2020
@Timer Timer changed the title [examples/with-react-native-web] fix config to prefer .web.* exts examples: react-native-web: fix config to prefer .web.* exts Mar 1, 2020
@Timer Timer merged commit 644a1ef into vercel:canary Mar 1, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: examples Anything inside the examples folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants