Add identifier to NEXT_DATA for gs(s)p #10812

ijjk · 2020-03-03T18:02:23Z

This adds a gsp or gssp field to __NEXT_DATA__ to allow detecting whether a page is using getStaticProps or getServerSideProps. I added tests to the respective test suites to ensure this is set correctly

NEXT-98

ijjk · 2020-03-03T18:07:44Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
buildDuration	8.7s	8.9s	⚠️ +127ms
nodeModulesSize	56.3 MB	56.3 MB	⚠️ +483 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
main-HASH.js gzip	5.76 kB	5.76 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..67cb.js gzip	9.69 kB	9.69 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	55.3 kB	55.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.64 kB	6.64 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.3 kB	51.3 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
_app.js gzip	1.07 kB	1.07 kB	✓
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.89 kB	1.89 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
_app.module.js gzip	589 B	589 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.27 kB	5.27 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
index.html gzip	936 B	936 B	✓
link.html gzip	946 B	946 B	✓
withRouter.html gzip	934 B	934 B	✓
Overall change	2.82 kB	2.82 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
buildDuration	9.5s	9.4s	-44ms
nodeModulesSize	56.3 MB	56.3 MB	⚠️ +483 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
main-HASH.js gzip	5.76 kB	5.76 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..67cb.js gzip	9.69 kB	9.69 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	55.3 kB	55.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.64 kB	6.64 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.3 kB	51.3 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
_app.js gzip	1.07 kB	1.07 kB	✓
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.89 kB	1.89 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
_app.module.js gzip	589 B	589 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.27 kB	5.27 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
_error.js gzip	292 kB	292 kB	⚠️ +468 B
404.html gzip	1.34 kB	1.34 kB	✓
hooks.html gzip	975 B	975 B	✓
index.js gzip	292 kB	292 kB	-31 B
link.js gzip	300 kB	300 kB	⚠️ +9 B
routerDirect.js gzip	298 kB	298 kB	⚠️ +54 B
withRouter.js gzip	299 kB	298 kB	-1.02 kB
Overall change	1.48 MB	1.48 MB	-517 B

test/integration/prerender/test/index.test.js

test/integration/getserversideprops/test/index.test.js

Co-Authored-By: Joe Haddad <joe.haddad@zeit.co>

ijjk · 2020-03-03T18:18:29Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
buildDuration	8.7s	8.7s	-71ms
nodeModulesSize	56.3 MB	56.3 MB	⚠️ +483 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
main-HASH.js gzip	5.76 kB	5.76 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..67cb.js gzip	9.69 kB	9.69 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	55.3 kB	55.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.64 kB	6.64 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.3 kB	51.3 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
_app.js gzip	1.07 kB	1.07 kB	✓
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.89 kB	1.89 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
_app.module.js gzip	589 B	589 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.27 kB	5.27 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
index.html gzip	936 B	936 B	✓
link.html gzip	946 B	946 B	✓
withRouter.html gzip	934 B	934 B	✓
Overall change	2.82 kB	2.82 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
buildDuration	9.5s	9.5s	⚠️ +64ms
nodeModulesSize	56.3 MB	56.3 MB	⚠️ +483 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
main-HASH.js gzip	5.76 kB	5.76 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..67cb.js gzip	9.69 kB	9.69 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	55.3 kB	55.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.64 kB	6.64 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.3 kB	51.3 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
_app.js gzip	1.07 kB	1.07 kB	✓
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.89 kB	1.89 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
_app.module.js gzip	589 B	589 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.27 kB	5.27 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
_error.js gzip	292 kB	292 kB	⚠️ +193 B
404.html gzip	1.34 kB	1.34 kB	✓
hooks.html gzip	975 B	975 B	✓
index.js gzip	292 kB	293 kB	⚠️ +1.18 kB
link.js gzip	299 kB	299 kB	⚠️ +15 B
routerDirect.js gzip	298 kB	298 kB	-262 B
withRouter.js gzip	298 kB	298 kB	-22 B
Overall change	1.48 MB	1.48 MB	⚠️ +1.1 kB

…d/gssp-identifier

ijjk · 2020-03-03T18:33:24Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
buildDuration	10.2s	10.5s	⚠️ +375ms
nodeModulesSize	56.3 MB	56.3 MB	⚠️ +483 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
main-HASH.js gzip	5.76 kB	5.76 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..67cb.js gzip	9.69 kB	9.69 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	55.3 kB	55.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.64 kB	6.64 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.3 kB	51.3 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
_app.js gzip	1.07 kB	1.07 kB	✓
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.89 kB	1.89 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
_app.module.js gzip	589 B	589 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.27 kB	5.27 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
index.html gzip	936 B	936 B	✓
link.html gzip	946 B	946 B	✓
withRouter.html gzip	934 B	934 B	✓
Overall change	2.82 kB	2.82 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
buildDuration	10.8s	10.8s	-92ms
nodeModulesSize	56.3 MB	56.3 MB	⚠️ +483 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
main-HASH.js gzip	5.76 kB	5.76 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..67cb.js gzip	9.69 kB	9.69 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	55.3 kB	55.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.64 kB	6.64 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.3 kB	51.3 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
_app.js gzip	1.07 kB	1.07 kB	✓
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.89 kB	1.89 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
_app.module.js gzip	589 B	589 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.27 kB	5.27 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	ijjk/next.js add/gssp-identifier	Change
_error.js gzip	292 kB	292 kB	-539 B
404.html gzip	1.34 kB	1.34 kB	✓
hooks.html gzip	975 B	975 B	✓
index.js gzip	292 kB	292 kB	-82 B
link.js gzip	299 kB	299 kB	⚠️ +79 B
routerDirect.js gzip	298 kB	299 kB	⚠️ +960 B
withRouter.js gzip	299 kB	298 kB	-1.02 kB
Overall change	1.48 MB	1.48 MB	-600 B

Add identifier to NEXT_DATA for gs(s)p

e10c522

ijjk added this to the 9.3.0 milestone Mar 3, 2020

ijjk requested review from lfades, Timer and timneutkens as code owners March 3, 2020 18:02

Timer requested changes Mar 3, 2020

View reviewed changes

test/integration/prerender/test/index.test.js Outdated Show resolved Hide resolved

test/integration/getserversideprops/test/index.test.js Outdated Show resolved Hide resolved

Apply suggestions from code review

88f85ff

Co-Authored-By: Joe Haddad <joe.haddad@zeit.co>

ijjk requested a review from Timer March 3, 2020 18:13

Timer approved these changes Mar 3, 2020

View reviewed changes

Timer added the ready to land label Mar 3, 2020

Timer and others added 4 commits March 3, 2020 13:25

Merge branch 'canary' into add/gssp-identifier

84eb8f4

fix lint

34af576

apply lint fix

fdef821

Merge branch 'add/gssp-identifier' of github.com:ijjk/next.js into ad…

0086387

…d/gssp-identifier

Timer merged commit 4ef1cd4 into vercel:canary Mar 3, 2020

snyk-bot mentioned this pull request Apr 9, 2020

[Snyk] Upgrade next from 9.1.1 to 9.3.1 cds-snc/a11y-reporting#6

Open

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add identifier to NEXT_DATA for gs(s)p #10812

Add identifier to NEXT_DATA for gs(s)p #10812

ijjk commented Mar 3, 2020 •

edited by jira bot

ijjk commented Mar 3, 2020

ijjk commented Mar 3, 2020

ijjk commented Mar 3, 2020

Add identifier to NEXT_DATA for gs(s)p #10812

Add identifier to NEXT_DATA for gs(s)p #10812

Conversation

ijjk commented Mar 3, 2020 • edited by jira bot

ijjk commented Mar 3, 2020

Stats from current PR

ijjk commented Mar 3, 2020

Stats from current PR

ijjk commented Mar 3, 2020

Stats from current PR

ijjk commented Mar 3, 2020 •

edited by jira bot