Update to make sure preview mode works with getServerSideProps #10813

ijjk · 2020-03-03T18:30:16Z

This makes sure preview mode works correctly with getServerSideProps also and that previewData and preview are exposed in it's context. I also migrated the existing preview mode tests over for getServerSideProps

ijjk · 2020-03-03T18:35:55Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
buildDuration	9.8s	9.8s	-16ms
nodeModulesSize	56.3 MB	56.3 MB	⚠️ +791 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
main-HASH.js gzip	5.76 kB	5.76 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..67cb.js gzip	9.69 kB	9.69 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	55.3 kB	55.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.64 kB	6.64 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.3 kB	51.3 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
_app.js gzip	1.07 kB	1.07 kB	✓
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.89 kB	1.89 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
_app.module.js gzip	589 B	589 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.27 kB	5.27 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
index.html gzip	936 B	936 B	✓
link.html gzip	946 B	946 B	✓
withRouter.html gzip	934 B	934 B	✓
Overall change	2.82 kB	2.82 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
buildDuration	10.3s	9.8s	-477ms
nodeModulesSize	56.3 MB	56.3 MB	⚠️ +791 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
main-HASH.js gzip	5.76 kB	5.76 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..67cb.js gzip	9.69 kB	9.69 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	55.3 kB	55.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.64 kB	6.64 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.3 kB	51.3 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
_app.js gzip	1.07 kB	1.07 kB	✓
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.89 kB	1.89 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
_app.module.js gzip	589 B	589 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.27 kB	5.27 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
_error.js gzip	292 kB	292 kB	⚠️ +156 B
404.html gzip	1.34 kB	1.34 kB	✓
hooks.html gzip	975 B	975 B	✓
index.js gzip	292 kB	292 kB	-266 B
link.js gzip	299 kB	299 kB	⚠️ +184 B
routerDirect.js gzip	299 kB	298 kB	-1.03 kB
withRouter.js gzip	298 kB	298 kB	⚠️ +1 B
Overall change	1.48 MB	1.48 MB	-959 B

ijjk · 2020-03-03T18:37:28Z

Failing test suites

test/integration/custom-server/test/index.test.js
test/integration/client-navigation/test/index.test.js

packages/next/next-server/server/next-server.ts

packages/next/next-server/server/render.tsx

ijjk · 2020-03-03T18:59:38Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
buildDuration	9.4s	9.6s	⚠️ +129ms
nodeModulesSize	56.3 MB	56.3 MB	⚠️ +1.29 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
main-HASH.js gzip	5.76 kB	5.76 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..67cb.js gzip	9.69 kB	9.69 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	55.3 kB	55.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.64 kB	6.64 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.3 kB	51.3 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
_app.js gzip	1.07 kB	1.07 kB	✓
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.89 kB	1.89 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
_app.module.js gzip	589 B	589 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.27 kB	5.27 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
index.html gzip	936 B	936 B	✓
link.html gzip	946 B	946 B	✓
withRouter.html gzip	934 B	934 B	✓
Overall change	2.82 kB	2.82 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
buildDuration	10.4s	10.2s	-245ms
nodeModulesSize	56.3 MB	56.3 MB	⚠️ +1.29 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
main-HASH.js gzip	5.76 kB	5.76 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..67cb.js gzip	9.69 kB	9.69 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	55.3 kB	55.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.64 kB	6.64 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.3 kB	51.3 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
_app.js gzip	1.07 kB	1.07 kB	✓
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.89 kB	1.89 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
_app.module.js gzip	589 B	589 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.27 kB	5.27 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	ijjk/next.js gssp/preview-mode	Change
_error.js gzip	292 kB	292 kB	-196 B
404.html gzip	1.34 kB	1.34 kB	✓
hooks.html gzip	975 B	975 B	✓
index.js gzip	293 kB	292 kB	-186 B
link.js gzip	299 kB	299 kB	-21 B
routerDirect.js gzip	299 kB	299 kB	⚠️ +83 B
withRouter.js gzip	299 kB	298 kB	-1.24 kB
Overall change	1.48 MB	1.48 MB	-1.56 kB

ijjk added 2 commits March 3, 2020 12:25

Update to make sure preview mode works with getServerSideProps

7a0520c

Merge remote-tracking branch 'upstream/canary' into gssp/preview-mode

6f07c8a

ijjk added this to the 9.3.0 milestone Mar 3, 2020

ijjk requested review from lfades, Timer and timneutkens as code owners March 3, 2020 18:30

Timer requested changes Mar 3, 2020

View reviewed changes

packages/next/next-server/server/next-server.ts Outdated Show resolved Hide resolved

packages/next/next-server/server/render.tsx Outdated Show resolved Hide resolved

ijjk added 2 commits March 3, 2020 12:44

Merge remote-tracking branch 'upstream/canary' into gssp/preview-mode

ad3c7c5

Update to only parse previewData in GS(S)P mode

d5494b6

ijjk requested a review from Timer March 3, 2020 18:54

timneutkens approved these changes Mar 4, 2020

View reviewed changes

timneutkens merged commit 70cb5bd into vercel:canary Mar 4, 2020

timneutkens deleted the gssp/preview-mode branch March 4, 2020 12:58

snyk-bot mentioned this pull request Apr 9, 2020

[Snyk] Upgrade next from 9.1.1 to 9.3.1 cds-snc/a11y-reporting#6

Open

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to make sure preview mode works with getServerSideProps #10813

Update to make sure preview mode works with getServerSideProps #10813

ijjk commented Mar 3, 2020

ijjk commented Mar 3, 2020

ijjk commented Mar 3, 2020 •

edited

ijjk commented Mar 3, 2020

Update to make sure preview mode works with getServerSideProps #10813

Update to make sure preview mode works with getServerSideProps #10813

Conversation

ijjk commented Mar 3, 2020

ijjk commented Mar 3, 2020

Stats from current PR

ijjk commented Mar 3, 2020 • edited

Failing test suites

ijjk commented Mar 3, 2020

Stats from current PR

ijjk commented Mar 3, 2020 •

edited