fix(cli): inspect flag is deprecated #10819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The flag was already deprecated but no documented as it. When you try to use it in latest Next.js you get: > yarn run next --help
yarn run v1.22.0
$ node packages/next/dist/bin/next --help
Usage
$ next <command>
Available commands
build, start, export, dev, telemetry
Options
--version, -v Version number
--inspect Enable the Node.js inspector
--help, -h Displays this message
> yarn run next --inspect
yarn run v1.22.0
$ node packages/next/dist/bin/next --inspect
/Users/vvo/Dev/next.js/packages/next/dist/bin/next:26
`);process.exit(0);}const command=foundCommand?args._[0]:defaultCommand;const forwardedArgs=foundCommand?args._.slice(1):args._;if(args['--inspect'])throw new Error(`Use env variable NODE_OPTIONS instead: NODE_OPTIONS="--inspect" next ${command}`);// Make sure the `next <subcommand> --help` case is covered
^
Error: Use env variable NODE_OPTIONS instead: NODE_OPTIONS="--inspect" next devNow you'll get: > yarn run next --help
yarn run v1.22.0
$ node packages/next/dist/bin/next --help
Usage
$ next <command>
Available commands
build, start, export, dev, telemetry
Options
--version, -v Version number
--help, -h Displays this message
> yarn run next --inspect
yarn run v1.22.0
$ node packages/next/dist/bin/next --inspect
/Users/vvo/Dev/next.js/packages/next/dist/bin/next:25
`);process.exit(0);}const command=foundCommand?args._[0]:defaultCommand;const forwardedArgs=foundCommand?args._.slice(1):args._;if(args['--inspect'])throw new Error(`--inspect flag is deprecated. Use env variable NODE_OPTIONS instead: NODE_OPTIONS='--inspect' next ${command}`);// Make sure the `next <subcommand> --help` case is covered
^
Error: --inspect flag is deprecated. Use env variable NODE_OPTIONS instead: NODE_OPTIONS='--inspect' next dev |
This commit effectively removes the --inspect flag from the CLI help and better inform on the deprecation.
vvo
force-pushed
the
fix/inspect-flag-is-no-more
branch
from
ad2d1f5
to
86dc124
Compare
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Increase detected
|
| zeit/next.js canary | vvo/next.js fix/inspect-flag-is-no-more | Change | |
|---|---|---|---|
| buildDuration | 9s | 9.6s | |
| nodeModulesSize | 56.3 MB | 56.3 MB | -27 B |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | vvo/next.js fix/inspect-flag-is-no-more | Change | |
|---|---|---|---|
| main-HASH.js gzip | 5.76 kB | 5.76 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..67cb.js gzip | 9.69 kB | 9.69 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 55.3 kB | 55.3 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | vvo/next.js fix/inspect-flag-is-no-more | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.79 kB | 4.79 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 6.64 kB | 6.64 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 51.3 kB | 51.3 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | vvo/next.js fix/inspect-flag-is-no-more | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 18.9 kB | 18.9 kB | ✓ |
| Overall change | 18.9 kB | 18.9 kB | ✓ |
Client Pages
| zeit/next.js canary | vvo/next.js fix/inspect-flag-is-no-more | Change | |
|---|---|---|---|
| _app.js gzip | 1.07 kB | 1.07 kB | ✓ |
| _error.js gzip | 2.98 kB | 2.98 kB | ✓ |
| hooks.js gzip | 664 B | 664 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 1.89 kB | 1.89 kB | ✓ |
| routerDirect.js gzip | 279 B | 279 B | ✓ |
| withRouter.js gzip | 278 B | 278 B | ✓ |
| Overall change | 7.38 kB | 7.38 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | vvo/next.js fix/inspect-flag-is-no-more | Change | |
|---|---|---|---|
| _app.module.js gzip | 589 B | 589 B | ✓ |
| _error.module.js gzip | 2.08 kB | 2.08 kB | ✓ |
| hooks.module.js gzip | 370 B | 370 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 1.48 kB | 1.48 kB | ✓ |
| routerDirect..dule.js gzip | 271 B | 271 B | ✓ |
| withRouter.m..dule.js gzip | 270 B | 270 B | ✓ |
| Overall change | 5.27 kB | 5.27 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | vvo/next.js fix/inspect-flag-is-no-more | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
| zeit/next.js canary | vvo/next.js fix/inspect-flag-is-no-more | Change | |
|---|---|---|---|
| _error.js gzip | 292 kB | 293 kB | |
| 404.html gzip | 1.34 kB | 1.34 kB | ✓ |
| hooks.html gzip | 975 B | 975 B | ✓ |
| index.js gzip | 293 kB | 292 kB | -994 B |
| link.js gzip | 299 kB | 300 kB | |
| routerDirect.js gzip | 298 kB | 298 kB | -24 B |
| withRouter.js gzip | 298 kB | 299 kB | |
| Overall change | 1.48 MB | 1.48 MB |
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles Overall decrease ✓
|
timneutkens
approved these changes
Mar 4, 2020
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit effectively removes the --inspect flag from the CLI help and better inform on the deprecation.