Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to error when setting too large of preview data #10831

Merged
merged 2 commits into from Mar 4, 2020
Merged

Make sure to error when setting too large of preview data #10831

merged 2 commits into from Mar 4, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Mar 4, 2020

Since browsers drop cookies over 4KB this makes sure we throw an error when users attempt to set too large of preview data

@ijjk ijjk added this to the 9.3.0 milestone Mar 4, 2020
@ijjk
Copy link
Member Author

ijjk commented Mar 4, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
buildDuration 8.9s 9s ⚠️ +145ms
nodeModulesSize 56.3 MB 56.3 MB ⚠️ +524 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
main-HASH.js gzip 5.76 kB 5.76 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..b869.js gzip 9.71 kB 9.71 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.66 kB 6.66 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.3 kB 51.3 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
index.html gzip 936 B 936 B ✓
link.html gzip 945 B 945 B ✓
withRouter.html gzip 933 B 933 B ✓
Overall change 2.81 kB 2.81 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
buildDuration 9.7s 9.7s ⚠️ +20ms
nodeModulesSize 56.3 MB 56.3 MB ⚠️ +524 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
main-HASH.js gzip 5.76 kB 5.76 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..b869.js gzip 9.71 kB 9.71 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.66 kB 6.66 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.3 kB 51.3 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
_error.js gzip 292 kB 293 kB ⚠️ +1.19 kB
404.html gzip 1.34 kB 1.34 kB ✓
hooks.html gzip 974 B 974 B ✓
index.js gzip 292 kB 293 kB ⚠️ +1.17 kB
link.js gzip 300 kB 300 kB -221 B
routerDirect.js gzip 299 kB 298 kB -1.17 kB
withRouter.js gzip 299 kB 299 kB ⚠️ +47 B
Overall change 1.48 MB 1.48 MB ⚠️ +1.02 kB

Timer
Timer requested changes Mar 4, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be enforced after the token is encrypted / signed, not before.

@ijjk
Copy link
Member Author

ijjk commented Mar 4, 2020

Updated to check size after signing

@ijjk ijjk requested review from Timer and timneutkens March 4, 2020 18:42
@ijjk
Copy link
Member Author

ijjk commented Mar 4, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
buildDuration 9.5s 9.6s ⚠️ +166ms
nodeModulesSize 56.3 MB 56.3 MB ⚠️ +600 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
main-HASH.js gzip 5.76 kB 5.76 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..b869.js gzip 9.71 kB 9.71 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.66 kB 6.66 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.3 kB 51.3 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
index.html gzip 936 B 936 B ✓
link.html gzip 945 B 945 B ✓
withRouter.html gzip 933 B 933 B ✓
Overall change 2.81 kB 2.81 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
buildDuration 10.1s 10.1s -49ms
nodeModulesSize 56.3 MB 56.3 MB ⚠️ +600 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
main-HASH.js gzip 5.76 kB 5.76 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..b869.js gzip 9.71 kB 9.71 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.66 kB 6.66 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.3 kB 51.3 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary ijjk/next.js add/NEXT-104 Change
_error.js gzip 292 kB 292 kB -150 B
404.html gzip 1.34 kB 1.34 kB ✓
hooks.html gzip 974 B 974 B ✓
index.js gzip 292 kB 292 kB -517 B
link.js gzip 300 kB 299 kB -780 B
routerDirect.js gzip 299 kB 298 kB -1.16 kB
withRouter.js gzip 298 kB 298 kB ⚠️ +61 B
Overall change 1.48 MB 1.48 MB -2.55 kB

timneutkens
timneutkens approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@timneutkens timneutkens merged commit 0f0398c into vercel:canary Mar 4, 2020
@timneutkens timneutkens deleted the add/NEXT-104 branch March 4, 2020 20:37
@snyk-bot snyk-bot mentioned this pull request Apr 9, 2020
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ijjk @Timer @timneutkens