Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add Sass Docs #10850

Merged
merged 1 commit into from Mar 5, 2020
Merged

Re-add Sass Docs #10850

merged 1 commit into from Mar 5, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Mar 5, 2020

Reverts #10577

@Timer Timer added this to the 9.3.0 milestone Mar 5, 2020
@ijjk
Copy link
Member

ijjk commented Mar 5, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary zeit/next.js revert-10577-revert-10364-docs/sass Change
buildDuration 9.4s 9.8s ⚠️ +377ms
nodeModulesSize 56.5 MB 56.5 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary zeit/next.js revert-10577-revert-10364-docs/sass Change
main-HASH.js gzip 5.77 kB 5.77 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..23c3.js gzip 9.72 kB 9.72 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 55.4 kB 55.4 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary zeit/next.js revert-10577-revert-10364-docs/sass Change
main-HASH.module.js gzip 4.79 kB 4.79 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.66 kB 6.66 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.3 kB 51.3 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary zeit/next.js revert-10577-revert-10364-docs/sass Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary zeit/next.js revert-10577-revert-10364-docs/sass Change
_app.js gzip 1.08 kB 1.08 kB
_error.js gzip 2.96 kB 2.96 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.89 kB 1.89 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.37 kB 7.37 kB
Client Pages Modern
zeit/next.js canary zeit/next.js revert-10577-revert-10364-docs/sass Change
_app.module.js gzip 589 B 589 B
_error.module.js gzip 2.06 kB 2.06 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary zeit/next.js revert-10577-revert-10364-docs/sass Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary zeit/next.js revert-10577-revert-10364-docs/sass Change
index.html gzip 917 B 917 B
link.html gzip 926 B 926 B
withRouter.html gzip 915 B 915 B
Overall change 2.76 kB 2.76 kB

Serverless Mode (Increase detected ⚠️)
General
zeit/next.js canary zeit/next.js revert-10577-revert-10364-docs/sass Change
buildDuration 10.7s 10.6s -53ms
nodeModulesSize 56.5 MB 56.5 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary zeit/next.js revert-10577-revert-10364-docs/sass Change
main-HASH.js gzip 5.77 kB 5.77 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..23c3.js gzip 9.72 kB 9.72 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 55.4 kB 55.4 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary zeit/next.js revert-10577-revert-10364-docs/sass Change
main-HASH.module.js gzip 4.79 kB 4.79 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.66 kB 6.66 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.3 kB 51.3 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary zeit/next.js revert-10577-revert-10364-docs/sass Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary zeit/next.js revert-10577-revert-10364-docs/sass Change
_app.js gzip 1.08 kB 1.08 kB
_error.js gzip 2.96 kB 2.96 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.89 kB 1.89 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.37 kB 7.37 kB
Client Pages Modern
zeit/next.js canary zeit/next.js revert-10577-revert-10364-docs/sass Change
_app.module.js gzip 589 B 589 B
_error.module.js gzip 2.06 kB 2.06 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary zeit/next.js revert-10577-revert-10364-docs/sass Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall increase ⚠️
zeit/next.js canary zeit/next.js revert-10577-revert-10364-docs/sass Change
_error.js gzip 292 kB 292 kB ⚠️ +3 B
404.html gzip 1.32 kB 1.32 kB
hooks.html gzip 958 B 958 B
index.js gzip 292 kB 292 kB ⚠️ +73 B
link.js gzip 300 kB 299 kB -591 B
routerDirect.js gzip 298 kB 299 kB ⚠️ +815 B
withRouter.js gzip 298 kB 298 kB ⚠️ +336 B
Overall change 1.48 MB 1.48 MB ⚠️ +636 B

@Timer Timer merged commit 4808464 into canary Mar 5, 2020
@Timer Timer deleted the revert-10577-revert-10364-docs/sass branch March 5, 2020 15:56
chibicode pushed a commit to chibicode/next.js that referenced this pull request Mar 5, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants