Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix paths.params.type in getStaticPaths(document) #10959

Merged
merged 1 commit into from Mar 11, 2020
Merged

fix paths.params.type in getStaticPaths(document) #10959

merged 1 commit into from Mar 11, 2020

Conversation

watanabeyu
Copy link
Contributor

@watanabeyu watanabeyu commented Mar 11, 2020 •
edited 

return {
  paths: [
    { params: { id: 1 } }, -> { params: { id: '1' } }
    { params: { id: 2 } } -> { params: { id: '2' } }
  ],
  fallback: ...
}

Fixed as it seems to be a number type though it is a string type

@watanabeyu watanabeyu requested a review from Timer as a code owner March 11, 2020 08:47
@timneutkens timneutkens merged commit 1edc1a9 into vercel:canary Mar 11, 2020
ScriptedAlchemy pushed a commit to module-federation/next.js that referenced this pull request Mar 17, 2020
@watanabeyu @ScriptedAlchemy
fix paths.params.type in getStaticPaths(document) (vercel#10959)
f4d3590
@snyk-bot snyk-bot mentioned this pull request Apr 9, 2020
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@watanabeyu @timneutkens