Skip to content

Fix examples with relay-compiler #10976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 11, 2020
Merged

Fix examples with relay-compiler #10976

merged 7 commits into from
Mar 11, 2020
+31 −30

Conversation

messa
Copy link
Contributor

@messa messa commented Mar 11, 2020

Fixes error

Error: Build optimization failed: found page without a React Component as default export in
    pages/__generated__/pages_indexQuery.graphql

by configuring relay-compiler and babel-plugin-relay artifactDirectory to a directory outside of directory pages in examples:

  • with-relay-modern-server-express
  • with-react-relay-network-modern

Fixes #10646

Related to #9596, but a different approach.

The example examples/with-relay-modern need no fix because the issue was dodged in 71e29cd (#10150) by moving the graphql query out of pages dir.

@messa messa requested review from lfades and Timer as code owners March 11, 2020 15:36
@ijjk
Copy link
Member

ijjk commented Mar 11, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
buildDuration 10s 10.1s ⚠️ +79ms
nodeModulesSize 56.5 MB 56.5 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..cfaa.js gzip 9.77 kB 9.77 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.96 kB 2.96 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.06 kB 2.06 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
index.html gzip 917 B 917 B ✓
link.html gzip 925 B 925 B ✓
withRouter.html gzip 912 B 912 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
buildDuration 10.8s 11s ⚠️ +217ms
nodeModulesSize 56.5 MB 56.5 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..cfaa.js gzip 9.77 kB 9.77 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.96 kB 2.96 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.06 kB 2.06 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
_error.js gzip 293 kB 293 kB ⚠️ +326 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 957 B 957 B ✓
index.js gzip 294 kB 293 kB -803 B
link.js gzip 301 kB 301 kB ⚠️ +24 B
routerDirect.js gzip 300 kB 300 kB -45 B
withRouter.js gzip 300 kB 299 kB -54 B
Overall change 1.49 MB 1.49 MB -552 B

@ijjk
Copy link
Member

ijjk commented Mar 11, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
buildDuration 10.1s 10.1s ⚠️ +19ms
nodeModulesSize 56.5 MB 56.5 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..cfaa.js gzip 9.77 kB 9.77 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.96 kB 2.96 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.06 kB 2.06 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
index.html gzip 917 B 917 B ✓
link.html gzip 925 B 925 B ✓
withRouter.html gzip 912 B 912 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
buildDuration 11s 10.8s -146ms
nodeModulesSize 56.5 MB 56.5 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..cfaa.js gzip 9.77 kB 9.77 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.96 kB 2.96 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.06 kB 2.06 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
_error.js gzip 293 kB 293 kB ⚠️ +380 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 957 B 957 B ✓
index.js gzip 294 kB 294 kB ⚠️ +25 B
link.js gzip 301 kB 301 kB -182 B
routerDirect.js gzip 300 kB 300 kB -230 B
withRouter.js gzip 300 kB 300 kB -13 B
Overall change 1.49 MB 1.49 MB -20 B

messa added 7 commits March 11, 2020 17:56
@messa
Example with-react-relay-network-modern: update dependencies
d645480
@messa
Example with-react-relay-network-modern: move relay __generated__ out…
fc6ace5 
… of pages dir
@messa
Example with-react-relay-network-modern: fix some errors
68d95c5 
- Without checking if props.allBlogPosts exists it fails sometimes on
  "TypeError: Cannot read property 'edges' of undefined"

- I have no idea how it could work before with Component.query().params.name,
  but maybe some dependent library API has changed
@messa
Example with-relay-modern-server-express: update dependencies
0addd00
@messa
Example with-relay-modern-server-express: move relay __generated__ ou…
3e8d960 
…t of pages dir

Fixes Error: Build optimization failed: found page without a React Component as default export in
pages/__generated__/pages_indexQuery.graphql
@messa
Example with-relay-modern: update dependencies
4e6d151
@messa
Example with-react-relay-network-modern: fix prettier errors
5f6d118
@messa messa force-pushed the 202003_fix_relay_compiler_examples branch from 20e3459 to 5f6d118 Compare March 11, 2020 16:56
@ijjk
Copy link
Member

ijjk commented Mar 11, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
buildDuration 7.5s 7.3s -166ms
nodeModulesSize 56.5 MB 56.5 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..cfaa.js gzip 9.77 kB 9.77 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.96 kB 2.96 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.06 kB 2.06 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
index.html gzip 917 B 917 B ✓
link.html gzip 925 B 925 B ✓
withRouter.html gzip 912 B 912 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
buildDuration 8.1s 7.9s -176ms
nodeModulesSize 56.5 MB 56.5 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..cfaa.js gzip 9.77 kB 9.77 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.96 kB 2.96 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.06 kB 2.06 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary messa/next.js 202003_fix_relay_compiler_examples Change
_error.js gzip 293 kB 293 kB -192 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 957 B 957 B ✓
index.js gzip 293 kB 293 kB -255 B
link.js gzip 301 kB 300 kB -594 B
routerDirect.js gzip 300 kB 300 kB ⚠️ +101 B
withRouter.js gzip 299 kB 300 kB ⚠️ +223 B
Overall change 1.49 MB 1.49 MB -717 B

@timneutkens timneutkens merged commit 76a08c9 into vercel:canary Mar 11, 2020
ScriptedAlchemy pushed a commit to module-federation/next.js that referenced this pull request Mar 17, 2020
@messa @ScriptedAlchemy
Fix examples with relay-compiler (vercel#10976)
4823ab0 
* Example with-react-relay-network-modern: update dependencies

* Example with-react-relay-network-modern: move relay __generated__ out of pages dir

* Example with-react-relay-network-modern: fix some errors

- Without checking if props.allBlogPosts exists it fails sometimes on
  "TypeError: Cannot read property 'edges' of undefined"

- I have no idea how it could work before with Component.query().params.name,
  but maybe some dependent library API has changed

* Example with-relay-modern-server-express: update dependencies

* Example with-relay-modern-server-express: move relay __generated__ out of pages dir

Fixes Error: Build optimization failed: found page without a React Component as default export in
pages/__generated__/pages_indexQuery.graphql

* Example with-relay-modern: update dependencies

* Example with-react-relay-network-modern: fix prettier errors
@snyk-bot snyk-bot mentioned this pull request Apr 9, 2020
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens

@lfades lfades

@Timer Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GraphQL relay-compiler vs. next build: pages/__generated__/... is not a React component
3 participants
@messa @ijjk @timneutkens