Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data-fetch example to SSG #11017

Merged
merged 4 commits into from Mar 12, 2020
Merged

Update data-fetch example to SSG #11017

merged 4 commits into from Mar 12, 2020

Conversation

asotoglez
Copy link
Contributor

@asotoglez asotoglez commented Mar 12, 2020

Related to #11014

@lfades
Copy link
Member

lfades commented Mar 12, 2020

@asotoglez Thank you for this PR! can you update the readme to mention getStaticProps instead of getInitialProps 🙏

@ijjk
Copy link
Member

ijjk commented Mar 12, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary asotoglez/next.js issue-11014 Change
buildDuration 11.1s 11.2s ⚠️ +72ms
nodeModulesSize 56.6 MB 56.6 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary asotoglez/next.js issue-11014 Change
main-HASH.js gzip 5.77 kB 5.77 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..cfaa.js gzip 9.77 kB 9.77 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 55.4 kB 55.4 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary asotoglez/next.js issue-11014 Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary asotoglez/next.js issue-11014 Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB
Overall change 26.2 kB 26.2 kB
Client Pages
zeit/next.js canary asotoglez/next.js issue-11014 Change
_app.js gzip 1.09 kB 1.09 kB
_error.js gzip 2.96 kB 2.96 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.89 kB 1.89 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary asotoglez/next.js issue-11014 Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.06 kB 2.06 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary asotoglez/next.js issue-11014 Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary asotoglez/next.js issue-11014 Change
index.html gzip 914 B 914 B
link.html gzip 922 B 922 B
withRouter.html gzip 910 B 910 B
Overall change 2.75 kB 2.75 kB

Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary asotoglez/next.js issue-11014 Change
buildDuration 12.1s 12.2s ⚠️ +79ms
nodeModulesSize 56.6 MB 56.6 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary asotoglez/next.js issue-11014 Change
main-HASH.js gzip 5.77 kB 5.77 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..cfaa.js gzip 9.77 kB 9.77 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 55.4 kB 55.4 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary asotoglez/next.js issue-11014 Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary asotoglez/next.js issue-11014 Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB
Overall change 26.2 kB 26.2 kB
Client Pages
zeit/next.js canary asotoglez/next.js issue-11014 Change
_app.js gzip 1.09 kB 1.09 kB
_error.js gzip 2.96 kB 2.96 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.89 kB 1.89 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary asotoglez/next.js issue-11014 Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.06 kB 2.06 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary asotoglez/next.js issue-11014 Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall decrease ✓
zeit/next.js canary asotoglez/next.js issue-11014 Change
_error.js gzip 293 kB 293 kB ⚠️ +225 B
404.html gzip 1.32 kB 1.32 kB
hooks.html gzip 954 B 954 B
index.js gzip 293 kB 293 kB -218 B
link.js gzip 301 kB 301 kB -556 B
routerDirect.js gzip 300 kB 300 kB ⚠️ +49 B
withRouter.js gzip 299 kB 300 kB ⚠️ +69 B
Overall change 1.49 MB 1.49 MB -431 B

Copy link
Contributor

@kachkaev kachkaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’d be great if PR title mentioned the fact that the change is about one specific example, not Next.js itself. Should help people who are watching the repo or are reading the changelog ;)

examples/data-fetch/pages/index.js Outdated Show resolved Hide resolved
examples/data-fetch/pages/index.js Show resolved Hide resolved
@asotoglez asotoglez changed the title Update to SSG Update data-fetch example to SSG Mar 12, 2020
@ijjk
Copy link
Member

ijjk commented Mar 12, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary asotoglez/next.js issue-11014 Change
buildDuration 9.2s 10.2s ⚠️ +908ms
nodeModulesSize 56.6 MB 56.6 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary asotoglez/next.js issue-11014 Change
main-HASH.js gzip 5.77 kB 5.77 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..cfaa.js gzip 9.77 kB 9.77 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 55.4 kB 55.4 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary asotoglez/next.js issue-11014 Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary asotoglez/next.js issue-11014 Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB
Overall change 26.2 kB 26.2 kB
Client Pages
zeit/next.js canary asotoglez/next.js issue-11014 Change
_app.js gzip 1.09 kB 1.09 kB
_error.js gzip 2.96 kB 2.96 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.89 kB 1.89 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary asotoglez/next.js issue-11014 Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.06 kB 2.06 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary asotoglez/next.js issue-11014 Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary asotoglez/next.js issue-11014 Change
index.html gzip 914 B 914 B
link.html gzip 922 B 922 B
withRouter.html gzip 910 B 910 B
Overall change 2.75 kB 2.75 kB

Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary asotoglez/next.js issue-11014 Change
buildDuration 10.6s 9.9s -795ms
nodeModulesSize 56.6 MB 56.6 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary asotoglez/next.js issue-11014 Change
main-HASH.js gzip 5.77 kB 5.77 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..cfaa.js gzip 9.77 kB 9.77 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 55.4 kB 55.4 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary asotoglez/next.js issue-11014 Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary asotoglez/next.js issue-11014 Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB
Overall change 26.2 kB 26.2 kB
Client Pages
zeit/next.js canary asotoglez/next.js issue-11014 Change
_app.js gzip 1.09 kB 1.09 kB
_error.js gzip 2.96 kB 2.96 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.89 kB 1.89 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary asotoglez/next.js issue-11014 Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.06 kB 2.06 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary asotoglez/next.js issue-11014 Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall decrease ✓
zeit/next.js canary asotoglez/next.js issue-11014 Change
_error.js gzip 293 kB 293 kB ⚠️ +81 B
404.html gzip 1.32 kB 1.32 kB
hooks.html gzip 954 B 954 B
index.js gzip 293 kB 293 kB -420 B
link.js gzip 301 kB 301 kB -15 B
routerDirect.js gzip 300 kB 299 kB -354 B
withRouter.js gzip 299 kB 300 kB ⚠️ +186 B
Overall change 1.49 MB 1.49 MB -522 B

@lfades
Copy link
Member

lfades commented Mar 12, 2020

@asotoglez The example was perfect with getStaticProps 🙏

@ijjk
Copy link
Member

ijjk commented Mar 12, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary asotoglez/next.js issue-11014 Change
buildDuration 8.4s 8.4s -29ms
nodeModulesSize 56.6 MB 56.6 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary asotoglez/next.js issue-11014 Change
main-HASH.js gzip 5.77 kB 5.77 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..cfaa.js gzip 9.77 kB 9.77 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 55.4 kB 55.4 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary asotoglez/next.js issue-11014 Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary asotoglez/next.js issue-11014 Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB
Overall change 26.2 kB 26.2 kB
Client Pages
zeit/next.js canary asotoglez/next.js issue-11014 Change
_app.js gzip 1.09 kB 1.09 kB
_error.js gzip 2.96 kB 2.96 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.89 kB 1.89 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary asotoglez/next.js issue-11014 Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.06 kB 2.06 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary asotoglez/next.js issue-11014 Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary asotoglez/next.js issue-11014 Change
index.html gzip 914 B 914 B
link.html gzip 922 B 922 B
withRouter.html gzip 910 B 910 B
Overall change 2.75 kB 2.75 kB

Serverless Mode (Increase detected ⚠️)
General
zeit/next.js canary asotoglez/next.js issue-11014 Change
buildDuration 9s 9.7s ⚠️ +739ms
nodeModulesSize 56.6 MB 56.6 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary asotoglez/next.js issue-11014 Change
main-HASH.js gzip 5.77 kB 5.77 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..cfaa.js gzip 9.77 kB 9.77 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 55.4 kB 55.4 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary asotoglez/next.js issue-11014 Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary asotoglez/next.js issue-11014 Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB
Overall change 26.2 kB 26.2 kB
Client Pages
zeit/next.js canary asotoglez/next.js issue-11014 Change
_app.js gzip 1.09 kB 1.09 kB
_error.js gzip 2.96 kB 2.96 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.89 kB 1.89 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary asotoglez/next.js issue-11014 Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.06 kB 2.06 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary asotoglez/next.js issue-11014 Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall increase ⚠️
zeit/next.js canary asotoglez/next.js issue-11014 Change
_error.js gzip 293 kB 293 kB -298 B
404.html gzip 1.32 kB 1.32 kB
hooks.html gzip 954 B 954 B
index.js gzip 293 kB 293 kB ⚠️ +300 B
link.js gzip 301 kB 301 kB ⚠️ +31 B
routerDirect.js gzip 299 kB 300 kB ⚠️ +170 B
withRouter.js gzip 299 kB 300 kB ⚠️ +130 B
Overall change 1.49 MB 1.49 MB ⚠️ +333 B

@ijjk
Copy link
Member

ijjk commented Mar 12, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary asotoglez/next.js issue-11014 Change
buildDuration 10.4s 10.4s -2ms
nodeModulesSize 56.6 MB 56.6 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary asotoglez/next.js issue-11014 Change
main-HASH.js gzip 5.77 kB 5.77 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..cfaa.js gzip 9.77 kB 9.77 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 55.4 kB 55.4 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary asotoglez/next.js issue-11014 Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary asotoglez/next.js issue-11014 Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB
Overall change 26.2 kB 26.2 kB
Client Pages
zeit/next.js canary asotoglez/next.js issue-11014 Change
_app.js gzip 1.09 kB 1.09 kB
_error.js gzip 2.96 kB 2.96 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.89 kB 1.89 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary asotoglez/next.js issue-11014 Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.06 kB 2.06 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary asotoglez/next.js issue-11014 Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary asotoglez/next.js issue-11014 Change
index.html gzip 914 B 914 B
link.html gzip 922 B 922 B
withRouter.html gzip 910 B 910 B
Overall change 2.75 kB 2.75 kB

Serverless Mode (Increase detected ⚠️)
General
zeit/next.js canary asotoglez/next.js issue-11014 Change
buildDuration 11.3s 11.4s ⚠️ +100ms
nodeModulesSize 56.6 MB 56.6 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary asotoglez/next.js issue-11014 Change
main-HASH.js gzip 5.77 kB 5.77 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..cfaa.js gzip 9.77 kB 9.77 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 55.4 kB 55.4 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary asotoglez/next.js issue-11014 Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary asotoglez/next.js issue-11014 Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB
Overall change 26.2 kB 26.2 kB
Client Pages
zeit/next.js canary asotoglez/next.js issue-11014 Change
_app.js gzip 1.09 kB 1.09 kB
_error.js gzip 2.96 kB 2.96 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.89 kB 1.89 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary asotoglez/next.js issue-11014 Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.06 kB 2.06 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary asotoglez/next.js issue-11014 Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall increase ⚠️
zeit/next.js canary asotoglez/next.js issue-11014 Change
_error.js gzip 293 kB 293 kB ⚠️ +372 B
404.html gzip 1.32 kB 1.32 kB
hooks.html gzip 954 B 954 B
index.js gzip 293 kB 294 kB ⚠️ +909 B
link.js gzip 300 kB 301 kB ⚠️ +810 B
routerDirect.js gzip 300 kB 300 kB ⚠️ +143 B
withRouter.js gzip 300 kB 300 kB -170 B
Overall change 1.49 MB 1.49 MB ⚠️ +2.06 kB

Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lfades lfades merged commit 0f0013b into vercel:canary Mar 12, 2020
ScriptedAlchemy pushed a commit to module-federation/next.js that referenced this pull request Mar 17, 2020
* Update to SSG

* Change to getServerSideProps

* Fix lint

* Update
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants