Update @next/bundle-analyzer dependencies #11068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaisugi
requested review from
ijjk,
lfades,
Timer and
timneutkens
as code owners
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Decrease detected ✓)General
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles Overall decrease ✓
|
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Decrease detected ✓)General
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles Overall decrease ✓
|
timneutkens
approved these changes
Mar 14, 2020
timneutkens
requested changes
Mar 14, 2020
|
Note that this is not really a vulnerability that affects real applications, there is no unauthorized code being executed (acorn is not used in the browser ofcourse). |
|
forgot to care about |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Increase detected
|
| zeit/next.js canary | 7ma7X/next.js patch-1 | Change | |
|---|---|---|---|
| buildDuration | 9.4s | 9.6s | |
| nodeModulesSize | 56.6 MB | 56.6 MB | ✓ |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | 7ma7X/next.js patch-1 | Change | |
|---|---|---|---|
| main-HASH.js gzip | 5.77 kB | 5.77 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..8eb0.js gzip | 9.78 kB | 9.78 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 55.4 kB | 55.4 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | 7ma7X/next.js patch-1 | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.78 kB | 4.78 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 6.71 kB | 6.71 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 51.4 kB | 51.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | 7ma7X/next.js patch-1 | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.2 kB | 26.2 kB | ✓ |
| Overall change | 26.2 kB | 26.2 kB | ✓ |
Client Pages
| zeit/next.js canary | 7ma7X/next.js patch-1 | Change | |
|---|---|---|---|
| _app.js gzip | 1.09 kB | 1.09 kB | ✓ |
| _error.js gzip | 2.97 kB | 2.97 kB | ✓ |
| hooks.js gzip | 664 B | 664 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 1.89 kB | 1.89 kB | ✓ |
| routerDirect.js gzip | 279 B | 279 B | ✓ |
| withRouter.js gzip | 278 B | 278 B | ✓ |
| Overall change | 7.39 kB | 7.39 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | 7ma7X/next.js patch-1 | Change | |
|---|---|---|---|
| _app.module.js gzip | 594 B | 594 B | ✓ |
| _error.module.js gzip | 2.08 kB | 2.08 kB | ✓ |
| hooks.module.js gzip | 370 B | 370 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 1.48 kB | 1.48 kB | ✓ |
| routerDirect..dule.js gzip | 271 B | 271 B | ✓ |
| withRouter.m..dule.js gzip | 270 B | 270 B | ✓ |
| Overall change | 5.28 kB | 5.28 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | 7ma7X/next.js patch-1 | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
| zeit/next.js canary | 7ma7X/next.js patch-1 | Change | |
|---|---|---|---|
| _error.js gzip | 293 kB | 293 kB | -374 B |
| 404.html gzip | 1.32 kB | 1.32 kB | ✓ |
| hooks.html gzip | 957 B | 957 B | ✓ |
| index.js gzip | 293 kB | 294 kB | |
| link.js gzip | 301 kB | 301 kB | -189 B |
| routerDirect.js gzip | 299 kB | 300 kB | |
| withRouter.js gzip | 300 kB | 300 kB | -29 B |
| Overall change | 1.49 MB | 1.49 MB |
timneutkens
approved these changes
Mar 15, 2020
|
Thank you! |
chibicode
added a commit
to chibicode/next.js
that referenced
this pull request
Mar 16, 2020
* canary: (47 commits) v9.3.1-canary.5 Update @next/bundle-analyzer dependencies (vercel#11068) Update preset.ts: Remove any and use updated Node.js types (vercel#11075) Upgrade styled-jsx (vercel#11070) Update ssr-caching example with getServerSideProps (vercel#11032) Add support for static 404 when _error does not have custom GIP (vercel#11062) update form handler example (vercel#11059) Update with-loading example to SSG (vercel#11050) Upgrade next.js version on datocms example (vercel#11039) Update custom-server-express example with getServerSideProps (vercel#11035) Use getServerSideProps (vercel#11057) v9.3.1-canary.4 Updated analyze-bundles example (vercel#11031) Update custom-server-fastify example to not use internal fn (vercel#11040) Correct Cache-Control Behavior for GS(S)P (vercel#11022) Update next-sass example to use built-in sass support (vercel#11015) Update with-zeit-fetch example to use SSG (vercel#11026) Update amp-first example to use GSSP (vercel#11028) Fix Test for Windows feat: update api-routes example to SSG (vercel#11019) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webpack-bundle-analyzer should be upgraded to v3.6.1, because its previous versions have acorn (< 7.1.1) which is pointed out some vulnerabilities (https://www.npmjs.com/advisories/1488 )