Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move public directory for development in examples/with-firebase-hosting-* #11085

Merged
merged 1 commit into from Mar 17, 2020
Merged

Move public directory for development in examples/with-firebase-hosting-* #11085

merged 1 commit into from Mar 17, 2020

Conversation

petamoriken
Copy link
Contributor

Don't ignore public directory at yarn run dev command in examples/with-firebase-hosting-*.

@ijjk
Copy link
Member

ijjk commented Mar 15, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary petamoriken/next.js fix/examples/with-firebase-hosting Change
buildDuration 8.4s 8.6s ⚠️ +128ms
nodeModulesSize 54.8 MB 54.8 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary petamoriken/next.js fix/examples/with-firebase-hosting Change
main-HASH.js gzip 5.77 kB 5.77 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 55.4 kB 55.4 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary petamoriken/next.js fix/examples/with-firebase-hosting Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary petamoriken/next.js fix/examples/with-firebase-hosting Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary petamoriken/next.js fix/examples/with-firebase-hosting Change
_app.js gzip 1.09 kB 1.09 kB
_error.js gzip 2.97 kB 2.97 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.89 kB 1.89 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.39 kB 7.39 kB
Client Pages Modern
zeit/next.js canary petamoriken/next.js fix/examples/with-firebase-hosting Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.28 kB 5.28 kB
Client Build Manifests
zeit/next.js canary petamoriken/next.js fix/examples/with-firebase-hosting Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary petamoriken/next.js fix/examples/with-firebase-hosting Change
index.html gzip 916 B 916 B
link.html gzip 926 B 926 B
withRouter.html gzip 913 B 913 B
Overall change 2.75 kB 2.75 kB

Serverless Mode (Increase detected ⚠️)
General
zeit/next.js canary petamoriken/next.js fix/examples/with-firebase-hosting Change
buildDuration 9s 9.2s ⚠️ +125ms
nodeModulesSize 54.8 MB 54.8 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary petamoriken/next.js fix/examples/with-firebase-hosting Change
main-HASH.js gzip 5.77 kB 5.77 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 55.4 kB 55.4 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary petamoriken/next.js fix/examples/with-firebase-hosting Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary petamoriken/next.js fix/examples/with-firebase-hosting Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary petamoriken/next.js fix/examples/with-firebase-hosting Change
_app.js gzip 1.09 kB 1.09 kB
_error.js gzip 2.97 kB 2.97 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.89 kB 1.89 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.39 kB 7.39 kB
Client Pages Modern
zeit/next.js canary petamoriken/next.js fix/examples/with-firebase-hosting Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.28 kB 5.28 kB
Client Build Manifests
zeit/next.js canary petamoriken/next.js fix/examples/with-firebase-hosting Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall increase ⚠️
zeit/next.js canary petamoriken/next.js fix/examples/with-firebase-hosting Change
_error.js gzip 293 kB 293 kB ⚠️ +34 B
404.html gzip 1.32 kB 1.32 kB
hooks.html gzip 956 B 956 B
index.js gzip 293 kB 294 kB ⚠️ +813 B
link.js gzip 301 kB 301 kB ⚠️ +44 B
routerDirect.js gzip 300 kB 299 kB -718 B
withRouter.js gzip 300 kB 300 kB ⚠️ +250 B
Overall change 1.49 MB 1.49 MB ⚠️ +423 B

@timneutkens timneutkens merged commit bfab990 into vercel:canary Mar 17, 2020
@petamoriken petamoriken deleted the fix/examples/with-firebase-hosting branch March 17, 2020 17:06
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants