Clean up examples directory #11169

timneutkens · 2020-03-18T12:32:25Z

Went through most examples and cleaned up duplicate, outdated, and examples showing bad practices.

ijjk · 2020-03-18T12:37:42Z

Stats from current PR

Default Server Mode

General

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
buildDuration	8.6s	8.8s	⚠️ +157ms
nodeModulesSize	54.9 MB	54.9 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
main-HASH.js gzip	5.76 kB	5.76 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..8eb0.js gzip	9.78 kB	9.78 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	55.4 kB	55.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
main-HASH.module.js gzip	4.77 kB	4.77 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
_app.js gzip	1.09 kB	1.09 kB	✓
_error.js gzip	2.97 kB	2.97 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.89 kB	1.89 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.39 kB	7.39 kB	✓

Client Pages Modern

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
index.html gzip	916 B	916 B	✓
link.html gzip	925 B	925 B	✓
withRouter.html gzip	914 B	914 B	✓
Overall change	2.75 kB	2.75 kB	✓

Serverless Mode (Decrease detected ✓)

General

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
buildDuration	9.5s	9.6s	⚠️ +134ms
nodeModulesSize	54.9 MB	54.9 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
main-HASH.js gzip	5.76 kB	5.76 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..8eb0.js gzip	9.78 kB	9.78 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	55.4 kB	55.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
main-HASH.module.js gzip	4.77 kB	4.77 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
_app.js gzip	1.09 kB	1.09 kB	✓
_error.js gzip	2.97 kB	2.97 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.89 kB	1.89 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.39 kB	7.39 kB	✓

Client Pages Modern

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
_error.js gzip	293 kB	293 kB	-28 B
404.html gzip	1.32 kB	1.32 kB	✓
hooks.html gzip	957 B	957 B	✓
index.js gzip	293 kB	293 kB	⚠️ +415 B
link.js gzip	302 kB	301 kB	-342 B
routerDirect.js gzip	300 kB	300 kB	-104 B
withRouter.js gzip	300 kB	300 kB	⚠️ +18 B
Overall change	1.49 MB	1.49 MB	-41 B

ijjk · 2020-03-18T12:39:43Z

Stats from current PR

Default Server Mode

General

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
buildDuration	8.7s	8.4s	-292ms
nodeModulesSize	54.9 MB	54.9 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
main-HASH.js gzip	5.76 kB	5.76 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..8eb0.js gzip	9.78 kB	9.78 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	55.4 kB	55.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
main-HASH.module.js gzip	4.77 kB	4.77 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
_app.js gzip	1.09 kB	1.09 kB	✓
_error.js gzip	2.97 kB	2.97 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.89 kB	1.89 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.39 kB	7.39 kB	✓

Client Pages Modern

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
index.html gzip	916 B	916 B	✓
link.html gzip	925 B	925 B	✓
withRouter.html gzip	914 B	914 B	✓
Overall change	2.75 kB	2.75 kB	✓

Serverless Mode (Decrease detected ✓)

General

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
buildDuration	9s	8.9s	-75ms
nodeModulesSize	54.9 MB	54.9 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
main-HASH.js gzip	5.76 kB	5.76 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..8eb0.js gzip	9.78 kB	9.78 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	55.4 kB	55.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
main-HASH.module.js gzip	4.77 kB	4.77 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
_app.js gzip	1.09 kB	1.09 kB	✓
_error.js gzip	2.97 kB	2.97 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.89 kB	1.89 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.39 kB	7.39 kB	✓

Client Pages Modern

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	timneutkens/next.js docs/remove-outdated-examples	Change
_error.js gzip	293 kB	293 kB	-32 B
404.html gzip	1.32 kB	1.32 kB	✓
hooks.html gzip	957 B	957 B	✓
index.js gzip	293 kB	294 kB	⚠️ +633 B
link.js gzip	301 kB	301 kB	-65 B
routerDirect.js gzip	300 kB	300 kB	-226 B
withRouter.js gzip	300 kB	299 kB	-677 B
Overall change	1.49 MB	1.49 MB	-367 B

rosscooperman · 2021-04-06T13:41:09Z

@timneutkens noticed that with-hashed-statics was removed (0e0f03b) as outdated. I've spent most of this morning trying to determine best practices for ensuring that assets in public/ are hashed when served in production. I assume asset fingerprinting is automatic when following https://nextjs.org/docs/api-reference/next.config.js/cdn-support-with-asset-prefix but that doc clearly states that it does not apply the prefix to files in public/. But all of the docs also encourage placing images in public/ and referencing them with /<name-of-image>. What is the current recommended method for handling fingerprinting of image assets in public/?

timneutkens added 25 commits March 18, 2020 10:45

Remove outdated examples

d0fb8a0

Remove outdated example

a62560c

Remove outdated example that doesn't show best practices

0c35580

Remove outdated example

404d8fd

Remove outdated example

60d7cb2

Remove outdated example

b3fb195

Update preact example

b0de832

Update using-router to use useRouter

98f86bd

Remove outdated example

1851af6

Remove outdated example

664cb85

Remove outdated example

50bb242

Remove outdated example

09e0780

Remove outdated example

a32582a

Remove outdated example

5bb958d

Combine examples

d8fc40b

Simplify offered examples

08f7a7d

Remove outdated example

ab49fb3

Add link to new example

30ef29d

Removed outdated example

0e0f03b

Markdown example has been improved

6afcc3d

Remove example that showed bad practices

4ffb392

Remove outdated example

dca09f0

Update polyfills example

04fbe0b

Remove outdated example

023f52f

Remove outdated example

04cf366

timneutkens requested review from lfades and Timer as code owners March 18, 2020 12:32

timneutkens added 3 commits March 18, 2020 13:34

Remove outdated example

b344a60

Removed outdated example

47787b7

Remove outdated example

29ffaa6

timneutkens added 2 commits March 18, 2020 13:36

Remove outdated example

0f5b0c0

Remove outdated example

bda169c

Remove outdated example

7b6b48e

timneutkens added 2 commits March 18, 2020 13:40

Update webassembly example

9228936

Move example

f97626e

timneutkens merged commit ac34a9f into vercel:canary Mar 18, 2020

timneutkens deleted the docs/remove-outdated-examples branch March 18, 2020 12:45

This was referenced Apr 13, 2020

[Snyk] Upgrade next from 9.3.2 to 9.3.4 yowainwright/Advanced-React#46

Merged

[Snyk] Upgrade next from 9.3.1 to 9.3.2 cds-snc/next-holidays#35

Closed

This was referenced Apr 22, 2020

[Snyk] Upgrade next from 9.3.2 to 9.3.3 zagrajmy/frontend#162

Merged

[Snyk] Upgrade next from 9.3.2 to 9.3.3 grouparoo/next-plugins-example#9

Closed

[Snyk] Upgrade next from 9.3.2 to 9.3.3 GreyWolfLab/devPortal#3

Open

vercel locked as resolved and limited conversation to collaborators Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up examples directory #11169

Clean up examples directory #11169

timneutkens commented Mar 18, 2020

ijjk commented Mar 18, 2020

ijjk commented Mar 18, 2020

rosscooperman commented Apr 6, 2021

Clean up examples directory #11169

Clean up examples directory #11169

Conversation

timneutkens commented Mar 18, 2020

ijjk commented Mar 18, 2020

Stats from current PR

ijjk commented Mar 18, 2020

Stats from current PR

rosscooperman commented Apr 6, 2021