Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(example): Load basic-css example on codesandbox #11227

Merged
merged 3 commits into from Mar 20, 2020
Merged

docs(example): Load basic-css example on codesandbox #11227

merged 3 commits into from Mar 20, 2020

Conversation

gregrickaby
Copy link
Contributor

Just a quick PR to add the "Try it on CodeSandbox" link at the bottom of the README.

View the example here: https://codesandbox.io/s/github/zeit/next.js/tree/canary/examples/basic-css

@gregrickaby gregrickaby changed the title Load basic-css example on codesandbox [example] Load basic-css example on codesandbox Mar 20, 2020
@gregrickaby gregrickaby changed the title [example] Load basic-css example on codesandbox docs(example) Load basic-css example on codesandbox Mar 20, 2020
@gregrickaby gregrickaby changed the title docs(example) Load basic-css example on codesandbox docs(example): Load basic-css example on codesandbox Mar 20, 2020
@ijjk
Copy link
Member

ijjk commented Mar 20, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary gregrickaby/next.js patch-1 Change
buildDuration 11.4s 11.3s -39ms
nodeModulesSize 53.2 MB 53.2 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary gregrickaby/next.js patch-1 Change
main-HASH.js gzip 5.77 kB 5.77 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 55.4 kB 55.4 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary gregrickaby/next.js patch-1 Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary gregrickaby/next.js patch-1 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary gregrickaby/next.js patch-1 Change
_app.js gzip 1.09 kB 1.09 kB
_error.js gzip 2.97 kB 2.97 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.89 kB 1.89 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.39 kB 7.39 kB
Client Pages Modern
zeit/next.js canary gregrickaby/next.js patch-1 Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.28 kB 5.28 kB
Client Build Manifests
zeit/next.js canary gregrickaby/next.js patch-1 Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary gregrickaby/next.js patch-1 Change
index.html gzip 915 B 915 B
link.html gzip 924 B 924 B
withRouter.html gzip 913 B 913 B
Overall change 2.75 kB 2.75 kB

Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary gregrickaby/next.js patch-1 Change
buildDuration 12s 11.9s -110ms
nodeModulesSize 53.2 MB 53.2 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary gregrickaby/next.js patch-1 Change
main-HASH.js gzip 5.77 kB 5.77 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 55.4 kB 55.4 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary gregrickaby/next.js patch-1 Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary gregrickaby/next.js patch-1 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary gregrickaby/next.js patch-1 Change
_app.js gzip 1.09 kB 1.09 kB
_error.js gzip 2.97 kB 2.97 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.89 kB 1.89 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.39 kB 7.39 kB
Client Pages Modern
zeit/next.js canary gregrickaby/next.js patch-1 Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.28 kB 5.28 kB
Client Build Manifests
zeit/next.js canary gregrickaby/next.js patch-1 Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall decrease ✓
zeit/next.js canary gregrickaby/next.js patch-1 Change
_error.js gzip 293 kB 293 kB ⚠️ +18 B
404.html gzip 1.32 kB 1.32 kB
hooks.html gzip 956 B 956 B
index.js gzip 293 kB 293 kB -515 B
link.js gzip 301 kB 301 kB ⚠️ +137 B
routerDirect.js gzip 300 kB 300 kB -281 B
withRouter.js gzip 300 kB 300 kB -153 B
Overall change 1.49 MB 1.49 MB -794 B

@lfades
Copy link
Member

lfades commented Mar 20, 2020

Nice improvement! I'm thinking where should it go, I think it may be at the beginning instead 🤔 and also I don't feel like a title is required. Or maybe under How to use inside a new title like Using Codesandbox

@lfades
Copy link
Member

lfades commented Mar 20, 2020

@gregrickaby @chibicode I just moved the link to be right after How to use, how does it look to you?

@gregrickaby
Copy link
Contributor Author

gregrickaby commented Mar 20, 2020

I like it! Thank you!

I noticed quite a few other examples that don't have links, is that something you need taken care of?

@lfades
Copy link
Member

lfades commented Mar 20, 2020

@gregrickaby You can add it to examples where it makes sense to add it, meaning to examples where it would work without additional changes, not every example can do this because some require custom configs and more steps.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants