fix: typo in `isStaging` in `with-env` example #11305

nicolasrouanne · 2020-03-23T21:01:49Z

add missing phase === statement when checking for staging env in isStaging

- add missing `phase ===` statement when checking for _staging_ env in `isStaging`

ijjk · 2020-03-23T21:07:37Z

Stats from current PR

Default Server Mode

General

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
buildDuration	10s	10s	-22ms
nodeModulesSize	52.8 MB	52.8 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
index.html gzip	919 B	919 B	✓
link.html gzip	927 B	927 B	✓
withRouter.html gzip	916 B	916 B	✓
Overall change	2.76 kB	2.76 kB	✓

Serverless Mode (Increase detected ⚠️)

General

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
buildDuration	10.8s	11s	⚠️ +244ms
nodeModulesSize	52.8 MB	52.8 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
_error.js gzip	294 kB	294 kB	-315 B
404.html gzip	1.32 kB	1.32 kB	✓
hooks.html gzip	960 B	960 B	✓
index.js gzip	293 kB	294 kB	⚠️ +283 B
link.js gzip	301 kB	302 kB	⚠️ +342 B
routerDirect.js gzip	300 kB	300 kB	-28 B
withRouter.js gzip	300 kB	300 kB	⚠️ +149 B
Overall change	1.49 MB	1.49 MB	⚠️ +431 B

lfades

@nicolasrouanne Good catch. Thank you!

examples/with-env-from-next-config-js/next.config.js

nicolasrouanne · 2020-03-24T08:57:36Z

I fixed a typo to add a new one 🤦‍♂
I tried editing the file only on GH, except in that case you don't have prettier and eslint catching your mistakes.

Will fix the prettier issue.

timneutkens · 2020-03-24T09:01:49Z

Yep we'll wait for that change 👍

ijjk · 2020-03-24T09:16:15Z

Stats from current PR

Default Server Mode

General

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
buildDuration	9.3s	9.2s	-64ms
nodeModulesSize	52.9 MB	52.9 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
index.html gzip	918 B	918 B	✓
link.html gzip	927 B	927 B	✓
withRouter.html gzip	914 B	914 B	✓
Overall change	2.76 kB	2.76 kB	✓

Serverless Mode (Decrease detected ✓)

General

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
buildDuration	9.8s	10.1s	⚠️ +236ms
nodeModulesSize	52.9 MB	52.9 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	nicolasrouanne/next.js patch-1	Change
_error.js gzip	294 kB	294 kB	⚠️ +12 B
404.html gzip	1.32 kB	1.32 kB	✓
hooks.html gzip	960 B	960 B	✓
index.js gzip	293 kB	294 kB	⚠️ +863 B
link.js gzip	302 kB	301 kB	-630 B
routerDirect.js gzip	300 kB	299 kB	-443 B
withRouter.js gzip	300 kB	299 kB	-517 B
Overall change	1.49 MB	1.49 MB	-715 B

fix: typo in isStaging in with-env example

e80b912

- add missing `phase ===` statement when checking for _staging_ env in `isStaging`

nicolasrouanne requested review from lfades and Timer as code owners March 23, 2020 21:01

lfades approved these changes Mar 24, 2020

View reviewed changes

lfades reviewed Mar 24, 2020

View reviewed changes

examples/with-env-from-next-config-js/next.config.js Outdated Show resolved Hide resolved

Update examples/with-env-from-next-config-js/next.config.js

930e10e

timneutkens approved these changes Mar 24, 2020

View reviewed changes

style: fix prettier issue in example with-env-from-next-config-js

74e1110

timneutkens merged commit ed06434 into vercel:canary Mar 24, 2020

This was referenced Apr 13, 2020

[Snyk] Upgrade next from 9.3.2 to 9.3.4 yowainwright/Advanced-React#46

Merged

[Snyk] Upgrade next from 9.3.1 to 9.3.2 cds-snc/next-holidays#35

Closed

snyk-bot mentioned this pull request Apr 22, 2020

[Snyk] Upgrade next from 9.3.2 to 9.3.3 zagrajmy/frontend#162

Merged

This was referenced Apr 22, 2020

[Snyk] Upgrade next from 9.3.2 to 9.3.3 grouparoo/next-plugins-example#9

Closed

[Snyk] Upgrade next from 9.3.2 to 9.3.3 GreyWolfLab/devPortal#3

Open

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: typo in `isStaging` in `with-env` example #11305

fix: typo in `isStaging` in `with-env` example #11305

nicolasrouanne commented Mar 23, 2020

ijjk commented Mar 23, 2020

lfades left a comment

nicolasrouanne commented Mar 24, 2020

timneutkens commented Mar 24, 2020 •

edited

ijjk commented Mar 24, 2020

fix: typo in isStaging in with-env example #11305

fix: typo in isStaging in with-env example #11305

Conversation

nicolasrouanne commented Mar 23, 2020

ijjk commented Mar 23, 2020

Stats from current PR

lfades left a comment

Choose a reason for hiding this comment

nicolasrouanne commented Mar 24, 2020

timneutkens commented Mar 24, 2020 • edited

ijjk commented Mar 24, 2020

Stats from current PR

fix: typo in `isStaging` in `with-env` example #11305

fix: typo in `isStaging` in `with-env` example #11305

timneutkens commented Mar 24, 2020 •

edited