Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning for API routes with next export #11330

Merged
merged 2 commits into from Mar 24, 2020
Merged

Fix warning for API routes with next export #11330

merged 2 commits into from Mar 24, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Mar 24, 2020

This fixes our API routes warning missing when a default exportPathMap is used

@ijjk ijjk added the kind: bug Confirmed bug that is on the backlog label Mar 24, 2020
@ijjk ijjk added this to the 9.3.2 milestone Mar 24, 2020
@ijjk
Copy link
Member Author

ijjk commented Mar 24, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
buildDuration 10.1s 10.3s ⚠️ +215ms
nodeModulesSize 53 MB 53 MB ⚠️ +127 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
main-HASH.js gzip 6.24 kB 6.24 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..c6c1.js gzip 10.1 kB 10.1 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.2 kB 56.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
index.html gzip 917 B 917 B ✓
link.html gzip 925 B 925 B ✓
withRouter.html gzip 912 B 912 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
buildDuration 10.8s 10.9s ⚠️ +80ms
nodeModulesSize 53 MB 53 MB ⚠️ +127 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
main-HASH.js gzip 6.24 kB 6.24 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..c6c1.js gzip 10.1 kB 10.1 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.2 kB 56.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
_error.js gzip 293 kB 294 kB ⚠️ +883 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 957 B 957 B ✓
index.js gzip 293 kB 294 kB ⚠️ +578 B
link.js gzip 301 kB 302 kB ⚠️ +761 B
routerDirect.js gzip 300 kB 300 kB ⚠️ +101 B
withRouter.js gzip 300 kB 300 kB ⚠️ +114 B
Overall change 1.49 MB 1.49 MB ⚠️ +2.44 kB

@ijjk
Copy link
Member Author

ijjk commented Mar 24, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
buildDuration 11.1s 11.6s ⚠️ +452ms
nodeModulesSize 53 MB 53 MB ⚠️ +1.14 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
main-HASH.js gzip 6.24 kB 6.24 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..c6c1.js gzip 10.1 kB 10.1 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.2 kB 56.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
index.html gzip 917 B 917 B ✓
link.html gzip 925 B 925 B ✓
withRouter.html gzip 912 B 912 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
buildDuration 12s 12.1s ⚠️ +91ms
nodeModulesSize 53 MB 53 MB ⚠️ +1.14 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
main-HASH.js gzip 6.24 kB 6.24 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..c6c1.js gzip 10.1 kB 10.1 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.2 kB 56.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/api-export-warn Change
_error.js gzip 293 kB 293 kB ⚠️ +385 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 957 B 957 B ✓
index.js gzip 294 kB 294 kB ⚠️ +694 B
link.js gzip 302 kB 301 kB -264 B
routerDirect.js gzip 300 kB 300 kB ⚠️ +6 B
withRouter.js gzip 300 kB 300 kB ⚠️ +247 B
Overall change 1.49 MB 1.49 MB ⚠️ +1.07 kB

@Timer Timer merged commit eeea53c into vercel:canary Mar 24, 2020
@Timer Timer deleted the fix/api-export-warn branch March 24, 2020 17:38
This was referenced Mar 27, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 13, 2020
Merged
Closed
This was referenced Apr 22, 2020
Merged
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 22, 2020
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
kind: bug Confirmed bug that is on the backlog
Projects
None yet
Milestone
9.3.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @Timer