Fix css dependency in /_error #17301

TasukuUno · 2020-09-23T07:14:12Z

This PR is to report that the issue #16931 is not to be reproduced with this diff.
(I actually found out this by editing the production code installed from npm.)

The styles for error page were loaded In next@9.5.2, but the css file seemed to be loaded by the client js instead of being loaded on the server-rendered HTML. And in next@9.5.3 to 9.5.4-canary-20, the styles are not being loaded at all. Therefore, I think the files were excluded all along from earlier versions. I investigated the past diffs as possible I could, but I didn't figure out the reason why we should exclude files for _error page.

I will never mind if this change is merged or not, but I really hope this issue will be solved because this is critical for us.

Fixes: #16931

ijjk · 2020-09-23T07:24:41Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
buildDuration	14s	14.4s	⚠️ +452ms
nodeModulesSize	62.9 MB	62.9 MB	-94 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.671	2.586	-0.08
/ avg req/sec	935.93	966.66	+30.73
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.593	1.577	-0.02
/error-in-render avg req/sec	1569.65	1584.96	+15.31

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-772ea11..1d22.js gzip	7.16 kB	7.16 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-911f3f8..dule.js gzip	6.23 kB	6.23 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	997 B	997 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
buildDuration	15.4s	15.9s	⚠️ +435ms
nodeModulesSize	62.9 MB	62.9 MB	-94 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-772ea11..1d22.js gzip	7.16 kB	7.16 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-911f3f8..dule.js gzip	6.23 kB	6.23 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_error.js	1.06 MB	1.06 MB	-30 B
404.html	4.34 kB	4.73 kB	⚠️ +390 B
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	-30 B
link.js	1.1 MB	1.1 MB	-30 B
routerDirect.js	1.1 MB	1.1 MB	-30 B
withRouter.js	1.1 MB	1.1 MB	-30 B
Overall change	5.41 MB	5.41 MB	⚠️ +240 B

Commit: 8f856dc

lfades

👋 @TasukuUno Thank you for the PR!.

Please add an integration test to make sure we don't regress on this again 🙏

TasukuUno · 2020-09-24T04:35:18Z

@lfades Hi, thank you for your review!

I added an integration test creating new fixtures app.
Could you take another look?

ijjk · 2020-09-24T04:40:09Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
buildDuration	13.1s	13.1s	-18ms
nodeModulesSize	62.9 MB	62.9 MB	-94 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.475	2.352	-0.12
/ avg req/sec	1010.08	1062.86	+52.78
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.293	1.333	⚠️ +0.04
/error-in-render avg req/sec	1933.8	1876.16	⚠️ -57.64

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-772ea11..1d22.js gzip	7.16 kB	7.16 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-911f3f8..dule.js gzip	6.23 kB	6.23 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	997 B	997 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
buildDuration	14.9s	14.8s	-46ms
nodeModulesSize	62.9 MB	62.9 MB	-94 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-772ea11..1d22.js gzip	7.16 kB	7.16 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-911f3f8..dule.js gzip	6.23 kB	6.23 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_error.js	1.06 MB	1.06 MB	-30 B
404.html	4.34 kB	4.73 kB	⚠️ +390 B
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	-30 B
link.js	1.1 MB	1.1 MB	-30 B
routerDirect.js	1.1 MB	1.1 MB	-30 B
withRouter.js	1.1 MB	1.1 MB	-30 B
Overall change	5.41 MB	5.41 MB	⚠️ +240 B

Commit: f32ae87

TasukuUno · 2020-09-29T04:34:20Z

rebased.

ijjk · 2020-09-29T04:45:31Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
buildDuration	14.6s	14.3s	-306ms
nodeModulesSize	62.9 MB	62.9 MB	-94 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.722	2.796	⚠️ +0.07
/ avg req/sec	918.58	894.18	⚠️ -24.4
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.722	1.685	-0.04
/error-in-render avg req/sec	1451.92	1483.3	+31.38

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-d493e7d..42f5.js gzip	7.17 kB	7.17 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-f8905d4..dule.js gzip	6.24 kB	6.24 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
buildDuration	15.9s	16s	⚠️ +166ms
nodeModulesSize	62.9 MB	62.9 MB	-94 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-d493e7d..42f5.js gzip	7.17 kB	7.17 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-f8905d4..dule.js gzip	6.24 kB	6.24 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_error.js	1.05 MB	1.05 MB	-30 B
404.html	4.34 kB	4.73 kB	⚠️ +390 B
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.05 MB	1.05 MB	-30 B
link.js	1.1 MB	1.1 MB	-30 B
routerDirect.js	1.09 MB	1.09 MB	-30 B
withRouter.js	1.09 MB	1.09 MB	-30 B
Overall change	5.4 MB	5.4 MB	⚠️ +240 B

Commit: d16e701

ijjk · 2020-10-05T06:16:46Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
buildDuration	13.5s	12.9s	-563ms
nodeModulesSize	63.1 MB	63.1 MB	-94 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.439	2.411	-0.03
/ avg req/sec	1025.1	1037.11	+12.01
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.277	1.343	⚠️ +0.07
/error-in-render avg req/sec	1957.44	1861.98	⚠️ -95.46

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-d493e7d..42f5.js gzip	7.17 kB	7.17 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-f8905d4..dule.js gzip	6.24 kB	6.24 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
buildDuration	15s	14.9s	-26ms
nodeModulesSize	63.1 MB	63.1 MB	-94 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-d493e7d..42f5.js gzip	7.17 kB	7.17 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-f8905d4..dule.js gzip	6.24 kB	6.24 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_error.js	1.05 MB	1.05 MB	-30 B
404.html	4.34 kB	4.73 kB	⚠️ +390 B
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.05 MB	1.05 MB	-30 B
link.js	1.1 MB	1.1 MB	-30 B
routerDirect.js	1.09 MB	1.09 MB	-30 B
withRouter.js	1.09 MB	1.09 MB	-30 B
Overall change	5.4 MB	5.4 MB	⚠️ +240 B

Commit: 5175129

TasukuUno · 2020-10-05T06:26:27Z

rebased.

ijjk · 2020-10-07T08:32:23Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
buildDuration	11.7s	12.4s	⚠️ +653ms
nodeModulesSize	63.2 MB	63.2 MB	-94 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.164	2.084	-0.08
/ avg req/sec	1155.35	1199.46	+44.11
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.156	1.139	-0.02
/error-in-render avg req/sec	2163.13	2194.18	+31.05

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e5f5aee..31e1.js gzip	7.17 kB	7.17 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-ff4dea7..dule.js gzip	6.24 kB	6.24 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
buildDuration	12.7s	12s	-646ms
nodeModulesSize	63.2 MB	63.2 MB	-94 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e5f5aee..31e1.js gzip	7.17 kB	7.17 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-ff4dea7..dule.js gzip	6.24 kB	6.24 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_error.js	1.05 MB	1.05 MB	-30 B
404.html	4.34 kB	4.73 kB	⚠️ +390 B
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.05 MB	1.05 MB	-30 B
link.js	1.1 MB	1.1 MB	-30 B
routerDirect.js	1.09 MB	1.09 MB	-30 B
withRouter.js	1.09 MB	1.09 MB	-30 B
Overall change	5.4 MB	5.4 MB	⚠️ +240 B

Commit: cc1332e

TasukuUno · 2020-10-07T08:36:44Z

rebased.

@lfades Could you take another look?

ijjk · 2020-10-09T03:13:58Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
buildDuration	13.7s	13.8s	⚠️ +61ms
nodeModulesSize	63.4 MB	63.4 MB	-94 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.689	2.657	-0.03
/ avg req/sec	929.57	941.06	+11.49
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.651	1.729	⚠️ +0.08
/error-in-render avg req/sec	1514.13	1446.06	⚠️ -68.07

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..9b19.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-ef5fcfe..d66c.js gzip	7.24 kB	7.24 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58 kB	58 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..dule.js gzip	6.9 kB	6.9 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-1c7f28c..dule.js gzip	6.29 kB	6.29 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-409b283..e3ab.js gzip	1.32 kB	1.32 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.73 kB	7.73 kB	✓

Client Pages Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-92d3016..dule.js gzip	1.28 kB	1.28 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	995 B	995 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
buildDuration	15.1s	14.6s	-568ms
nodeModulesSize	63.4 MB	63.4 MB	-94 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..9b19.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-ef5fcfe..d66c.js gzip	7.24 kB	7.24 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58 kB	58 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..dule.js gzip	6.9 kB	6.9 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-1c7f28c..dule.js gzip	6.29 kB	6.29 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-409b283..e3ab.js gzip	1.32 kB	1.32 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.73 kB	7.73 kB	✓

Client Pages Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-92d3016..dule.js gzip	1.28 kB	1.28 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_error.js	1.05 MB	1.05 MB	-30 B
404.html	4.34 kB	4.73 kB	⚠️ +390 B
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.05 MB	1.05 MB	-30 B
link.js	1.1 MB	1.1 MB	-30 B
routerDirect.js	1.09 MB	1.09 MB	-30 B
withRouter.js	1.09 MB	1.09 MB	-30 B
Overall change	5.41 MB	5.41 MB	⚠️ +240 B

Commit: 40202c8

TasukuUno · 2020-10-09T03:30:25Z

rebased.

timneutkens · 2020-10-09T09:09:54Z

test/integration/document-file-dependencies/test/index.test.js

+
+    afterAll(() => killApp(app))
+
+    it('should depend on global and module css files in standard page', async () => {


These tests shouldn't check for stylesheets being there, instead you can check if the styles are loaded correctly by reading the applied styling of different elements

test/integration/document-file-dependencies/test/index.test.js

ijjk · 2020-10-09T12:08:53Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
buildDuration	12.5s	11.5s	-957ms
nodeModulesSize	63.4 MB	63.4 MB	-94 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.127	2.159	⚠️ +0.03
/ avg req/sec	1175.38	1157.68	⚠️ -17.7
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.373	1.295	-0.08
/error-in-render avg req/sec	1821.46	1930.07	+108.61

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..9b19.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-ef5fcfe..d66c.js gzip	7.24 kB	7.24 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58 kB	58 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..dule.js gzip	6.9 kB	6.9 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-1c7f28c..dule.js gzip	6.29 kB	6.29 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-409b283..e3ab.js gzip	1.32 kB	1.32 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.73 kB	7.73 kB	✓

Client Pages Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-92d3016..dule.js gzip	1.28 kB	1.28 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	995 B	995 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
buildDuration	12.7s	12.7s	-9ms
nodeModulesSize	63.4 MB	63.4 MB	-94 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..9b19.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-ef5fcfe..d66c.js gzip	7.24 kB	7.24 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58 kB	58 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..dule.js gzip	6.9 kB	6.9 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-1c7f28c..dule.js gzip	6.29 kB	6.29 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-409b283..e3ab.js gzip	1.32 kB	1.32 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.73 kB	7.73 kB	✓

Client Pages Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-92d3016..dule.js gzip	1.28 kB	1.28 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_error.js	1.05 MB	1.05 MB	-30 B
404.html	4.34 kB	4.73 kB	⚠️ +390 B
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.05 MB	1.05 MB	-30 B
link.js	1.1 MB	1.1 MB	-30 B
routerDirect.js	1.09 MB	1.09 MB	-30 B
withRouter.js	1.09 MB	1.09 MB	-30 B
Overall change	5.41 MB	5.41 MB	⚠️ +240 B

Commit: 22e99e1

timneutkens

If I remember correctly there was a reason the JS files were excluded previously, but given that the tests are not failing this change looks good 👍

TasukuUno · 2020-10-21T04:42:55Z

TasukuUno dismissed timneutkens’s stale review via 22dd1a9

@timneutkens I'm sorry, this has occurred because of my forced pushing to rebase.
But there's no changes.

BTW, when will you release this change?
Is it required approval from @Timer @ijjk and @lfades too?

ijjk · 2020-10-21T04:45:12Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
buildDuration	12.3s	12.1s	-134ms
nodeModulesSize	62.5 MB	62.5 MB	-94 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.28	2.23	-0.05
/ avg req/sec	1096.42	1120.83	+24.41
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.248	1.262	⚠️ +0.01
/error-in-render avg req/sec	2002.49	1981.34	⚠️ -21.15

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..35e7.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-0297b89..3d55.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.1 kB	58.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..dule.js gzip	6.94 kB	6.94 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-8539e6d..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53 kB	53 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-89ad9e7..25bb.js gzip	1.34 kB	1.34 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.74 kB	7.74 kB	✓

Client Pages Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-aeb707b..dule.js gzip	1.29 kB	1.29 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.39 kB	5.39 kB	✓

Client Build Manifests

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
buildDuration	14s	13.8s	-226ms
nodeModulesSize	62.5 MB	62.5 MB	-94 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..35e7.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-0297b89..3d55.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.1 kB	58.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
677f882d2ed8..dule.js gzip	6.94 kB	6.94 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-8539e6d..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53 kB	53 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-89ad9e7..25bb.js gzip	1.34 kB	1.34 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.74 kB	7.74 kB	✓

Client Pages Modern

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-aeb707b..dule.js gzip	1.29 kB	1.29 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.39 kB	5.39 kB	✓

Client Build Manifests

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	TasukuUno/next.js fix/error-styles	Change
_error.js	1.06 MB	1.06 MB	-30 B
404.html	4.34 kB	4.73 kB	⚠️ +390 B
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	-30 B
link.js	1.1 MB	1.1 MB	-30 B
routerDirect.js	1.1 MB	1.1 MB	-30 B
withRouter.js	1.1 MB	1.1 MB	-30 B
Overall change	5.42 MB	5.42 MB	⚠️ +240 B

Commit: 22dd1a9

timneutkens

We auto-merge PRs based on if they're approved. If you push again the review is removed basically.

TasukuUno · 2020-10-21T12:25:28Z

@timneutkens Thank you!! 😄

timneutkens · 2020-10-21T12:27:12Z

Thank you for the PR 💯 🚀

timneutkens · 2020-10-21T12:27:34Z

I'll make sure it's on canary today 👍

TasukuUno requested review from ijjk, lfades, Timer and timneutkens as code owners September 23, 2020 07:14

ijjk added the type: next label Sep 23, 2020

lfades requested changes Sep 23, 2020

View reviewed changes

TasukuUno force-pushed the fix/error-styles branch from 8f856dc to f32ae87 Compare September 24, 2020 04:30

TasukuUno requested a review from lfades September 29, 2020 00:11

TasukuUno force-pushed the fix/error-styles branch from f32ae87 to d16e701 Compare September 29, 2020 04:33

TasukuUno force-pushed the fix/error-styles branch from d16e701 to 5175129 Compare October 5, 2020 06:06

TasukuUno force-pushed the fix/error-styles branch from 5175129 to cc1332e Compare October 7, 2020 08:23

TasukuUno force-pushed the fix/error-styles branch from cc1332e to 40202c8 Compare October 9, 2020 03:03

timneutkens reviewed Oct 9, 2020

View reviewed changes

TasukuUno force-pushed the fix/error-styles branch from 40202c8 to 22e99e1 Compare October 9, 2020 11:59

TasukuUno commented Oct 9, 2020

View reviewed changes

test/integration/document-file-dependencies/test/index.test.js Show resolved Hide resolved

timneutkens previously approved these changes Oct 9, 2020

View reviewed changes

stjanilofts mentioned this pull request Oct 13, 2020

Website / Temporary fix until next.js addresses an issue island-is/island.is#1337

Merged

7 tasks

Fix css dependency in /_error

235f38d

Improve integration test of css dependency

22dd1a9

TasukuUno dismissed timneutkens’s stale review via 22dd1a9 October 21, 2020 04:35

TasukuUno force-pushed the fix/error-styles branch from 22e99e1 to 22dd1a9 Compare October 21, 2020 04:35

timneutkens approved these changes Oct 21, 2020

View reviewed changes

timneutkens merged commit 9dfc9eb into vercel:canary Oct 21, 2020

TasukuUno deleted the fix/error-styles branch October 21, 2020 12:25

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix css dependency in /_error #17301

Fix css dependency in /_error #17301

TasukuUno commented Sep 23, 2020

ijjk commented Sep 23, 2020

lfades left a comment

TasukuUno commented Sep 24, 2020

ijjk commented Sep 24, 2020

TasukuUno commented Sep 29, 2020

ijjk commented Sep 29, 2020

ijjk commented Oct 5, 2020

TasukuUno commented Oct 5, 2020

ijjk commented Oct 7, 2020

TasukuUno commented Oct 7, 2020

ijjk commented Oct 9, 2020

TasukuUno commented Oct 9, 2020

timneutkens Oct 9, 2020

ijjk commented Oct 9, 2020

timneutkens left a comment

TasukuUno commented Oct 21, 2020

ijjk commented Oct 21, 2020

timneutkens left a comment

TasukuUno commented Oct 21, 2020

timneutkens commented Oct 21, 2020

timneutkens commented Oct 21, 2020


		afterAll(() => killApp(app))

		it('should depend on global and module css files in standard page', async () => {

Fix css dependency in /_error #17301

Fix css dependency in /_error #17301

Conversation

TasukuUno commented Sep 23, 2020

ijjk commented Sep 23, 2020

Stats from current PR

lfades left a comment

Choose a reason for hiding this comment

TasukuUno commented Sep 24, 2020

ijjk commented Sep 24, 2020

Stats from current PR

TasukuUno commented Sep 29, 2020

ijjk commented Sep 29, 2020

Stats from current PR

ijjk commented Oct 5, 2020

Stats from current PR

TasukuUno commented Oct 5, 2020

ijjk commented Oct 7, 2020

Stats from current PR

TasukuUno commented Oct 7, 2020

ijjk commented Oct 9, 2020

Stats from current PR

TasukuUno commented Oct 9, 2020

timneutkens Oct 9, 2020

Choose a reason for hiding this comment

ijjk commented Oct 9, 2020

Stats from current PR

timneutkens left a comment

Choose a reason for hiding this comment

TasukuUno commented Oct 21, 2020

ijjk commented Oct 21, 2020

Stats from current PR

timneutkens left a comment

Choose a reason for hiding this comment

TasukuUno commented Oct 21, 2020

timneutkens commented Oct 21, 2020

timneutkens commented Oct 21, 2020