Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add absolute import example #17342

Merged
merged 5 commits into from Oct 27, 2020
Merged

Add absolute import example #17342

merged 5 commits into from Oct 27, 2020

Conversation

samrobbins85
Copy link
Contributor

Might be easier for some users to see a whole app set up with it

@ijjk
Copy link
Member

ijjk commented Sep 24, 2020

Stats from current PR

Default Server Mode
General
vercel/next.js canary samrobbins85/next.js patch-3 Change
buildDuration 13.1s 12.9s -182ms
nodeModulesSize 62.9 MB 62.9 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary samrobbins85/next.js patch-3 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.326 2.36 ⚠️ +0.03
/ avg req/sec 1074.62 1059.41 ⚠️ -15.21
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.289 1.279 -0.01
/error-in-render avg req/sec 1939.31 1955.25 +15.94
Client Bundles (main, webpack, commons)
vercel/next.js canary samrobbins85/next.js patch-3 Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ae38113..ffac.js gzip 7.16 kB 7.16 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.8 kB 57.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary samrobbins85/next.js patch-3 Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-8f43483..dule.js gzip 6.23 kB 6.23 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary samrobbins85/next.js patch-3 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary samrobbins85/next.js patch-3 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary samrobbins85/next.js patch-3 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary samrobbins85/next.js patch-3 Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary samrobbins85/next.js patch-3 Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 996 B 996 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode
General
vercel/next.js canary samrobbins85/next.js patch-3 Change
buildDuration 14.5s 14.6s ⚠️ +140ms
nodeModulesSize 62.9 MB 62.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary samrobbins85/next.js patch-3 Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ae38113..ffac.js gzip 7.16 kB 7.16 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.8 kB 57.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary samrobbins85/next.js patch-3 Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-8f43483..dule.js gzip 6.23 kB 6.23 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary samrobbins85/next.js patch-3 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary samrobbins85/next.js patch-3 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary samrobbins85/next.js patch-3 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary samrobbins85/next.js patch-3 Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary samrobbins85/next.js patch-3 Change
_error.js 1.06 MB 1.06 MB ✓
404.html 4.34 kB 4.34 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.06 MB 1.06 MB ✓
link.js 1.1 MB 1.1 MB ✓
routerDirect.js 1.1 MB 1.1 MB ✓
withRouter.js 1.1 MB 1.1 MB ✓
Overall change 5.41 MB 5.41 MB ✓
Commit: f00eee8

lfades
lfades previously approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 💯

timneutkens
timneutkens requested changes Oct 14, 2020
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the linting, then we'll merge

@ijjk
Copy link
Member

ijjk commented Oct 14, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary samrobbins85/next.js patch-3 Change
buildDuration 12.9s 12.8s -26ms
nodeModulesSize 63.4 MB 63.4 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary samrobbins85/next.js patch-3 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.515 2.485 -0.03
/ avg req/sec 994.02 1005.86 +11.84
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.54 1.566 ⚠️ +0.03
/error-in-render avg req/sec 1623.53 1596.63 ⚠️ -26.9
Client Bundles (main, webpack, commons)
vercel/next.js canary samrobbins85/next.js patch-3 Change
677f882d2ed8..133b.js gzip 11.1 kB 11.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-3c4b8c3..826a.js gzip 7.29 kB 7.29 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.1 kB 58.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary samrobbins85/next.js patch-3 Change
677f882d2ed8..dule.js gzip 6.9 kB 6.9 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-2695ee4..dule.js gzip 6.29 kB 6.29 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.9 kB 52.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary samrobbins85/next.js patch-3 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary samrobbins85/next.js patch-3 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-409b283..e3ab.js gzip 1.32 kB 1.32 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.73 kB 7.73 kB ✓
Client Pages Modern
vercel/next.js canary samrobbins85/next.js patch-3 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-92d3016..dule.js gzip 1.28 kB 1.28 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary samrobbins85/next.js patch-3 Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary samrobbins85/next.js patch-3 Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 996 B 996 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode
General
vercel/next.js canary samrobbins85/next.js patch-3 Change
buildDuration 14.5s 14.6s ⚠️ +101ms
nodeModulesSize 63.4 MB 63.4 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary samrobbins85/next.js patch-3 Change
677f882d2ed8..133b.js gzip 11.1 kB 11.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-3c4b8c3..826a.js gzip 7.29 kB 7.29 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.1 kB 58.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary samrobbins85/next.js patch-3 Change
677f882d2ed8..dule.js gzip 6.9 kB 6.9 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-2695ee4..dule.js gzip 6.29 kB 6.29 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.9 kB 52.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary samrobbins85/next.js patch-3 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary samrobbins85/next.js patch-3 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-409b283..e3ab.js gzip 1.32 kB 1.32 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.73 kB 7.73 kB ✓
Client Pages Modern
vercel/next.js canary samrobbins85/next.js patch-3 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-92d3016..dule.js gzip 1.28 kB 1.28 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary samrobbins85/next.js patch-3 Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary samrobbins85/next.js patch-3 Change
_error.js 1.06 MB 1.06 MB ✓
404.html 4.34 kB 4.34 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.06 MB 1.06 MB ✓
link.js 1.1 MB 1.1 MB ✓
routerDirect.js 1.1 MB 1.1 MB ✓
withRouter.js 1.1 MB 1.1 MB ✓
Overall change 5.41 MB 5.41 MB ✓
Commit: 69b146e

@samrobbins85
Copy link
Contributor Author

samrobbins85 commented Oct 14, 2020 •
edited

I tried to work on this locally to figure out the error, but running npm install fails at the stage lerna run prepublish. I tried this on two different computers with the same error, and tried on both the canary branch and the branch for the PR with the same error. Is this a known error or am I doing something wrong?

It also didn't give any additional logging beyond that it failed with error code 2

timneutkens
timneutkens approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed the linting for you 👍

@samrobbins85
Copy link
Contributor Author

Thanks! Sorry I didn't spot that

@ijjk
Copy link
Member

ijjk commented Oct 27, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary samrobbins85/next.js patch-3 Change
buildDuration 12.6s 12.4s -204ms
nodeModulesSize 91.3 MB 91.3 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary samrobbins85/next.js patch-3 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.389 2.344 -0.04
/ avg req/sec 1046.35 1066.35 +20
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.273 1.247 -0.03
/error-in-render avg req/sec 1964.51 2004.96 +40.45
Client Bundles (main, webpack, commons)
vercel/next.js canary samrobbins85/next.js patch-3 Change
677f882d2ed8..d3ae.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-2927f4e..281e.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary samrobbins85/next.js patch-3 Change
677f882d2ed8..dule.js gzip 7.01 kB 7.01 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-1382a2d..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary samrobbins85/next.js patch-3 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary samrobbins85/next.js patch-3 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary samrobbins85/next.js patch-3 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary samrobbins85/next.js patch-3 Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary samrobbins85/next.js patch-3 Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 994 B 994 B ✓
Overall change 3 kB 3 kB ✓
Serverless Mode
General
vercel/next.js canary samrobbins85/next.js patch-3 Change
buildDuration 14.3s 14.2s -173ms
nodeModulesSize 91.3 MB 91.3 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary samrobbins85/next.js patch-3 Change
677f882d2ed8..d3ae.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-2927f4e..281e.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary samrobbins85/next.js patch-3 Change
677f882d2ed8..dule.js gzip 7.01 kB 7.01 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-1382a2d..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary samrobbins85/next.js patch-3 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary samrobbins85/next.js patch-3 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary samrobbins85/next.js patch-3 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary samrobbins85/next.js patch-3 Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary samrobbins85/next.js patch-3 Change
_error.js 1.06 MB 1.06 MB ✓
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.06 MB 1.06 MB ✓
link.js 1.11 MB 1.11 MB ✓
routerDirect.js 1.1 MB 1.1 MB ✓
withRouter.js 1.1 MB 1.1 MB ✓
Overall change 5.43 MB 5.43 MB ✓
Commit: c0685cf

@ijjk
Copy link
Member

ijjk commented Oct 27, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary samrobbins85/next.js patch-3 Change
buildDuration 12.9s 12.6s -233ms
nodeModulesSize 91.3 MB 91.3 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary samrobbins85/next.js patch-3 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.362 2.355 -0.01
/ avg req/sec 1058.35 1061.51 +3.16
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.298 1.296 0
/error-in-render avg req/sec 1926.27 1928.39 +2.12
Client Bundles (main, webpack, commons)
vercel/next.js canary samrobbins85/next.js patch-3 Change
677f882d2ed8..d3ae.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-2927f4e..281e.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary samrobbins85/next.js patch-3 Change
677f882d2ed8..dule.js gzip 7.01 kB 7.01 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-1382a2d..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary samrobbins85/next.js patch-3 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary samrobbins85/next.js patch-3 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary samrobbins85/next.js patch-3 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary samrobbins85/next.js patch-3 Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary samrobbins85/next.js patch-3 Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 994 B 994 B ✓
Overall change 3 kB 3 kB ✓
Serverless Mode
General
vercel/next.js canary samrobbins85/next.js patch-3 Change
buildDuration 14.7s 14.3s -359ms
nodeModulesSize 91.3 MB 91.3 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary samrobbins85/next.js patch-3 Change
677f882d2ed8..d3ae.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-2927f4e..281e.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary samrobbins85/next.js patch-3 Change
677f882d2ed8..dule.js gzip 7.01 kB 7.01 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-1382a2d..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary samrobbins85/next.js patch-3 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary samrobbins85/next.js patch-3 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary samrobbins85/next.js patch-3 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary samrobbins85/next.js patch-3 Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary samrobbins85/next.js patch-3 Change
_error.js 1.06 MB 1.06 MB ✓
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.06 MB 1.06 MB ✓
link.js 1.11 MB 1.11 MB ✓
routerDirect.js 1.1 MB 1.1 MB ✓
withRouter.js 1.1 MB 1.1 MB ✓
Overall change 5.43 MB 5.43 MB ✓
Commit: be7b60a

@kodiakhq kodiakhq bot merged commit 046deab into vercel:canary Oct 27, 2020
@samrobbins85 samrobbins85 deleted the patch-3 branch October 27, 2020 08:27
This was referenced Oct 28, 2020
Open
Open
Open
@elad165 elad165 mentioned this pull request Feb 9, 2021
Open
This was referenced Mar 7, 2021
Open
Open
@Jcrowell74 Jcrowell74 mentioned this pull request Mar 7, 2021
Open
This was referenced Sep 17, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 12, 2022
Closed
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Jan 23, 2022
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@lfades lfades lfades left review comments

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@samrobbins85 @ijjk @lfades @timneutkens @Timer