Updated dependencies for example: with-react-native-web #17375

orYoffe · 2020-09-26T09:27:47Z

The current dependencies of the example "with-react-native-web" are outdated.
In this PR I updated them and tested that they run and work.

Newest current react and react-dom versions: 16.13.1
Newest current react-native-web and babel-plugin-react-native-web versions: 0.13.14

Mainly for the people starting with this example to have the new versions since the current versions are very far from each other.
Please merge 🙏

ijjk · 2020-09-26T09:35:23Z

Failing test suites

Commit: 0c6e6f0

test/integration/create-next-app/index.test.js

create next app > valid example
create next app > should allow example with GitHub URL
create next app > should allow example with GitHub URL and example-path
create next app > should use --example-path over the file path in the GitHub URL

Expand output

● create next app › valid example

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js valid-example --example basic-css

  90 |     await usingTempDir(async (cwd) => {
  91 |       const projectName = 'valid-example'
> 92 |       const res = await run(cwd, projectName, '--example', 'basic-css')
     |                   ^
  93 |       expect(res.exitCode).toBe(0)
  94 | 
  95 |       expect(

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:92:19
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:90:5)

● create next app › should allow example with GitHub URL

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js github-app --example https://github.com/zeit/next-learn-demo/tree/master/1-navigate-between-pages

  109 |     await usingTempDir(async (cwd) => {
  110 |       const projectName = 'github-app'
> 111 |       const res = await run(
      |                   ^
  112 |         cwd,
  113 |         projectName,
  114 |         '--example',

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:111:19
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:109:5)

● create next app › should allow example with GitHub URL and example-path

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js github-example-path --example https://github.com/zeit/next-learn-demo/tree/master --example-path 1-navigate-between-pages

  135 |     await usingTempDir(async (cwd) => {
  136 |       const projectName = 'github-example-path'
> 137 |       const res = await run(
      |                   ^
  138 |         cwd,
  139 |         projectName,
  140 |         '--example',

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:137:19
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:135:5)

● create next app › should use --example-path over the file path in the GitHub URL

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js github-example-path-2 --example https://github.com/zeit/next-learn-demo/tree/master/1-navigate-between-pages --example-path 1-navigate-between-pages

  163 |     await usingTempDir(async (cwd) => {
  164 |       const projectName = 'github-example-path-2'
> 165 |       const res = await run(
      |                   ^
  166 |         cwd,
  167 |         projectName,
  168 |         '--example',

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:165:19
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:163:5)

ijjk · 2020-09-26T09:38:13Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
buildDuration	13.5s	13.2s	-267ms
nodeModulesSize	62.9 MB	62.9 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.522	2.518	0
/ avg req/sec	991.08	992.72	+1.64
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.527	1.522	0
/error-in-render avg req/sec	1636.91	1642.32	+5.41

Client Bundles (main, webpack, commons)

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e3dd5fc..bc67.js gzip	7.16 kB	7.16 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-f4d7a25..dule.js gzip	6.23 kB	6.23 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
buildDuration	14.9s	15.1s	⚠️ +117ms
nodeModulesSize	62.9 MB	62.9 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e3dd5fc..bc67.js gzip	7.16 kB	7.16 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-f4d7a25..dule.js gzip	6.23 kB	6.23 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
_error.js	1.05 MB	1.05 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.05 MB	1.05 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.09 MB	1.09 MB	✓
withRouter.js	1.09 MB	1.09 MB	✓
Overall change	5.4 MB	5.4 MB	✓

Commit: 0c6e6f0

orYoffe · 2020-09-26T10:31:13Z

@ijjk
I didn't change any code that would effect any tests. I don't know how this is related to my PR.
Some info about the tests would help as I looked and my changes shouldn't effect those tests.

lfades

LGTM. Thank you!

…ve-web

ijjk · 2020-10-18T17:45:46Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
buildDuration	12.7s	12.6s	-19ms
nodeModulesSize	64.4 MB	64.4 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.349	2.344	-0.01
/ avg req/sec	1064.23	1066.42	+2.19
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.316	1.349	⚠️ +0.03
/error-in-render avg req/sec	1900.04	1853.66	⚠️ -46.38

Client Bundles (main, webpack, commons)

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
677f882d2ed8..7765.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-5aa1543..4e79.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.1 kB	58.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
677f882d2ed8..dule.js gzip	6.94 kB	6.94 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-7d849dd..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53 kB	53 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-89ad9e7..25bb.js gzip	1.34 kB	1.34 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.74 kB	7.74 kB	✓

Client Pages Modern

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-aeb707b..dule.js gzip	1.29 kB	1.29 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.39 kB	5.39 kB	✓

Client Build Manifests

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
buildDuration	12.6s	14.7s	⚠️ +2.1s
nodeModulesSize	64.4 MB	64.4 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
677f882d2ed8..7765.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-5aa1543..4e79.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.1 kB	58.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
677f882d2ed8..dule.js gzip	6.94 kB	6.94 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-7d849dd..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53 kB	53 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-89ad9e7..25bb.js gzip	1.34 kB	1.34 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.74 kB	7.74 kB	✓

Client Pages Modern

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-aeb707b..dule.js gzip	1.29 kB	1.29 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.39 kB	5.39 kB	✓

Client Build Manifests

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	orYoffe/next.js updating-versions-examples/with-react-native-web	Change
_error.js	1.06 MB	1.06 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.1 MB	1.1 MB	✓
withRouter.js	1.1 MB	1.1 MB	✓
Overall change	5.42 MB	5.42 MB	✓

Commit: 985589b

updated dependencies for examples/with-react-native-web

0c6e6f0

orYoffe requested review from chibicode, ijjk, lfades, Timer and timneutkens as code owners September 26, 2020 09:27

ijjk added the example bug Issue was opened via the example bug report template. label Sep 26, 2020

lfades approved these changes Sep 26, 2020

View reviewed changes

timneutkens and others added 2 commits October 14, 2020 11:57

Merge branch 'canary' into updating-versions-examples/with-react-nati…

4224076

…ve-web

Merge branch 'canary' into updating-versions-examples/with-react-nati…

985589b

…ve-web

kodiakhq bot merged commit 68c62b3 into vercel:canary Oct 18, 2020

ijjk added the hacktoberfest-accepted label Oct 20, 2020

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated dependencies for example: with-react-native-web #17375

Updated dependencies for example: with-react-native-web #17375

orYoffe commented Sep 26, 2020

ijjk commented Sep 26, 2020

ijjk commented Sep 26, 2020

orYoffe commented Sep 26, 2020

lfades left a comment

ijjk commented Oct 18, 2020

Updated dependencies for example: with-react-native-web #17375

Updated dependencies for example: with-react-native-web #17375

Conversation

orYoffe commented Sep 26, 2020

ijjk commented Sep 26, 2020

Failing test suites

ijjk commented Sep 26, 2020

Stats from current PR

orYoffe commented Sep 26, 2020

lfades left a comment

Choose a reason for hiding this comment

ijjk commented Oct 18, 2020

Stats from current PR