Make sure that params are properly passed to hybrid amp pages #17461

slawekkolodziej · 2020-09-30T00:31:26Z

I recently tried to upgrade from 9.4.x to 9.5.x and noticed a regression bug that wasn't properly covered with tests.

Basically, in 9.5 page params are not properly passed to SSG AMP pages while building for serverless target (right now the context.params in getStaticProps is always set to {amp: '1'}). I've updated tests to cover route params, added a fix and it seems that the problem is solved now.

I'm not sure about the 4th parameter passed to renderMethod (I kept it as undefined, but maybe it should be something else too?)

This PR closes #17245

ijjk · 2020-09-30T00:40:48Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
buildDuration	11.6s	11.7s	⚠️ +117ms
nodeModulesSize	62.9 MB	62.9 MB	⚠️ +63 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.186	2.049	-0.14
/ avg req/sec	1143.63	1220.38	+76.75
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.142	1.112	-0.03
/error-in-render avg req/sec	2189.12	2248.83	+59.71

Client Bundles (main, webpack, commons)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-d493e7d..42f5.js gzip	7.17 kB	7.17 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-f8905d4..dule.js gzip	6.24 kB	6.24 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
buildDuration	12.8s	13.3s	⚠️ +530ms
nodeModulesSize	62.9 MB	62.9 MB	⚠️ +63 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-d493e7d..42f5.js gzip	7.17 kB	7.17 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-f8905d4..dule.js gzip	6.24 kB	6.24 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_error.js	1.05 MB	1.05 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.05 MB	1.05 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.09 MB	1.09 MB	✓
withRouter.js	1.09 MB	1.09 MB	✓
Overall change	5.4 MB	5.4 MB	✓

Commit: d941405

ijjk · 2020-10-12T12:36:02Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
buildDuration	13.7s	13.2s	-504ms
nodeModulesSize	63.4 MB	63.4 MB	⚠️ +63 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.555	2.58	⚠️ +0.02
/ avg req/sec	978.37	968.91	⚠️ -9.46
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.555	1.585	⚠️ +0.03
/error-in-render avg req/sec	1607.41	1577.33	⚠️ -30.08

Client Bundles (main, webpack, commons)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..133b.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-2540b2f..aa10.js gzip	7.22 kB	7.22 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58 kB	58 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..dule.js gzip	6.9 kB	6.9 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-0d1e0b8..dule.js gzip	6.28 kB	6.28 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-409b283..e3ab.js gzip	1.32 kB	1.32 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.73 kB	7.73 kB	✓

Client Pages Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-92d3016..dule.js gzip	1.28 kB	1.28 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
buildDuration	14.5s	15.5s	⚠️ +1s
nodeModulesSize	63.4 MB	63.4 MB	⚠️ +63 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..133b.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-2540b2f..aa10.js gzip	7.22 kB	7.22 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58 kB	58 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..dule.js gzip	6.9 kB	6.9 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-0d1e0b8..dule.js gzip	6.28 kB	6.28 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-409b283..e3ab.js gzip	1.32 kB	1.32 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.73 kB	7.73 kB	✓

Client Pages Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-92d3016..dule.js gzip	1.28 kB	1.28 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_error.js	1.05 MB	1.05 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.05 MB	1.05 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.09 MB	1.09 MB	✓
withRouter.js	1.09 MB	1.09 MB	✓
Overall change	5.41 MB	5.41 MB	✓

Commit: 633ae3c

ijjk · 2020-10-12T12:43:14Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
buildDuration	12.6s	12.7s	⚠️ +27ms
nodeModulesSize	63.4 MB	63.4 MB	⚠️ +63 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.302	2.291	-0.01
/ avg req/sec	1085.78	1091.27	+5.49
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.256	1.266	⚠️ +0.01
/error-in-render avg req/sec	1990.16	1975.33	⚠️ -14.83

Client Bundles (main, webpack, commons)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..133b.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-2540b2f..aa10.js gzip	7.22 kB	7.22 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58 kB	58 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..dule.js gzip	6.9 kB	6.9 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-0d1e0b8..dule.js gzip	6.28 kB	6.28 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-409b283..e3ab.js gzip	1.32 kB	1.32 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.73 kB	7.73 kB	✓

Client Pages Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-92d3016..dule.js gzip	1.28 kB	1.28 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
buildDuration	14s	14.3s	⚠️ +252ms
nodeModulesSize	63.4 MB	63.4 MB	⚠️ +63 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..133b.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-2540b2f..aa10.js gzip	7.22 kB	7.22 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58 kB	58 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..dule.js gzip	6.9 kB	6.9 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-0d1e0b8..dule.js gzip	6.28 kB	6.28 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-409b283..e3ab.js gzip	1.32 kB	1.32 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.73 kB	7.73 kB	✓

Client Pages Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-92d3016..dule.js gzip	1.28 kB	1.28 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_error.js	1.05 MB	1.05 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.05 MB	1.05 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.09 MB	1.09 MB	✓
withRouter.js	1.09 MB	1.09 MB	✓
Overall change	5.41 MB	5.41 MB	✓

Commit: 5cc92d1

slawekkolodziej · 2020-10-12T12:47:45Z

I rebased the branch on top of the canary. I can confirm that the issue is still present in 9.5.5, and my fix still makes solves the problem.

ijjk · 2020-10-12T13:12:34Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
buildDuration	12.6s	12.5s	-78ms
nodeModulesSize	63.4 MB	63.4 MB	⚠️ +75 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.367	2.289	-0.08
/ avg req/sec	1056.07	1091.96	+35.89
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.239	1.213	-0.03
/error-in-render avg req/sec	2018.56	2061.29	+42.73

Client Bundles (main, webpack, commons)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..133b.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-2540b2f..aa10.js gzip	7.22 kB	7.22 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58 kB	58 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..dule.js gzip	6.9 kB	6.9 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-0d1e0b8..dule.js gzip	6.28 kB	6.28 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-409b283..e3ab.js gzip	1.32 kB	1.32 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.73 kB	7.73 kB	✓

Client Pages Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-92d3016..dule.js gzip	1.28 kB	1.28 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
buildDuration	13.7s	13.9s	⚠️ +188ms
nodeModulesSize	63.4 MB	63.4 MB	⚠️ +75 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..133b.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-2540b2f..aa10.js gzip	7.22 kB	7.22 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58 kB	58 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..dule.js gzip	6.9 kB	6.9 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-0d1e0b8..dule.js gzip	6.28 kB	6.28 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-409b283..e3ab.js gzip	1.32 kB	1.32 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.73 kB	7.73 kB	✓

Client Pages Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-92d3016..dule.js gzip	1.28 kB	1.28 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_error.js	1.05 MB	1.05 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.05 MB	1.05 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.09 MB	1.09 MB	✓
withRouter.js	1.09 MB	1.09 MB	✓
Overall change	5.41 MB	5.41 MB	✓

Commit: ac3af0c

ijjk · 2020-10-12T17:32:28Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
buildDuration	14.3s	13.2s	-1.1s
nodeModulesSize	63.4 MB	63.4 MB	⚠️ +75 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.682	2.659	-0.02
/ avg req/sec	931.98	940.3	+8.32
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.595	1.527	-0.07
/error-in-render avg req/sec	1567.14	1636.66	+69.52

Client Bundles (main, webpack, commons)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..133b.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-2540b2f..aa10.js gzip	7.22 kB	7.22 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58 kB	58 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..dule.js gzip	6.9 kB	6.9 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-0d1e0b8..dule.js gzip	6.28 kB	6.28 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-409b283..e3ab.js gzip	1.32 kB	1.32 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.73 kB	7.73 kB	✓

Client Pages Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-92d3016..dule.js gzip	1.28 kB	1.28 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
buildDuration	14.7s	15s	⚠️ +267ms
nodeModulesSize	63.4 MB	63.4 MB	⚠️ +75 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..133b.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-2540b2f..aa10.js gzip	7.22 kB	7.22 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58 kB	58 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..dule.js gzip	6.9 kB	6.9 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-0d1e0b8..dule.js gzip	6.28 kB	6.28 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-409b283..e3ab.js gzip	1.32 kB	1.32 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.73 kB	7.73 kB	✓

Client Pages Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-92d3016..dule.js gzip	1.28 kB	1.28 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_error.js	1.05 MB	1.05 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.05 MB	1.05 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.09 MB	1.09 MB	✓
withRouter.js	1.09 MB	1.09 MB	✓
Overall change	5.41 MB	5.41 MB	✓

Commit: 94965a2

slawekkolodziej · 2020-10-13T07:22:21Z

FYI: I just noticed that there is an issue report for this bug: #17245

ijjk · 2020-10-13T07:34:20Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
buildDuration	13.5s	14s	⚠️ +492ms
nodeModulesSize	63.4 MB	63.4 MB	⚠️ +75 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.617	2.629	⚠️ +0.01
/ avg req/sec	955.27	950.94	⚠️ -4.33
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.551	1.59	⚠️ +0.04
/error-in-render avg req/sec	1611.96	1572.42	⚠️ -39.54

Client Bundles (main, webpack, commons)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..133b.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-2540b2f..aa10.js gzip	7.22 kB	7.22 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58 kB	58 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..dule.js gzip	6.9 kB	6.9 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-0d1e0b8..dule.js gzip	6.28 kB	6.28 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-409b283..e3ab.js gzip	1.32 kB	1.32 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.73 kB	7.73 kB	✓

Client Pages Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-92d3016..dule.js gzip	1.28 kB	1.28 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
buildDuration	15.4s	15.2s	-143ms
nodeModulesSize	63.4 MB	63.4 MB	⚠️ +75 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..133b.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-2540b2f..aa10.js gzip	7.22 kB	7.22 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58 kB	58 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..dule.js gzip	6.9 kB	6.9 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-0d1e0b8..dule.js gzip	6.28 kB	6.28 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-409b283..e3ab.js gzip	1.32 kB	1.32 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.73 kB	7.73 kB	✓

Client Pages Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-92d3016..dule.js gzip	1.28 kB	1.28 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_error.js	1.05 MB	1.05 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.05 MB	1.05 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.09 MB	1.09 MB	✓
withRouter.js	1.09 MB	1.09 MB	✓
Overall change	5.41 MB	5.41 MB	✓

Commit: 93bc65e

lfades · 2020-10-13T18:58:04Z

@slawekkolodziej If that's the fix feel free to update the description so it closes the issue once the PR is merged 👍

slawekkolodziej · 2020-10-13T22:25:10Z

@lfades done!

ijjk · 2020-10-13T22:35:34Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
buildDuration	12.9s	12.8s	-35ms
nodeModulesSize	63.4 MB	63.4 MB	⚠️ +75 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.388	2.381	-0.01
/ avg req/sec	1046.85	1049.98	+3.13
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.304	1.285	-0.02
/error-in-render avg req/sec	1917.65	1945.74	+28.09

Client Bundles (main, webpack, commons)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..133b.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-2540b2f..aa10.js gzip	7.22 kB	7.22 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58 kB	58 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..dule.js gzip	6.9 kB	6.9 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-0d1e0b8..dule.js gzip	6.28 kB	6.28 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-409b283..e3ab.js gzip	1.32 kB	1.32 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.73 kB	7.73 kB	✓

Client Pages Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-92d3016..dule.js gzip	1.28 kB	1.28 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
buildDuration	14.7s	14.3s	-333ms
nodeModulesSize	63.4 MB	63.4 MB	⚠️ +75 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..133b.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-2540b2f..aa10.js gzip	7.22 kB	7.22 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58 kB	58 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..dule.js gzip	6.9 kB	6.9 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-0d1e0b8..dule.js gzip	6.28 kB	6.28 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-409b283..e3ab.js gzip	1.32 kB	1.32 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.73 kB	7.73 kB	✓

Client Pages Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-92d3016..dule.js gzip	1.28 kB	1.28 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_error.js	1.05 MB	1.05 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.05 MB	1.05 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.09 MB	1.09 MB	✓
withRouter.js	1.09 MB	1.09 MB	✓
Overall change	5.41 MB	5.41 MB	✓

Commit: e313a1f

ijjk · 2020-10-14T17:47:20Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
buildDuration	12.7s	12.7s	⚠️ +8ms
nodeModulesSize	63.4 MB	63.4 MB	⚠️ +75 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.329	2.329	✓
/ avg req/sec	1073.63	1073.41	⚠️ -0.22
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.289	1.269	-0.02
/error-in-render avg req/sec	1939.98	1969.37	+29.39

Client Bundles (main, webpack, commons)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..133b.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3fae807..efe0.js gzip	7.3 kB	7.3 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.1 kB	58.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..dule.js gzip	6.9 kB	6.9 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-8ac5189..dule.js gzip	6.29 kB	6.29 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-409b283..e3ab.js gzip	1.32 kB	1.32 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.73 kB	7.73 kB	✓

Client Pages Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-92d3016..dule.js gzip	1.28 kB	1.28 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	995 B	995 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
buildDuration	14.4s	14.3s	-134ms
nodeModulesSize	63.4 MB	63.4 MB	⚠️ +75 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..133b.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3fae807..efe0.js gzip	7.3 kB	7.3 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.1 kB	58.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..dule.js gzip	6.9 kB	6.9 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-8ac5189..dule.js gzip	6.29 kB	6.29 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-409b283..e3ab.js gzip	1.32 kB	1.32 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.73 kB	7.73 kB	✓

Client Pages Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-92d3016..dule.js gzip	1.28 kB	1.28 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_error.js	1.06 MB	1.06 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.1 MB	1.1 MB	✓
withRouter.js	1.1 MB	1.1 MB	✓
Overall change	5.41 MB	5.41 MB	✓

Commit: d575cc0

test/integration/amphtml-ssg/pages/blog/[slug].js

Co-authored-by: Tim Neutkens <tim@timneutkens.nl>

ijjk · 2020-10-15T12:24:12Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
buildDuration	13.2s	13.2s	-44ms
nodeModulesSize	64.3 MB	64.3 MB	⚠️ +75 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.619	2.584	-0.04
/ avg req/sec	954.4	967.41	+13.01
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.605	1.538	-0.07
/error-in-render avg req/sec	1557.18	1625.01	+67.83

Client Bundles (main, webpack, commons)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..0989.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3fae807..efe0.js gzip	7.3 kB	7.3 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.1 kB	58.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..dule.js gzip	6.91 kB	6.91 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-8ac5189..dule.js gzip	6.29 kB	6.29 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-89ad9e7..25bb.js gzip	1.34 kB	1.34 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.74 kB	7.74 kB	✓

Client Pages Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-aeb707b..dule.js gzip	1.29 kB	1.29 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.39 kB	5.39 kB	✓

Client Build Manifests

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
buildDuration	15.9s	15.2s	-642ms
nodeModulesSize	64.3 MB	64.3 MB	⚠️ +75 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..0989.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3fae807..efe0.js gzip	7.3 kB	7.3 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.1 kB	58.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
677f882d2ed8..dule.js gzip	6.91 kB	6.91 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-8ac5189..dule.js gzip	6.29 kB	6.29 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-89ad9e7..25bb.js gzip	1.34 kB	1.34 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.74 kB	7.74 kB	✓

Client Pages Modern

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-aeb707b..dule.js gzip	1.29 kB	1.29 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.39 kB	5.39 kB	✓

Client Build Manifests

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	slawekkolodziej/next.js get-static-props-amp-fix	Change
_error.js	1.06 MB	1.06 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.1 MB	1.1 MB	✓
withRouter.js	1.1 MB	1.1 MB	✓
Overall change	5.41 MB	5.41 MB	✓

Commit: e918e24

timneutkens

Overall it looks good. Pending a review from @ijjk 👍

ijjk · 2020-10-15T13:44:31Z

packages/next/export/worker.ts

@@ -352,7 +352,8 @@ export default async function exportPage({
        if (serverless) {
          req.url += (req.url!.includes('?') ? '&' : '?') + 'amp=1'
          // @ts-ignore
-          ampHtml = (await renderMethod(req, res, 'export')).html
+          ampHtml = (await renderMethod(req, res, 'export', undefined, params))


The fourth parameter here should match this line, this can be updated in a follow-up PR as it addresses different cases. Good catch!

PR updating this here #17923

ijjk

Updated tests and patch look good to me 👍

slawekkolodziej requested review from ijjk, lfades, Timer and timneutkens as code owners September 30, 2020 00:31

ijjk added the type: next label Sep 30, 2020

slawekkolodziej changed the title ~~Test that params are properly passed to hybrid amp pages~~ Make sure that params are properly passed to hybrid amp pages Sep 30, 2020

slawekkolodziej force-pushed the get-static-props-amp-fix branch from d941405 to 633ae3c Compare October 12, 2020 12:25

Test that params are properly passed to hybrid amp pages

5cc92d1

slawekkolodziej force-pushed the get-static-props-amp-fix branch from 633ae3c to 5cc92d1 Compare October 12, 2020 12:33

Code-style fixes

ac3af0c

Merge branch 'canary' into get-static-props-amp-fix

94965a2

slawekkolodziej mentioned this pull request Oct 13, 2020

AMP hybrid mode is missing required dynamic route query pameters #17245

Closed

Merge branch 'canary' into get-static-props-amp-fix

93bc65e

Merge branch 'canary' into get-static-props-amp-fix

e313a1f

Merge branch 'canary' into get-static-props-amp-fix

d575cc0

timneutkens reviewed Oct 15, 2020

View reviewed changes

test/integration/amphtml-ssg/pages/blog/[slug].js Outdated Show resolved Hide resolved

slawekkolodziej and others added 2 commits October 15, 2020 13:11

Update test/integration/amphtml-ssg/pages/blog/[slug].js

67da0a1

Co-authored-by: Tim Neutkens <tim@timneutkens.nl>

Merge branch 'canary' into get-static-props-amp-fix

e918e24

timneutkens reviewed Oct 15, 2020

View reviewed changes

ijjk reviewed Oct 15, 2020

View reviewed changes

ijjk approved these changes Oct 15, 2020

View reviewed changes

Merge branch 'canary' into get-static-props-amp-fix

cd207bd

timneutkens merged commit 4238878 into vercel:canary Oct 15, 2020

ijjk added the hacktoberfest-accepted label Oct 15, 2020

ijjk mentioned this pull request Oct 15, 2020

Ensure i18n support with AMP #17923

Merged

filipposarzana mentioned this pull request Oct 16, 2020

getStaticProps incompatible with hybrid AMP dynamic routes #17935

Closed

yassinebridi mentioned this pull request Oct 22, 2020

Hybrid Index Amp pages always shows the amp version in production. #14096

Closed

tomaszrondio mentioned this pull request Oct 23, 2020

SSG AMP hybrid mode dynamic route adds "amp":1 to context on build in non AMP article.json #18128

Closed

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make sure that params are properly passed to hybrid amp pages #17461

Make sure that params are properly passed to hybrid amp pages #17461

slawekkolodziej commented Sep 30, 2020 •

edited

ijjk commented Sep 30, 2020

ijjk commented Oct 12, 2020

ijjk commented Oct 12, 2020

slawekkolodziej commented Oct 12, 2020

ijjk commented Oct 12, 2020

ijjk commented Oct 12, 2020

slawekkolodziej commented Oct 13, 2020 •

edited

ijjk commented Oct 13, 2020

lfades commented Oct 13, 2020

slawekkolodziej commented Oct 13, 2020

ijjk commented Oct 13, 2020

ijjk commented Oct 14, 2020

ijjk commented Oct 15, 2020

timneutkens left a comment

ijjk Oct 15, 2020 •

edited

ijjk left a comment

Make sure that params are properly passed to hybrid amp pages #17461

Make sure that params are properly passed to hybrid amp pages #17461

Conversation

slawekkolodziej commented Sep 30, 2020 • edited

ijjk commented Sep 30, 2020

Stats from current PR

ijjk commented Oct 12, 2020

Stats from current PR

ijjk commented Oct 12, 2020

Stats from current PR

slawekkolodziej commented Oct 12, 2020

ijjk commented Oct 12, 2020

Stats from current PR

ijjk commented Oct 12, 2020

Stats from current PR

slawekkolodziej commented Oct 13, 2020 • edited

ijjk commented Oct 13, 2020

Stats from current PR

lfades commented Oct 13, 2020

slawekkolodziej commented Oct 13, 2020

ijjk commented Oct 13, 2020

Stats from current PR

ijjk commented Oct 14, 2020

Stats from current PR

ijjk commented Oct 15, 2020

Stats from current PR

timneutkens left a comment

Choose a reason for hiding this comment

ijjk Oct 15, 2020 • edited

Choose a reason for hiding this comment

ijjk left a comment

Choose a reason for hiding this comment

slawekkolodziej commented Sep 30, 2020 •

edited

slawekkolodziej commented Oct 13, 2020 •

edited

ijjk Oct 15, 2020 •

edited