Add support for Image Optimizer #17749

styfle · 2020-10-09T15:18:47Z

This PR implements RFC 17141.

Below are the implementation details not described in the RFC:

Optimized images are cached to .next/cache/images/<HASH>/<EXPIRE>.<EXT>
TTL for cached images is 60 seconds unless the upstream image provides Cache-Control max-age greater than 60
If the images.sizes property in next.config.js is not defined, a default of [320, 420, 768, 1024, 1200] is used
If the images.domains property in next.config.js is not defined, only relative URLs can be optimized
- This limitation does not apply to next dev so that localhost, 127.0.0.1, etc can be used for development
- No pattern matching is performed, the exact domain must match

packages/next/next-server/server/image-optimizer.ts

ijjk · 2020-10-15T17:48:43Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
buildDuration	12.3s	12.7s	⚠️ +382ms
nodeModulesSize	64.3 MB	64.3 MB	⚠️ +28.6 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.28	2.41	⚠️ +0.13
/ avg req/sec	1096.48	1037.38	⚠️ -59.1
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.238	1.333	⚠️ +0.09
/error-in-render avg req/sec	2018.88	1875.12	⚠️ -143.76

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
677f882d2ed8..0989.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-cab8201..fb9c.js gzip	7.3 kB	7.3 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.1 kB	58.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
677f882d2ed8..dule.js gzip	6.91 kB	6.91 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-e62b7eb..dule.js gzip	6.29 kB	6.29 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-89ad9e7..25bb.js gzip	1.34 kB	1.34 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.74 kB	7.74 kB	✓

Client Pages Modern

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-aeb707b..dule.js gzip	1.29 kB	1.29 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.39 kB	5.39 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
buildDuration	14.2s	14.3s	⚠️ +48ms
nodeModulesSize	64.3 MB	64.3 MB	⚠️ +28.6 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
677f882d2ed8..0989.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-cab8201..fb9c.js gzip	7.3 kB	7.3 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.1 kB	58.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
677f882d2ed8..dule.js gzip	6.91 kB	6.91 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-e62b7eb..dule.js gzip	6.29 kB	6.29 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-89ad9e7..25bb.js gzip	1.34 kB	1.34 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.74 kB	7.74 kB	✓

Client Pages Modern

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-aeb707b..dule.js gzip	1.29 kB	1.29 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.39 kB	5.39 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
_error.js	1.06 MB	1.06 MB	⚠️ +117 B
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	⚠️ +117 B
link.js	1.1 MB	1.1 MB	⚠️ +117 B
routerDirect.js	1.1 MB	1.1 MB	⚠️ +117 B
withRouter.js	1.1 MB	1.1 MB	⚠️ +117 B
Overall change	5.41 MB	5.41 MB	⚠️ +585 B

Commit: 59a26c0

packages/next/next-server/server/config.ts

packages/next/next-server/server/image-optimizer.ts

ijjk · 2020-10-15T21:47:07Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
buildDuration	14.3s	13.8s	-447ms
nodeModulesSize	64.3 MB	64.3 MB	⚠️ +29.2 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.52	2.556	⚠️ +0.04
/ avg req/sec	992.21	978.09	⚠️ -14.12
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.604	1.405	-0.2
/error-in-render avg req/sec	1558.18	1779.66	+221.48

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
677f882d2ed8..0989.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-43e96dd..7c44.js gzip	7.3 kB	7.3 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.1 kB	58.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
677f882d2ed8..dule.js gzip	6.91 kB	6.91 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-ee66c17..dule.js gzip	6.29 kB	6.29 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-89ad9e7..25bb.js gzip	1.34 kB	1.34 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.74 kB	7.74 kB	✓

Client Pages Modern

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-aeb707b..dule.js gzip	1.29 kB	1.29 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.39 kB	5.39 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	995 B	995 B	✓
Overall change	3 kB	3 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
buildDuration	15.7s	15.8s	⚠️ +112ms
nodeModulesSize	64.3 MB	64.3 MB	⚠️ +29.2 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
677f882d2ed8..0989.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-43e96dd..7c44.js gzip	7.3 kB	7.3 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.1 kB	58.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
677f882d2ed8..dule.js gzip	6.91 kB	6.91 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-ee66c17..dule.js gzip	6.29 kB	6.29 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-89ad9e7..25bb.js gzip	1.34 kB	1.34 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.74 kB	7.74 kB	✓

Client Pages Modern

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-aeb707b..dule.js gzip	1.29 kB	1.29 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.39 kB	5.39 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
_error.js	1.06 MB	1.06 MB	⚠️ +117 B
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	⚠️ +117 B
link.js	1.1 MB	1.1 MB	⚠️ +117 B
routerDirect.js	1.1 MB	1.1 MB	⚠️ +117 B
withRouter.js	1.1 MB	1.1 MB	⚠️ +117 B
Overall change	5.41 MB	5.41 MB	⚠️ +585 B

Commit: b2e11f0

ijjk · 2020-10-15T22:54:21Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
buildDuration	12.3s	11.4s	-869ms
nodeModulesSize	64.3 MB	64.4 MB	⚠️ +29.2 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.352	2.282	-0.07
/ avg req/sec	1062.91	1095.33	+32.42
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.444	1.475	⚠️ +0.03
/error-in-render avg req/sec	1731.51	1694.98	⚠️ -36.53

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
677f882d2ed8..7765.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-43e96dd..7c44.js gzip	7.3 kB	7.3 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.1 kB	58.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
677f882d2ed8..dule.js gzip	6.94 kB	6.94 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-ee66c17..dule.js gzip	6.29 kB	6.29 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53 kB	53 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-89ad9e7..25bb.js gzip	1.34 kB	1.34 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.74 kB	7.74 kB	✓

Client Pages Modern

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-aeb707b..dule.js gzip	1.29 kB	1.29 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.39 kB	5.39 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	995 B	995 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
buildDuration	13.3s	13.7s	⚠️ +342ms
nodeModulesSize	64.3 MB	64.4 MB	⚠️ +29.2 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
677f882d2ed8..7765.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-43e96dd..7c44.js gzip	7.3 kB	7.3 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.1 kB	58.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
677f882d2ed8..dule.js gzip	6.94 kB	6.94 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-ee66c17..dule.js gzip	6.29 kB	6.29 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53 kB	53 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-89ad9e7..25bb.js gzip	1.34 kB	1.34 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.74 kB	7.74 kB	✓

Client Pages Modern

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-aeb707b..dule.js gzip	1.29 kB	1.29 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.39 kB	5.39 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	vercel/next.js rfc17141-next-image-api	Change
_error.js	1.06 MB	1.06 MB	⚠️ +117 B
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	⚠️ +117 B
link.js	1.1 MB	1.1 MB	⚠️ +117 B
routerDirect.js	1.1 MB	1.1 MB	⚠️ +117 B
withRouter.js	1.1 MB	1.1 MB	⚠️ +117 B
Overall change	5.41 MB	5.41 MB	⚠️ +585 B

Commit: c53aec6

packages/next/next-server/server/image-optimizer.ts

ijjk · 2020-10-15T22:58:32Z

Failing test suites

Commit: c53aec6

test/integration/size-limit/test/index.test.js

Production response size > should not increase the overall response size of default build

Expand output

● Production response size › should not increase the overall response size of default build

expect(received).toBeLessThanOrEqual(expected)

Expected: <= 1024
Received:    1045

  82 |     // These numbers are without gzip compression!
  83 |     const delta = responseSizesBytes - 280 * 1024
> 84 |     expect(delta).toBeLessThanOrEqual(1024) // don't increase size more than 1kb
     |                   ^
  85 |     expect(delta).toBeGreaterThanOrEqual(-1024) // don't decrease size more than 1kb without updating target
  86 |   })
  87 | 

  at Object.<anonymous> (integration/size-limit/test/index.test.js:84:19)

This PR sends the results of the image optimization config from next.config.js to the build output. x-ref: vercel/next.js#17749

This makes sure the image optimizer doesn't de-animate images by transforming them with sharp since sharp doesn't currently handle outputting animated images x-ref: #17749

This PR sends the results of the image optimization config from next.config.js to the build output. x-ref: vercel/next.js#17749

[image-optimizer] Initial commit

0d61e66

ijjk added the type: next label Oct 9, 2020

styfle changed the title ~~[image-optimizer] Initial commit~~ [wip] Image Optimizer Oct 9, 2020

This comment has been minimized.

Sign in to view

Fix several bugs

19c4680

This comment has been minimized.

Sign in to view

Fix relative urls

7920ad5

This comment has been minimized.

Sign in to view

styfle added 2 commits October 9, 2020 16:32

Add initial test fixture

b5ad58d

Add tests

689f7c1

styfle changed the title ~~[wip] Image Optimizer~~ Add support for Image Optimizer Oct 9, 2020

Add missing header

6d2c58d

timneutkens reviewed Oct 10, 2020

View reviewed changes

packages/next/next-server/server/image-optimizer.ts Outdated Show resolved Hide resolved

timneutkens reviewed Oct 10, 2020

View reviewed changes

packages/next/next-server/server/image-optimizer.ts Outdated Show resolved Hide resolved

timneutkens reviewed Oct 10, 2020

View reviewed changes

packages/next/next-server/server/image-optimizer.ts Outdated Show resolved Hide resolved

styfle added 2 commits October 10, 2020 09:53

Update per review comments

3257808

Merge branch 'canary' into rfc17141-next-image-api

b5e258d

styfle marked this pull request as ready for review October 10, 2020 14:10

styfle requested review from ijjk, lfades and Timer as code owners October 10, 2020 14:10

styfle requested a review from timneutkens October 10, 2020 14:10

styfle added 2 commits October 10, 2020 10:16

Remove test repo

db041fc

Run lint

bbdfd60

This comment has been minimized.

Sign in to view

Regenerate yarn.lock

b5f1dfc

This comment has been minimized.

Sign in to view

Remove sharp from pnp test

7e33323

styfle requested a review from nkzawa October 15, 2020 15:17

styfle added 2 commits October 15, 2020 11:22

Remove one more experimental

f6670e5

Merge branch 'canary' into rfc17141-next-image-api

59a26c0

styfle mentioned this pull request Oct 15, 2020

[next] Add support for Image Optimization vercel/vercel#5296

Merged

ijjk reviewed Oct 15, 2020

View reviewed changes

packages/next/next-server/server/config.ts Show resolved Hide resolved

ijjk reviewed Oct 15, 2020

View reviewed changes

packages/next/next-server/server/image-optimizer.ts Outdated Show resolved Hide resolved

Add docs for installing sharp

b2e11f0

ijjk added the type: documentation label Oct 15, 2020

styfle requested a review from ijjk October 15, 2020 21:37

styfle added 2 commits October 15, 2020 18:43

Throw error when sharp was not found

6e0c905

Merge branch 'canary' into rfc17141-next-image-api

c53aec6

ijjk reviewed Oct 15, 2020

View reviewed changes

packages/next/next-server/server/image-optimizer.ts Show resolved Hide resolved

Add test for invalid image

17cddcb

styfle requested a review from ijjk October 15, 2020 23:10

timneutkens approved these changes Oct 16, 2020

View reviewed changes

timneutkens merged commit d3741d5 into canary Oct 16, 2020

timneutkens deleted the rfc17141-next-image-api branch October 16, 2020 11:10

timneutkens mentioned this pull request Oct 16, 2020

Update default configuration to match image optimization #17943

Merged

timneutkens added the hacktoberfest-accepted label Oct 16, 2020

styfle added a commit to vercel/vercel that referenced this pull request Oct 16, 2020

[next] Add support for Image Optimization (#5296)

c7ead15

This PR sends the results of the image optimization config from next.config.js to the build output. x-ref: vercel/next.js#17749

ijjk mentioned this pull request Oct 17, 2020

Make sure animated assets aren't de-animated by optimizer #17974

Merged

merceyz mentioned this pull request Oct 17, 2020

fix(next): add missing optional peer dependency sharp #17981

Closed

This comment has been minimized.

Sign in to view

ofhouse pushed a commit to milliHQ/terraform-aws-next-js that referenced this pull request Mar 13, 2021

[next] Add support for Image Optimization (#5296)

0cab5be

This PR sends the results of the image optimization config from next.config.js to the build output. x-ref: vercel/next.js#17749

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Image Optimizer #17749

Add support for Image Optimizer #17749

styfle commented Oct 9, 2020 •

edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Oct 15, 2020

ijjk commented Oct 15, 2020

ijjk commented Oct 15, 2020

ijjk commented Oct 15, 2020

This comment has been minimized.

Add support for Image Optimizer #17749

Add support for Image Optimizer #17749

Conversation

styfle commented Oct 9, 2020 • edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Oct 15, 2020

Stats from current PR

ijjk commented Oct 15, 2020

Stats from current PR

ijjk commented Oct 15, 2020

Stats from current PR

ijjk commented Oct 15, 2020

Failing test suites

This comment has been minimized.

styfle commented Oct 9, 2020 •

edited