Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure locale detecting is case-insensitive #17757

Merged
merged 5 commits into from Oct 11, 2020
Merged

Make sure locale detecting is case-insensitive #17757

merged 5 commits into from Oct 11, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 9, 2020

Follow-up to #17370 this makes sure the locale detection is case-insensitive.

@ijjk ijjk added the type: next label Oct 9, 2020
@ijjk
Copy link
Member Author

ijjk commented Oct 9, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
buildDuration 13.7s 14s ⚠️ +268ms
nodeModulesSize 63.4 MB 63.4 MB ⚠️ +277 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.672 2.701 ⚠️ +0.03
/ avg req/sec 935.76 925.55 ⚠️ -10.21
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.596 1.578 -0.02
/error-in-render avg req/sec 1566.68 1584.54 +17.86
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
677f882d2ed8..9b19.js gzip 11.1 kB 11.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ef5fcfe..d66c.js gzip 7.24 kB 7.24 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58 kB 58 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
677f882d2ed8..dule.js gzip 6.9 kB 6.9 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-1c7f28c..dule.js gzip 6.29 kB 6.29 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.9 kB 52.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-409b283..e3ab.js gzip 1.32 kB 1.32 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.73 kB 7.73 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-92d3016..dule.js gzip 1.28 kB 1.28 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 995 B 995 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
buildDuration 16s 15.7s -311ms
nodeModulesSize 63.4 MB 63.4 MB ⚠️ +277 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
677f882d2ed8..9b19.js gzip 11.1 kB 11.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ef5fcfe..d66c.js gzip 7.24 kB 7.24 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58 kB 58 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
677f882d2ed8..dule.js gzip 6.9 kB 6.9 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-1c7f28c..dule.js gzip 6.29 kB 6.29 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.9 kB 52.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-409b283..e3ab.js gzip 1.32 kB 1.32 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.73 kB 7.73 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-92d3016..dule.js gzip 1.28 kB 1.28 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
_error.js 1.05 MB 1.05 MB ✓
404.html 4.34 kB 4.34 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.05 MB 1.05 MB ✓
link.js 1.1 MB 1.1 MB ✓
routerDirect.js 1.09 MB 1.09 MB ✓
withRouter.js 1.09 MB 1.09 MB ✓
Overall change 5.41 MB 5.41 MB ✓
Commit: 57150da

timneutkens
timneutkens previously approved these changes Oct 10, 2020
View reviewed changes
@ijjk
Copy link
Member Author

ijjk commented Oct 10, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
buildDuration 13.5s 13.6s ⚠️ +121ms
nodeModulesSize 63.4 MB 63.4 MB ⚠️ +277 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.429 2.433 0
/ avg req/sec 1029.17 1027.34 ⚠️ -1.83
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.339 1.318 -0.02
/error-in-render avg req/sec 1867.12 1897.32 +30.2
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
677f882d2ed8..9b19.js gzip 11.1 kB 11.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-51c1c2f..7e91.js gzip 7.23 kB 7.23 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58 kB 58 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
677f882d2ed8..dule.js gzip 6.9 kB 6.9 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-87d379f..dule.js gzip 6.29 kB 6.29 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.9 kB 52.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-409b283..e3ab.js gzip 1.32 kB 1.32 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.73 kB 7.73 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-92d3016..dule.js gzip 1.28 kB 1.28 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 997 B 997 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
buildDuration 15.1s 15.4s ⚠️ +358ms
nodeModulesSize 63.4 MB 63.4 MB ⚠️ +277 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
677f882d2ed8..9b19.js gzip 11.1 kB 11.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-51c1c2f..7e91.js gzip 7.23 kB 7.23 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58 kB 58 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
677f882d2ed8..dule.js gzip 6.9 kB 6.9 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-87d379f..dule.js gzip 6.29 kB 6.29 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.9 kB 52.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-409b283..e3ab.js gzip 1.32 kB 1.32 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.73 kB 7.73 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-92d3016..dule.js gzip 1.28 kB 1.28 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
_error.js 1.05 MB 1.05 MB ✓
404.html 4.34 kB 4.34 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.05 MB 1.05 MB ✓
link.js 1.1 MB 1.1 MB ✓
routerDirect.js 1.09 MB 1.09 MB ✓
withRouter.js 1.09 MB 1.09 MB ✓
Overall change 5.41 MB 5.41 MB ✓
Commit: c36e2d9

@ijjk ijjk requested a review from timneutkens October 11, 2020 19:54
@ijjk
Copy link
Member Author

ijjk commented Oct 11, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
buildDuration 12.6s 12.7s ⚠️ +136ms
nodeModulesSize 63.4 MB 63.4 MB ⚠️ +259 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.404 2.471 ⚠️ +0.07
/ avg req/sec 1039.93 1011.66 ⚠️ -28.27
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.55 1.578 ⚠️ +0.03
/error-in-render avg req/sec 1612.52 1583.79 ⚠️ -28.73
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
677f882d2ed8..133b.js gzip 11.1 kB 11.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-faae5f7..727a.js gzip 7.22 kB 7.22 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58 kB 58 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
677f882d2ed8..dule.js gzip 6.9 kB 6.9 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-d2ce890..dule.js gzip 6.28 kB 6.28 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.9 kB 52.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-409b283..e3ab.js gzip 1.32 kB 1.32 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.73 kB 7.73 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-92d3016..dule.js gzip 1.28 kB 1.28 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 995 B 995 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
buildDuration 14.2s 14s -230ms
nodeModulesSize 63.4 MB 63.4 MB ⚠️ +259 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
677f882d2ed8..133b.js gzip 11.1 kB 11.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-faae5f7..727a.js gzip 7.22 kB 7.22 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58 kB 58 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
677f882d2ed8..dule.js gzip 6.9 kB 6.9 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-d2ce890..dule.js gzip 6.28 kB 6.28 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.9 kB 52.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-409b283..e3ab.js gzip 1.32 kB 1.32 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.73 kB 7.73 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-92d3016..dule.js gzip 1.28 kB 1.28 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js i18n/case-insenstive-locale Change
_error.js 1.05 MB 1.05 MB ✓
404.html 4.34 kB 4.34 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.05 MB 1.05 MB ✓
link.js 1.1 MB 1.1 MB ✓
routerDirect.js 1.09 MB 1.09 MB ✓
withRouter.js 1.09 MB 1.09 MB ✓
Overall change 5.41 MB 5.41 MB ✓
Commit: 1865040

@kodiakhq kodiakhq bot merged commit 1eeac4f into vercel:canary Oct 11, 2020
@ijjk ijjk deleted the i18n/case-insenstive-locale branch October 12, 2020 16:54
@styfle styfle mentioned this pull request Nov 4, 2021
Merged
kodiakhq bot pushed a commit that referenced this pull request Nov 15, 2021
@styfle @ijjk
Fix basePath replacing server-side and normalizeLocalePath() when p…
eb0bd63 
…ath is empty string (#30978)

This fixes our `basePath` detection/replacing server-side as we were incorrectly considering `/docss` a match for a `basePath` of `/docs` which caused us to have an unexpected value in the `normalizeLocalePath` function. 

- Fixes #22429
- Regression introduced in #17757 
- Fixes: #31423

Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @timneutkens