Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add perf data experiment #17956

Merged
merged 4 commits into from Oct 16, 2020
Merged

Add perf data experiment #17956

merged 4 commits into from Oct 16, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Oct 16, 2020

This adds an internal experiment for performance data.

timneutkens
timneutkens previously approved these changes Oct 16, 2020
timneutkens
timneutkens previously approved these changes Oct 16, 2020
ijjk
ijjk previously approved these changes Oct 16, 2020
@ijjk
Copy link
Member

ijjk commented Oct 16, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js experimental/vitals Change
buildDuration 13.7s 13.7s -27ms
nodeModulesSize 64.4 MB 64.4 MB ⚠️ +4.99 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js experimental/vitals Change
/ failed reqs 0 0
/ total time (seconds) 2.578 2.616 ⚠️ +0.04
/ avg req/sec 969.78 955.56 ⚠️ -14.22
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.642 1.678 ⚠️ +0.04
/error-in-render avg req/sec 1522.41 1490.18 ⚠️ -32.23
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary Timer/next.js experimental/vitals Change
677f882d2ed8..7765.js gzip 11.1 kB 11.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-a6456b1..6da9.js gzip 7.33 kB 7.34 kB ⚠️ +6 B
webpack-e067..f178.js gzip 751 B 751 B
Overall change 58.1 kB 58.1 kB ⚠️ +6 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary Timer/next.js experimental/vitals Change
677f882d2ed8..dule.js gzip 6.94 kB 6.94 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-241723f..dule.js gzip 6.32 kB 6.32 kB ⚠️ +6 B
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 53 kB 53 kB ⚠️ +6 B
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js experimental/vitals Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Timer/next.js experimental/vitals Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-89ad9e7..25bb.js gzip 1.34 kB 1.34 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.74 kB 7.74 kB
Client Pages Modern
vercel/next.js canary Timer/next.js experimental/vitals Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-aeb707b..dule.js gzip 1.29 kB 1.29 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.39 kB 5.39 kB
Client Build Manifests
vercel/next.js canary Timer/next.js experimental/vitals Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary Timer/next.js experimental/vitals Change
index.html gzip 1 kB 1 kB -1 B
link.html gzip 1.01 kB 1.01 kB -1 B
withRouter.html gzip 996 B 994 B -2 B
Overall change 3.01 kB 3.01 kB -4 B

Diffs

Diff for main-6e1a453..e5.module.js
@@ -920,12 +920,21 @@
 
       var _webVitals = __webpack_require__("w6Sm");
 
+      var initialHref = location.href;
       var isRegistered = false;
       var userReportHandler;
 
       function onReport(metric) {
         if (userReportHandler) {
           userReportHandler(metric);
+        } // This code is not shipped, executed, or present in the client-side
+        // JavaScript bundle unless explicitly enabled in your application.
+        //
+        // When this feature is enabled, we'll make it very clear by printing a
+        // message during the build (`next build`).
+
+        if (false) {
+          var vitalsUrl, blob, body;
         }
       }
Diff for main-838c5b4..4b9ffbda5.js
@@ -1250,12 +1250,21 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
 
       var _webVitals = __webpack_require__("w6Sm");
 
+      var initialHref = location.href;
       var isRegistered = false;
       var userReportHandler;
 
       function onReport(metric) {
         if (userReportHandler) {
           userReportHandler(metric);
+        } // This code is not shipped, executed, or present in the client-side
+        // JavaScript bundle unless explicitly enabled in your application.
+        //
+        // When this feature is enabled, we'll make it very clear by printing a
+        // message during the build (`next build`).
+
+        if (false) {
+          var vitalsUrl, blob, body;
         }
       }
Diff for index.html
@@ -6,7 +6,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-6e1a4534b74baeb696e5.module.js"
+      href="/_next/static/chunks/main-2b5d425fae9e8fde1743.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -85,13 +85,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-838c5b41be94b9ffbda5.js"
+      src="/_next/static/chunks/main-1e75a179eff070782b54.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-6e1a4534b74baeb696e5.module.js"
+      src="/_next/static/chunks/main-2b5d425fae9e8fde1743.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html
@@ -6,7 +6,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-6e1a4534b74baeb696e5.module.js"
+      href="/_next/static/chunks/main-2b5d425fae9e8fde1743.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -90,13 +90,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-838c5b41be94b9ffbda5.js"
+      src="/_next/static/chunks/main-1e75a179eff070782b54.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-6e1a4534b74baeb696e5.module.js"
+      src="/_next/static/chunks/main-2b5d425fae9e8fde1743.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html
@@ -6,7 +6,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-6e1a4534b74baeb696e5.module.js"
+      href="/_next/static/chunks/main-2b5d425fae9e8fde1743.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -85,13 +85,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-838c5b41be94b9ffbda5.js"
+      src="/_next/static/chunks/main-1e75a179eff070782b54.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-6e1a4534b74baeb696e5.module.js"
+      src="/_next/static/chunks/main-2b5d425fae9e8fde1743.module.js"
       async=""
       crossorigin="anonymous"
       type="module"

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js experimental/vitals Change
buildDuration 15.6s 15.7s ⚠️ +32ms
nodeModulesSize 64.4 MB 64.4 MB ⚠️ +4.99 kB
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary Timer/next.js experimental/vitals Change
677f882d2ed8..7765.js gzip 11.1 kB 11.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-a6456b1..6da9.js gzip 7.33 kB N/A N/A
webpack-e067..f178.js gzip 751 B 751 B
main-8d2c22e..7997.js gzip N/A 7.34 kB N/A
Overall change 58.1 kB 58.1 kB ⚠️ +6 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary Timer/next.js experimental/vitals Change
677f882d2ed8..dule.js gzip 6.94 kB 6.94 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-241723f..dule.js gzip 6.32 kB N/A N/A
webpack-07c5..dule.js gzip 751 B 751 B
main-327d8df..dule.js gzip N/A 6.32 kB N/A
Overall change 53 kB 53 kB ⚠️ +6 B
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js experimental/vitals Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Timer/next.js experimental/vitals Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-89ad9e7..25bb.js gzip 1.34 kB 1.34 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.74 kB 7.74 kB
Client Pages Modern
vercel/next.js canary Timer/next.js experimental/vitals Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-aeb707b..dule.js gzip 1.29 kB 1.29 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.39 kB 5.39 kB
Client Build Manifests
vercel/next.js canary Timer/next.js experimental/vitals Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Serverless bundles
vercel/next.js canary Timer/next.js experimental/vitals Change
_error.js 1.06 MB 1.06 MB
404.html 4.34 kB 4.34 kB
hooks.html 3.92 kB 3.92 kB
index.js 1.06 MB 1.06 MB
link.js 1.1 MB 1.1 MB
routerDirect.js 1.1 MB 1.1 MB
withRouter.js 1.1 MB 1.1 MB
Overall change 5.42 MB 5.42 MB
Commit: 1dd9e97

@ijjk
Copy link
Member

ijjk commented Oct 16, 2020

Failing test suites

Commit: 1dd9e97

test/integration/relay-analytics/test/disabled.test.js

  • Analytics relayer (disabled) > Does not relay any data
Expand output

● Analytics relayer (disabled) › Does not relay any data

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 2

  45 |     )
  46 | 
> 47 |     expect(beacons.length).toBe(0)
     |                            ^
  48 | 
  49 |     expect(stdout).not.toMatch('Next.js Analytics')
  50 | 

  at Object.<anonymous> (integration/relay-analytics/test/disabled.test.js:47:28)

@Timer Timer dismissed stale reviews from ijjk and timneutkens via 797a199 October 16, 2020 20:08
@Timer Timer requested a review from ijjk October 16, 2020 20:08
@ijjk
Copy link
Member

ijjk commented Oct 16, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js experimental/vitals Change
buildDuration 13.8s 14.1s ⚠️ +263ms
nodeModulesSize 64.4 MB 64.4 MB ⚠️ +4.99 kB
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js experimental/vitals Change
/ failed reqs 0 0
/ total time (seconds) 2.54 2.513 -0.03
/ avg req/sec 984.39 995.02 +10.63
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.503 1.461 -0.04
/error-in-render avg req/sec 1663.18 1711.39 +48.21
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary Timer/next.js experimental/vitals Change
677f882d2ed8..7765.js gzip 11.1 kB 11.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-a6456b1..6da9.js gzip 7.33 kB 7.34 kB ⚠️ +6 B
webpack-e067..f178.js gzip 751 B 751 B
Overall change 58.1 kB 58.1 kB ⚠️ +6 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary Timer/next.js experimental/vitals Change
677f882d2ed8..dule.js gzip 6.94 kB 6.94 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-241723f..dule.js gzip 6.32 kB 6.32 kB ⚠️ +6 B
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 53 kB 53 kB ⚠️ +6 B
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js experimental/vitals Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Timer/next.js experimental/vitals Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-89ad9e7..25bb.js gzip 1.34 kB 1.34 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.74 kB 7.74 kB
Client Pages Modern
vercel/next.js canary Timer/next.js experimental/vitals Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-aeb707b..dule.js gzip 1.29 kB 1.29 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.39 kB 5.39 kB
Client Build Manifests
vercel/next.js canary Timer/next.js experimental/vitals Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary Timer/next.js experimental/vitals Change
index.html gzip 1 kB 1 kB -1 B
link.html gzip 1.01 kB 1.01 kB -1 B
withRouter.html gzip 996 B 994 B -2 B
Overall change 3.01 kB 3.01 kB -4 B

Diffs

Diff for main-6e1a453..e5.module.js
@@ -920,12 +920,21 @@
 
       var _webVitals = __webpack_require__("w6Sm");
 
+      var initialHref = location.href;
       var isRegistered = false;
       var userReportHandler;
 
       function onReport(metric) {
         if (userReportHandler) {
           userReportHandler(metric);
+        } // This code is not shipped, executed, or present in the client-side
+        // JavaScript bundle unless explicitly enabled in your application.
+        //
+        // When this feature is enabled, we'll make it very clear by printing a
+        // message during the build (`next build`).
+
+        if (false) {
+          var vitalsUrl, blob, body;
         }
       }
Diff for main-838c5b4..4b9ffbda5.js
@@ -1250,12 +1250,21 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
 
       var _webVitals = __webpack_require__("w6Sm");
 
+      var initialHref = location.href;
       var isRegistered = false;
       var userReportHandler;
 
       function onReport(metric) {
         if (userReportHandler) {
           userReportHandler(metric);
+        } // This code is not shipped, executed, or present in the client-side
+        // JavaScript bundle unless explicitly enabled in your application.
+        //
+        // When this feature is enabled, we'll make it very clear by printing a
+        // message during the build (`next build`).
+
+        if (false) {
+          var vitalsUrl, blob, body;
         }
       }
Diff for index.html
@@ -6,7 +6,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-6e1a4534b74baeb696e5.module.js"
+      href="/_next/static/chunks/main-2b5d425fae9e8fde1743.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -85,13 +85,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-838c5b41be94b9ffbda5.js"
+      src="/_next/static/chunks/main-1e75a179eff070782b54.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-6e1a4534b74baeb696e5.module.js"
+      src="/_next/static/chunks/main-2b5d425fae9e8fde1743.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html
@@ -6,7 +6,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-6e1a4534b74baeb696e5.module.js"
+      href="/_next/static/chunks/main-2b5d425fae9e8fde1743.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -90,13 +90,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-838c5b41be94b9ffbda5.js"
+      src="/_next/static/chunks/main-1e75a179eff070782b54.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-6e1a4534b74baeb696e5.module.js"
+      src="/_next/static/chunks/main-2b5d425fae9e8fde1743.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html
@@ -6,7 +6,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-6e1a4534b74baeb696e5.module.js"
+      href="/_next/static/chunks/main-2b5d425fae9e8fde1743.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -85,13 +85,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-838c5b41be94b9ffbda5.js"
+      src="/_next/static/chunks/main-1e75a179eff070782b54.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-6e1a4534b74baeb696e5.module.js"
+      src="/_next/static/chunks/main-2b5d425fae9e8fde1743.module.js"
       async=""
       crossorigin="anonymous"
       type="module"

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js experimental/vitals Change
buildDuration 15.7s 15.7s -31ms
nodeModulesSize 64.4 MB 64.4 MB ⚠️ +4.99 kB
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary Timer/next.js experimental/vitals Change
677f882d2ed8..7765.js gzip 11.1 kB 11.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-a6456b1..6da9.js gzip 7.33 kB N/A N/A
webpack-e067..f178.js gzip 751 B 751 B
main-8d2c22e..7997.js gzip N/A 7.34 kB N/A
Overall change 58.1 kB 58.1 kB ⚠️ +6 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary Timer/next.js experimental/vitals Change
677f882d2ed8..dule.js gzip 6.94 kB 6.94 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-241723f..dule.js gzip 6.32 kB N/A N/A
webpack-07c5..dule.js gzip 751 B 751 B
main-327d8df..dule.js gzip N/A 6.32 kB N/A
Overall change 53 kB 53 kB ⚠️ +6 B
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js experimental/vitals Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Timer/next.js experimental/vitals Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-89ad9e7..25bb.js gzip 1.34 kB 1.34 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.74 kB 7.74 kB
Client Pages Modern
vercel/next.js canary Timer/next.js experimental/vitals Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-aeb707b..dule.js gzip 1.29 kB 1.29 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.39 kB 5.39 kB
Client Build Manifests
vercel/next.js canary Timer/next.js experimental/vitals Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Serverless bundles
vercel/next.js canary Timer/next.js experimental/vitals Change
_error.js 1.06 MB 1.06 MB
404.html 4.34 kB 4.34 kB
hooks.html 3.92 kB 3.92 kB
index.js 1.06 MB 1.06 MB
link.js 1.1 MB 1.1 MB
routerDirect.js 1.1 MB 1.1 MB
withRouter.js 1.1 MB 1.1 MB
Overall change 5.42 MB 5.42 MB
Commit: 797a199

@Timer Timer merged commit 0fe5b23 into vercel:canary Oct 16, 2020
@Timer Timer deleted the experimental/vitals branch October 16, 2020 20:31
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants