Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial i18n documentation #18067

Merged
merged 9 commits into from Oct 23, 2020
Merged

Add initial i18n documentation #18067

merged 9 commits into from Oct 23, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 20, 2020 •
edited

This adds documentation for the i18n routing features described in the RFC here #17078 and implemented through #17370

@ijjk
Copy link
Member Author

ijjk commented Oct 20, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js docs/i18n Change
buildDuration 12.6s 12.3s -312ms
nodeModulesSize 62.4 MB 62.4 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js docs/i18n Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.299 2.326 ⚠️ +0.03
/ avg req/sec 1087.58 1075.03 ⚠️ -12.55
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.291 1.274 -0.02
/error-in-render avg req/sec 1936.66 1961.88 +25.22
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js docs/i18n Change
677f882d2ed8..35e7.js gzip 11.1 kB 11.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-0297b89..3d55.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.1 kB 58.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js docs/i18n Change
677f882d2ed8..dule.js gzip 6.94 kB 6.94 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-8539e6d..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53 kB 53 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js docs/i18n Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js docs/i18n Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-89ad9e7..25bb.js gzip 1.34 kB 1.34 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.74 kB 7.74 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js docs/i18n Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-aeb707b..dule.js gzip 1.29 kB 1.29 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.39 kB 5.39 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js docs/i18n Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js docs/i18n Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 996 B 996 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode
General
vercel/next.js canary ijjk/next.js docs/i18n Change
buildDuration 13.4s 13.4s -67ms
nodeModulesSize 62.4 MB 62.4 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js docs/i18n Change
677f882d2ed8..35e7.js gzip 11.1 kB 11.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-0297b89..3d55.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.1 kB 58.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js docs/i18n Change
677f882d2ed8..dule.js gzip 6.94 kB 6.94 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-8539e6d..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53 kB 53 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js docs/i18n Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js docs/i18n Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-89ad9e7..25bb.js gzip 1.34 kB 1.34 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.74 kB 7.74 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js docs/i18n Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-aeb707b..dule.js gzip 1.29 kB 1.29 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.39 kB 5.39 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js docs/i18n Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js docs/i18n Change
_error.js 1.06 MB 1.06 MB ✓
404.html 4.34 kB 4.34 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.06 MB 1.06 MB ✓
link.js 1.1 MB 1.1 MB ✓
routerDirect.js 1.1 MB 1.1 MB ✓
withRouter.js 1.1 MB 1.1 MB ✓
Overall change 5.42 MB 5.42 MB ✓
Commit: 70d1617

@ijjk @timneutkens
Apply suggestions from code review
05c0ffe 
Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
@ijjk
Copy link
Member Author

ijjk commented Oct 21, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js docs/i18n Change
buildDuration 12.8s 12.8s -41ms
nodeModulesSize 91.2 MB 91.2 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js docs/i18n Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.356 2.386 ⚠️ +0.03
/ avg req/sec 1060.95 1047.79 ⚠️ -13.16
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.319 1.282 -0.04
/error-in-render avg req/sec 1896.08 1950.3 +54.22
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js docs/i18n Change
677f882d2ed8..35e7.js gzip 11.1 kB 11.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-0297b89..3d55.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.1 kB 58.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js docs/i18n Change
677f882d2ed8..dule.js gzip 6.94 kB 6.94 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-8539e6d..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53 kB 53 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js docs/i18n Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js docs/i18n Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-89ad9e7..25bb.js gzip 1.34 kB 1.34 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.74 kB 7.74 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js docs/i18n Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-aeb707b..dule.js gzip 1.29 kB 1.29 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.39 kB 5.39 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js docs/i18n Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js docs/i18n Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 996 B 996 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode
General
vercel/next.js canary ijjk/next.js docs/i18n Change
buildDuration 14.6s 14.7s ⚠️ +45ms
nodeModulesSize 91.2 MB 91.2 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js docs/i18n Change
677f882d2ed8..35e7.js gzip 11.1 kB 11.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-0297b89..3d55.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.1 kB 58.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js docs/i18n Change
677f882d2ed8..dule.js gzip 6.94 kB 6.94 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-8539e6d..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53 kB 53 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js docs/i18n Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js docs/i18n Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-89ad9e7..25bb.js gzip 1.34 kB 1.34 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.74 kB 7.74 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js docs/i18n Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-aeb707b..dule.js gzip 1.29 kB 1.29 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.39 kB 5.39 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js docs/i18n Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js docs/i18n Change
_error.js 1.06 MB 1.06 MB ✓
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.06 MB 1.06 MB ✓
link.js 1.1 MB 1.1 MB ✓
routerDirect.js 1.1 MB 1.1 MB ✓
withRouter.js 1.1 MB 1.1 MB ✓
Overall change 5.42 MB 5.42 MB ✓
Commit: 05c0ffe

leerob
leerob reviewed Oct 22, 2020
View reviewed changes
docs/advanced-features/i18n-routing.md Show resolved Hide resolved
docs/advanced-features/i18n-routing.md Outdated Show resolved Hide resolved
docs/advanced-features/i18n-routing.md Outdated Show resolved Hide resolved
docs/advanced-features/i18n-routing.md Outdated Show resolved Hide resolved
docs/advanced-features/i18n-routing.md Outdated Show resolved Hide resolved
docs/advanced-features/i18n-routing.md Outdated Show resolved Hide resolved
docs/advanced-features/i18n-routing.md Outdated Show resolved Hide resolved
docs/basic-features/data-fetching.md Outdated Show resolved Hide resolved
docs/basic-features/data-fetching.md Outdated Show resolved Hide resolved
docs/basic-features/data-fetching.md Outdated Show resolved Hide resolved
ijjk and others added 2 commits October 22, 2020 11:46
@ijjk @leerob
Apply suggestions from code review
85f2728 
Co-authored-by: Lee Robinson <me@leerob.io>
@ijjk
Apply more suggestions
ba0247c
@ijjk
Copy link
Member Author

ijjk commented Oct 22, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js docs/i18n Change
buildDuration 12.4s 12.6s ⚠️ +213ms
nodeModulesSize 91.2 MB 91.2 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js docs/i18n Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.384 2.362 -0.02
/ avg req/sec 1048.61 1058.48 +9.87
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.299 1.347 ⚠️ +0.05
/error-in-render avg req/sec 1924.13 1856.24 ⚠️ -67.89
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js docs/i18n Change
677f882d2ed8..574c.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-de5d578..9aea.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js docs/i18n Change
677f882d2ed8..dule.js gzip 7.02 kB 7.02 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-c22ffdd..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js docs/i18n Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js docs/i18n Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js docs/i18n Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js docs/i18n Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js docs/i18n Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 993 B 993 B ✓
Overall change 3 kB 3 kB ✓
Serverless Mode
General
vercel/next.js canary ijjk/next.js docs/i18n Change
buildDuration 14.4s 14s -325ms
nodeModulesSize 91.2 MB 91.2 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js docs/i18n Change
677f882d2ed8..574c.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-de5d578..9aea.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js docs/i18n Change
677f882d2ed8..dule.js gzip 7.02 kB 7.02 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-c22ffdd..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js docs/i18n Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js docs/i18n Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js docs/i18n Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js docs/i18n Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js docs/i18n Change
_error.js 1.06 MB 1.06 MB ✓
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.06 MB 1.06 MB ✓
link.js 1.1 MB 1.1 MB ✓
routerDirect.js 1.1 MB 1.1 MB ✓
withRouter.js 1.1 MB 1.1 MB ✓
Overall change 5.42 MB 5.42 MB ✓
Commit: ba0247c

@ijjk
Copy link
Member Author

ijjk commented Oct 22, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js docs/i18n Change
buildDuration 12.3s 12.3s ⚠️ +5ms
nodeModulesSize 91.2 MB 91.2 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js docs/i18n Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.398 2.461 ⚠️ +0.06
/ avg req/sec 1042.56 1015.83 ⚠️ -26.73
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.394 1.516 ⚠️ +0.12
/error-in-render avg req/sec 1793.03 1649.05 ⚠️ -143.98
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js docs/i18n Change
677f882d2ed8..574c.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-de5d578..9aea.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js docs/i18n Change
677f882d2ed8..dule.js gzip 7.02 kB 7.02 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-c22ffdd..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js docs/i18n Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js docs/i18n Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js docs/i18n Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js docs/i18n Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js docs/i18n Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 993 B 993 B ✓
Overall change 3 kB 3 kB ✓
Serverless Mode
General
vercel/next.js canary ijjk/next.js docs/i18n Change
buildDuration 13.8s 14.2s ⚠️ +371ms
nodeModulesSize 91.2 MB 91.2 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js docs/i18n Change
677f882d2ed8..574c.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-de5d578..9aea.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js docs/i18n Change
677f882d2ed8..dule.js gzip 7.02 kB 7.02 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-c22ffdd..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js docs/i18n Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js docs/i18n Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js docs/i18n Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js docs/i18n Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js docs/i18n Change
_error.js 1.06 MB 1.06 MB ✓
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.06 MB 1.06 MB ✓
link.js 1.1 MB 1.1 MB ✓
routerDirect.js 1.1 MB 1.1 MB ✓
withRouter.js 1.1 MB 1.1 MB ✓
Overall change 5.42 MB 5.42 MB ✓
Commit: 5fd6a11

leerob
leerob previously approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

@ijjk
Copy link
Member Author

ijjk commented Oct 23, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js docs/i18n Change
buildDuration 13.8s 14.8s ⚠️ +1s
nodeModulesSize 91.2 MB 91.2 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js docs/i18n Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.605 2.517 -0.09
/ avg req/sec 959.84 993.41 +33.57
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.431 1.38 -0.05
/error-in-render avg req/sec 1747.49 1811.47 +63.98
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js docs/i18n Change
677f882d2ed8..574c.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-de5d578..9aea.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js docs/i18n Change
677f882d2ed8..dule.js gzip 7.02 kB 7.02 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-c22ffdd..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js docs/i18n Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js docs/i18n Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js docs/i18n Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js docs/i18n Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js docs/i18n Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 993 B 993 B ✓
Overall change 3 kB 3 kB ✓
Serverless Mode
General
vercel/next.js canary ijjk/next.js docs/i18n Change
buildDuration 15.5s 15.4s -81ms
nodeModulesSize 91.2 MB 91.2 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js docs/i18n Change
677f882d2ed8..574c.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-de5d578..9aea.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js docs/i18n Change
677f882d2ed8..dule.js gzip 7.02 kB 7.02 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-c22ffdd..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js docs/i18n Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js docs/i18n Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js docs/i18n Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js docs/i18n Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js docs/i18n Change
_error.js 1.06 MB 1.06 MB ✓
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.06 MB 1.06 MB ✓
link.js 1.1 MB 1.1 MB ✓
routerDirect.js 1.1 MB 1.1 MB ✓
withRouter.js 1.1 MB 1.1 MB ✓
Overall change 5.42 MB 5.42 MB ✓
Commit: 053d2a9

leerob
leerob approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additions @timneutkens!

@timneutkens timneutkens marked this pull request as ready for review October 23, 2020 15:02
@ijjk
Copy link
Member Author

ijjk commented Oct 23, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js docs/i18n Change
buildDuration 13.4s 13.5s ⚠️ +111ms
nodeModulesSize 91.2 MB 91.2 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js docs/i18n Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.58 2.621 ⚠️ +0.04
/ avg req/sec 968.86 953.92 ⚠️ -14.94
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.527 1.599 ⚠️ +0.07
/error-in-render avg req/sec 1637.68 1563.37 ⚠️ -74.31
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js docs/i18n Change
677f882d2ed8..574c.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-af76201..828d.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js docs/i18n Change
677f882d2ed8..dule.js gzip 7.02 kB 7.02 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-3ba933e..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js docs/i18n Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js docs/i18n Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js docs/i18n Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js docs/i18n Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js docs/i18n Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 995 B 995 B ✓
Overall change 3 kB 3 kB ✓
Serverless Mode
General
vercel/next.js canary ijjk/next.js docs/i18n Change
buildDuration 15.4s 15.6s ⚠️ +246ms
nodeModulesSize 91.2 MB 91.2 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js docs/i18n Change
677f882d2ed8..574c.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-af76201..828d.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js docs/i18n Change
677f882d2ed8..dule.js gzip 7.02 kB 7.02 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-3ba933e..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js docs/i18n Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js docs/i18n Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js docs/i18n Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js docs/i18n Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js docs/i18n Change
_error.js 1.06 MB 1.06 MB ✓
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.06 MB 1.06 MB ✓
link.js 1.1 MB 1.1 MB ✓
routerDirect.js 1.1 MB 1.1 MB ✓
withRouter.js 1.1 MB 1.1 MB ✓
Overall change 5.42 MB 5.42 MB ✓
Commit: 9390744

@ijjk ijjk merged commit d4397d8 into vercel:canary Oct 23, 2020
@ijjk ijjk deleted the docs/i18n branch October 23, 2020 15:42
@ijjk ijjk mentioned this pull request Oct 24, 2020
Merged
@Vadorequest
Copy link
Contributor

Documentation is neat and very thorough, thank you!

@ijjk ijjk mentioned this pull request Oct 26, 2020
Merged
kodiakhq bot pushed a commit that referenced this pull request Oct 27, 2020
@ijjk
Add i18n routing docs to manifest (#18264)
3c9da07 
Follow-up to #18067 this adds the manifest item for the new docs
kodiakhq bot pushed a commit that referenced this pull request Oct 27, 2020
@ijjk
Add initial example for i18n routing (#18206)
1b22a39 
This is a follow-up to #18067 adding an example for i18n routing

x-ref: #17370
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@leerob leerob leerob approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ijjk @Vadorequest @timneutkens @leerob