Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ya in case xa is false #18074

Merged
merged 1 commit into from Oct 21, 2020
Merged

Use ya in case xa is false #18074

merged 1 commit into from Oct 21, 2020

Conversation

gr-qft
Copy link
Contributor

@gr-qft gr-qft commented Oct 21, 2020

This closes #18023.

I was following the example mentioned in the issue (https://github.com/vercel/next.js/tree/canary/examples/with-firebase-authentication) and for some reason xa was always false, failing fetching food. Through console.log I saw that ya contained a token value and using ya worked.

@ijjk ijjk added the examples Issue/PR related to examples label Oct 21, 2020
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gr-qft Thank you. LGTM!

The name of those variables is confusing 🤔 🤣

@ijjk
Copy link
Member

ijjk commented Oct 21, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary gr-qft/next.js fix/with-firebase-auth-cookies Change
buildDuration 12.6s 12.9s ⚠️ +383ms
nodeModulesSize 62.5 MB 62.5 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary gr-qft/next.js fix/with-firebase-auth-cookies Change
/ failed reqs 0 0
/ total time (seconds) 2.367 2.405 ⚠️ +0.04
/ avg req/sec 1056.39 1039.29 ⚠️ -17.1
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.287 1.281 -0.01
/error-in-render avg req/sec 1942.6 1951.11 +8.51
Client Bundles (main, webpack, commons)
vercel/next.js canary gr-qft/next.js fix/with-firebase-auth-cookies Change
677f882d2ed8..35e7.js gzip 11.1 kB 11.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-0297b89..3d55.js gzip 7.34 kB 7.34 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 58.1 kB 58.1 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary gr-qft/next.js fix/with-firebase-auth-cookies Change
677f882d2ed8..dule.js gzip 6.94 kB 6.94 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-8539e6d..dule.js gzip 6.32 kB 6.32 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 53 kB 53 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary gr-qft/next.js fix/with-firebase-auth-cookies Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary gr-qft/next.js fix/with-firebase-auth-cookies Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-89ad9e7..25bb.js gzip 1.34 kB 1.34 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.74 kB 7.74 kB
Client Pages Modern
vercel/next.js canary gr-qft/next.js fix/with-firebase-auth-cookies Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-aeb707b..dule.js gzip 1.29 kB 1.29 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.39 kB 5.39 kB
Client Build Manifests
vercel/next.js canary gr-qft/next.js fix/with-firebase-auth-cookies Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Rendered Page Sizes
vercel/next.js canary gr-qft/next.js fix/with-firebase-auth-cookies Change
index.html gzip 1 kB 1 kB
link.html gzip 1.01 kB 1.01 kB
withRouter.html gzip 996 B 996 B
Overall change 3.01 kB 3.01 kB

Serverless Mode
General
vercel/next.js canary gr-qft/next.js fix/with-firebase-auth-cookies Change
buildDuration 14.8s 14.7s -62ms
nodeModulesSize 62.5 MB 62.5 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary gr-qft/next.js fix/with-firebase-auth-cookies Change
677f882d2ed8..35e7.js gzip 11.1 kB 11.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-0297b89..3d55.js gzip 7.34 kB 7.34 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 58.1 kB 58.1 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary gr-qft/next.js fix/with-firebase-auth-cookies Change
677f882d2ed8..dule.js gzip 6.94 kB 6.94 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-8539e6d..dule.js gzip 6.32 kB 6.32 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 53 kB 53 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary gr-qft/next.js fix/with-firebase-auth-cookies Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary gr-qft/next.js fix/with-firebase-auth-cookies Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-89ad9e7..25bb.js gzip 1.34 kB 1.34 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.74 kB 7.74 kB
Client Pages Modern
vercel/next.js canary gr-qft/next.js fix/with-firebase-auth-cookies Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-aeb707b..dule.js gzip 1.29 kB 1.29 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.39 kB 5.39 kB
Client Build Manifests
vercel/next.js canary gr-qft/next.js fix/with-firebase-auth-cookies Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Serverless bundles
vercel/next.js canary gr-qft/next.js fix/with-firebase-auth-cookies Change
_error.js 1.06 MB 1.06 MB
404.html 4.34 kB 4.34 kB
hooks.html 3.92 kB 3.92 kB
index.js 1.06 MB 1.06 MB
link.js 1.1 MB 1.1 MB
routerDirect.js 1.1 MB 1.1 MB
withRouter.js 1.1 MB 1.1 MB
Overall change 5.42 MB 5.42 MB
Commit: 19a8f59

@gr-qft
Copy link
Contributor Author

gr-qft commented Oct 21, 2020

@lfades They are 😄 , and I tried to google them but couldn't find anything good to read about them.

Would be great if anyone can point me to some sources (and I can update the README doc too to include the sources if needed).

@kodiakhq kodiakhq bot merged commit c28d39e into vercel:canary Oct 21, 2020
@gr-qft gr-qft deleted the fix/with-firebase-auth-cookies branch October 21, 2020 02:07
@SylvainGarrigues
Copy link

Accessing xa and ya doesn't seem documented anywhere + it does not renew the token like getIdToken does (which is otherwise renewed only when accessing other firebase services)

See #18256

@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firebase authentication example not working correctly
4 participants