Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix precompiled code #18093

Merged
merged 4 commits into from Oct 21, 2020
Merged

Fix precompiled code #18093

merged 4 commits into from Oct 21, 2020

Conversation

timneutkens
Copy link
Member

Solves the build failure we're seeing on PRs

styfle
styfle previously approved these changes Oct 21, 2020
View reviewed changes
ijjk
ijjk previously approved these changes Oct 21, 2020
View reviewed changes
@ijjk
Copy link
Member

ijjk commented Oct 21, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
buildDuration 12.8s 13.1s ⚠️ +209ms
nodeModulesSize 91 MB 91 MB -8.03 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.456 2.514 ⚠️ +0.06
/ avg req/sec 1017.99 994.47 ⚠️ -23.52
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.365 1.352 -0.01
/error-in-render avg req/sec 1831.09 1848.95 +17.86
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
677f882d2ed8..35e7.js gzip 11.1 kB 11.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-0297b89..3d55.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.1 kB 58.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
677f882d2ed8..dule.js gzip 6.94 kB 6.94 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-8539e6d..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53 kB 53 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-89ad9e7..25bb.js gzip 1.34 kB 1.34 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.74 kB 7.74 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-aeb707b..dule.js gzip 1.29 kB 1.29 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.39 kB 5.39 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 996 B 996 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
buildDuration 15.2s 14.9s -298ms
nodeModulesSize 91 MB 91 MB -8.03 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
677f882d2ed8..35e7.js gzip 11.1 kB 11.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-0297b89..3d55.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.1 kB 58.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
677f882d2ed8..dule.js gzip 6.94 kB 6.94 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-8539e6d..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53 kB 53 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-89ad9e7..25bb.js gzip 1.34 kB 1.34 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.74 kB 7.74 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-aeb707b..dule.js gzip 1.29 kB 1.29 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.39 kB 5.39 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_error.js 1.06 MB 1.06 MB ✓
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.06 MB 1.06 MB ✓
link.js 1.1 MB 1.1 MB ✓
routerDirect.js 1.1 MB 1.1 MB ✓
withRouter.js 1.1 MB 1.1 MB ✓
Overall change 5.42 MB 5.42 MB ✓
Commit: 8ceb697

@ijjk
Copy link
Member

ijjk commented Oct 21, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
buildDuration 12.6s 12.7s ⚠️ +81ms
nodeModulesSize 91.2 MB 91.2 MB -8.03 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.415 2.512 ⚠️ +0.1
/ avg req/sec 1035.36 995.03 ⚠️ -40.33
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.302 1.34 ⚠️ +0.04
/error-in-render avg req/sec 1920.42 1866.23 ⚠️ -54.19
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
677f882d2ed8..35e7.js gzip 11.1 kB 11.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-0297b89..3d55.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.1 kB 58.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
677f882d2ed8..dule.js gzip 6.94 kB 6.94 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-8539e6d..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53 kB 53 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-89ad9e7..25bb.js gzip 1.34 kB 1.34 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.74 kB 7.74 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-aeb707b..dule.js gzip 1.29 kB 1.29 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.39 kB 5.39 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 996 B 996 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
buildDuration 14.8s 14.2s -592ms
nodeModulesSize 91.2 MB 91.2 MB -8.03 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
677f882d2ed8..35e7.js gzip 11.1 kB 11.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-0297b89..3d55.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.1 kB 58.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
677f882d2ed8..dule.js gzip 6.94 kB 6.94 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-8539e6d..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53 kB 53 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-89ad9e7..25bb.js gzip 1.34 kB 1.34 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.74 kB 7.74 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-aeb707b..dule.js gzip 1.29 kB 1.29 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.39 kB 5.39 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_error.js 1.06 MB 1.06 MB ✓
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.06 MB 1.06 MB ✓
link.js 1.1 MB 1.1 MB ✓
routerDirect.js 1.1 MB 1.1 MB ✓
withRouter.js 1.1 MB 1.1 MB ✓
Overall change 5.42 MB 5.42 MB ✓
Commit: 834974f

@ijjk ijjk dismissed stale reviews from styfle and themself via 13ff731 October 21, 2020 16:19
@ijjk

This comment has been minimized.

Sign in to view
ijjk
ijjk previously approved these changes Oct 21, 2020
View reviewed changes
@ijjk
Copy link
Member

ijjk commented Oct 21, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
buildDuration 12.7s 12.1s -575ms
nodeModulesSize 91.2 MB 91.2 MB -8.03 kB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.387 2.301 -0.09
/ avg req/sec 1047.16 1086.32 +39.16
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.302 1.251 -0.05
/error-in-render avg req/sec 1919.97 1998.81 +78.84
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
677f882d2ed8..35e7.js gzip 11.1 kB 11.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-0297b89..3d55.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.1 kB 58.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
677f882d2ed8..dule.js gzip 6.94 kB 6.94 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-8539e6d..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53 kB 53 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-89ad9e7..25bb.js gzip 1.34 kB 1.34 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.74 kB 7.74 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-aeb707b..dule.js gzip 1.29 kB 1.29 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.39 kB 5.39 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 996 B 996 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
buildDuration 14s 13.8s -213ms
nodeModulesSize 91.2 MB 91.2 MB -8.03 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
677f882d2ed8..35e7.js gzip 11.1 kB 11.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-0297b89..3d55.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.1 kB 58.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
677f882d2ed8..dule.js gzip 6.94 kB 6.94 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-8539e6d..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53 kB 53 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-89ad9e7..25bb.js gzip 1.34 kB 1.34 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.74 kB 7.74 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-aeb707b..dule.js gzip 1.29 kB 1.29 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.39 kB 5.39 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_error.js 1.06 MB 1.06 MB ✓
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.06 MB 1.06 MB ✓
link.js 1.1 MB 1.1 MB ✓
routerDirect.js 1.1 MB 1.1 MB ✓
withRouter.js 1.1 MB 1.1 MB ✓
Overall change 5.42 MB 5.42 MB ✓
Commit: 13ff731

@ijjk
Copy link
Member

ijjk commented Oct 21, 2020

Failing test suites

Commit: 834974f

test/acceptance/ReactRefreshLogBox.test.js

  • css syntax errors

Expand output

● css syntax errors

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `css syntax errors 1`

- Snapshot  - 1
+ Received  + 1

  ./index.module.css:1:1
  Syntax error: Selector "button" is not pure (pure selectors must contain at least one local class or id)

  > 1 | button {}
-     | ^
+     |         ^

  823 |   expect(await session.hasRedbox(true)).toBe(true)
  824 |   const source2 = await session.getRedboxSource()
> 825 |   expect(source2).toMatchInlineSnapshot(`
      |                   ^
  826 |     "./index.module.css:1:1
  827 |     Syntax error: Selector \\"button\\" is not pure (pure selectors must contain at least one local class or id)
  828 | 

  at Object.<anonymous> (acceptance/ReactRefreshLogBox.test.js:825:19)

@ijjk
Copy link
Member

ijjk commented Oct 21, 2020

Failing test suites

Commit: 13ff731

test/acceptance/ReactRefreshLogBox.test.js

  • css syntax errors

Expand output

● css syntax errors

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `css syntax errors 1`

- Snapshot  - 1
+ Received  + 1

  ./index.module.css:1:1
  Syntax error: Selector "button" is not pure (pure selectors must contain at least one local class or id)

  > 1 | button {}
-     | ^
+     |         ^

  823 |   expect(await session.hasRedbox(true)).toBe(true)
  824 |   const source2 = await session.getRedboxSource()
> 825 |   expect(source2).toMatchInlineSnapshot(`
      |                   ^
  826 |     "./index.module.css:1:1
  827 |     Syntax error: Selector \\"button\\" is not pure (pure selectors must contain at least one local class or id)
  828 | 

  at Object.<anonymous> (acceptance/ReactRefreshLogBox.test.js:825:19)

@ijjk
Copy link
Member

ijjk commented Oct 21, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
buildDuration 13s 13s -6ms
nodeModulesSize 91.2 MB 91.2 MB -8.03 kB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.322 2.335 ⚠️ +0.01
/ avg req/sec 1076.79 1070.62 ⚠️ -6.17
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.375 1.315 -0.06
/error-in-render avg req/sec 1818.38 1901.81 +83.43
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
677f882d2ed8..35e7.js gzip 11.1 kB 11.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-0297b89..3d55.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.1 kB 58.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
677f882d2ed8..dule.js gzip 6.94 kB 6.94 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-8539e6d..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53 kB 53 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-89ad9e7..25bb.js gzip 1.34 kB 1.34 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.74 kB 7.74 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-aeb707b..dule.js gzip 1.29 kB 1.29 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.39 kB 5.39 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 996 B 996 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
buildDuration 14.8s 15.1s ⚠️ +335ms
nodeModulesSize 91.2 MB 91.2 MB -8.03 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
677f882d2ed8..35e7.js gzip 11.1 kB 11.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-0297b89..3d55.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.1 kB 58.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
677f882d2ed8..dule.js gzip 6.94 kB 6.94 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-8539e6d..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53 kB 53 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-89ad9e7..25bb.js gzip 1.34 kB 1.34 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.74 kB 7.74 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-aeb707b..dule.js gzip 1.29 kB 1.29 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.39 kB 5.39 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/precompiled-code Change
_error.js 1.06 MB 1.06 MB ✓
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.06 MB 1.06 MB ✓
link.js 1.1 MB 1.1 MB ✓
routerDirect.js 1.1 MB 1.1 MB ✓
withRouter.js 1.1 MB 1.1 MB ✓
Overall change 5.42 MB 5.42 MB ✓
Commit: 65abc57

@kodiakhq kodiakhq bot merged commit ea29bb3 into vercel:canary Oct 21, 2020
@timneutkens timneutkens deleted the fix/precompiled-code branch February 12, 2021 13:33
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@styfle styfle styfle left review comments

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timneutkens @ijjk @styfle