Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cache-loader and migrate on webpack@5 cache option #18095

Closed
matamatanot opened this issue Oct 21, 2020 · 2 comments
Closed

Remove cache-loader and migrate on webpack@5 cache option #18095

matamatanot opened this issue Oct 21, 2020 · 2 comments
Milestone

Comments

@matamatanot
Copy link
Contributor

matamatanot commented Oct 21, 2020

Feature request

ref: #12550
Remove cache-loader and migrate on webpack@5 the cache option.

Is your feature request related to a problem? Please describe.

When experimental option "babelMultiThread" is enabled, cache-loader is loaded.
But, the cache option of webpack@5 should be used instead.

x-ref: webpack-contrib/cache-loader#102 (comment)

Describe the solution you'd like

remove cache-loader.

Additional context

cache-loader, style-loader and file-loader depend on schema-utils. But, cache-loader no longer needed.

// dependents: cache-loader, style-loader, file-loader
'schema-utils': 'schema-utils',

style-loader 2.0.0 depend on schema-utils 3.0.0.
https://github.com/webpack-contrib/style-loader/blob/256b1c38b6a729df3516e722173288d146676482/package.json#L48

"style-loader": "1.2.1",

file-loader 6.1.1 depend on schema-utils 3.0.0.
https://github.com/webpack-contrib/file-loader/blob/14ed4c9b47f2e580f5b04b71f742cafe9e554565/package.json#L45

"file-loader": "6.0.0",

So, schema-utils should be updated to 3.0.0.

"schema-utils": "2.7.1",

After that, you can update postcss-loader to 4.0.4.
#17458 (comment)

updating postcss-loader to 4.0.4 breaks, because 4.0.4 requires schema-utils ^3.0.0, but the ncc build
prevents postcss-loader from using its own schema-utils

cc: @ludofischer 🙏 thanks!🙏

@matamatanot matamatanot changed the title Remove cache-loader and migrate on webpack@5 the cache option Remove cache-loader and migrate on webpack@5 cache option Oct 22, 2020
@Timer Timer added this to the 10.x.x milestone Nov 1, 2020
@Timer Timer modified the milestones: 10.x.x, backlog Jan 6, 2021
@matamatanot
Copy link
Contributor Author

Close for next 12

@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants