Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for Image Optimization #18107

Merged
merged 9 commits into from Oct 24, 2020
Merged

Add docs for Image Optimization #18107

merged 9 commits into from Oct 24, 2020

Conversation

styfle
Copy link
Member

@styfle styfle commented Oct 21, 2020 •
edited

  • Add documentation for <Image>
  • Add example to show real image optimization with <Image>

leerob
leerob reviewed Oct 22, 2020
View reviewed changes
docs/api-reference/next/image.md Outdated Show resolved Hide resolved
docs/api-reference/next/image.md Outdated Show resolved Hide resolved
docs/api-reference/next/image.md Outdated Show resolved Hide resolved
docs/api-reference/next/image.md Outdated Show resolved Hide resolved
docs/api-reference/next/image.md Outdated Show resolved Hide resolved
docs/basic-features/image-optimization.md Outdated Show resolved Hide resolved
docs/basic-features/image-optimization.md Outdated Show resolved Hide resolved
docs/basic-features/image-optimization.md Outdated Show resolved Hide resolved
docs/basic-features/image-optimization.md Outdated Show resolved Hide resolved
docs/basic-features/image-optimization.md Show resolved Hide resolved
@styfle @leerob
Apply suggestions from leerob
a7335ea 
Co-authored-by: Lee Robinson <me@leerob.io>
@ijjk

This comment has been minimized.

Sign in to view
@styfle styfle mentioned this pull request Oct 22, 2020
Closed
24 tasks
atcastle
atcastle reviewed Oct 22, 2020
View reviewed changes
docs/api-reference/next/image.md Outdated Show resolved Hide resolved
docs/api-reference/next/image.md Outdated Show resolved Hide resolved
@ijjk

This comment has been minimized.

Sign in to view
@ijjk ijjk added the examples Issue/PR related to examples label Oct 23, 2020
timneutkens and others added 2 commits October 23, 2020 23:16
@timneutkens
Merge branch 'ch13148/image-docs' of github.com:vercel/next.js into v…
e1858bb 
…ercel-ch13148/image-docs

# Conflicts:
#	docs/basic-features/image-optimization.md
@styfle
Update example readme
8bfb723
@styfle styfle marked this pull request as ready for review October 23, 2020 21:23
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Oct 23, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js ch13148/image-docs Change
buildDuration 13.3s 13.2s -148ms
nodeModulesSize 91.3 MB 91.3 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js ch13148/image-docs Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.675 2.768 ⚠️ +0.09
/ avg req/sec 934.56 903.29 ⚠️ -31.27
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.649 1.58 -0.07
/error-in-render avg req/sec 1515.67 1582.44 +66.77
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js ch13148/image-docs Change
677f882d2ed8..574c.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-af76201..828d.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary vercel/next.js ch13148/image-docs Change
677f882d2ed8..dule.js gzip 7.02 kB 7.02 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-3ba933e..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js ch13148/image-docs Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js ch13148/image-docs Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary vercel/next.js ch13148/image-docs Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js ch13148/image-docs Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js ch13148/image-docs Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 995 B 995 B ✓
Overall change 3 kB 3 kB ✓
Serverless Mode
General
vercel/next.js canary vercel/next.js ch13148/image-docs Change
buildDuration 15.4s 15.7s ⚠️ +353ms
nodeModulesSize 91.3 MB 91.3 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js ch13148/image-docs Change
677f882d2ed8..574c.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-af76201..828d.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary vercel/next.js ch13148/image-docs Change
677f882d2ed8..dule.js gzip 7.02 kB 7.02 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-3ba933e..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js ch13148/image-docs Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js ch13148/image-docs Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary vercel/next.js ch13148/image-docs Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js ch13148/image-docs Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary vercel/next.js ch13148/image-docs Change
_error.js 1.06 MB 1.06 MB ✓
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.06 MB 1.06 MB ✓
link.js 1.1 MB 1.1 MB ✓
routerDirect.js 1.1 MB 1.1 MB ✓
withRouter.js 1.1 MB 1.1 MB ✓
Overall change 5.42 MB 5.42 MB ✓
Commit: 06a4656

@styfle styfle mentioned this pull request Oct 23, 2020
Merged
@timneutkens timneutkens merged commit 3c6f421 into canary Oct 24, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juzhiyuan juzhiyuan juzhiyuan left review comments

@atcastle atcastle atcastle left review comments

@leerob leerob leerob left review comments

@timneutkens timneutkens timneutkens approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@styfle @ijjk @juzhiyuan @timneutkens @atcastle @leerob