Add support for notFound in getServerSideProps #18241

ijjk · 2020-10-26T07:24:43Z

This is a follow-up to #17755 which adds support for returning notFound to getServerSideProps also

ijjk · 2020-10-27T00:47:36Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
buildDuration	12.5s	11.8s	-646ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +835 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.232	2.196	-0.04
/ avg req/sec	1120.09	1138.39	+18.3
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.217	1.262	⚠️ +0.04
/error-in-render avg req/sec	2055.07	1980.59	⚠️ -74.48

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
677f882d2ed8..574c.js gzip	11.2 kB	11.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-44c1a22..6e4a.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
677f882d2ed8..dule.js gzip	7.02 kB	7.02 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-e8f31b5..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	995 B	995 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
buildDuration	14.5s	13.7s	-758ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +835 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
677f882d2ed8..574c.js gzip	11.2 kB	11.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-44c1a22..6e4a.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
677f882d2ed8..dule.js gzip	7.02 kB	7.02 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-e8f31b5..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
_error.js	1.06 MB	1.06 MB	⚠️ +233 B
404.html	4.73 kB	4.73 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	⚠️ +233 B
link.js	1.1 MB	1.1 MB	⚠️ +233 B
routerDirect.js	1.1 MB	1.1 MB	⚠️ +233 B
withRouter.js	1.1 MB	1.1 MB	⚠️ +233 B
Overall change	5.42 MB	5.42 MB	⚠️ +1.17 kB

Commit: 42b26ad

ijjk · 2020-10-27T05:08:55Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
buildDuration	10.9s	10.9s	-61ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +973 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.999	2.035	⚠️ +0.04
/ avg req/sec	1250.61	1228.46	⚠️ -22.15
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.117	1.112	0
/error-in-render avg req/sec	2237.47	2248.84	+11.37

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
677f882d2ed8..574c.js gzip	11.2 kB	11.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-2927f4e..281e.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
677f882d2ed8..dule.js gzip	7.02 kB	7.02 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-1382a2d..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	995 B	995 B	✓
Overall change	3 kB	3 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
buildDuration	12.6s	12.3s	-273ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +973 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
677f882d2ed8..574c.js gzip	11.2 kB	11.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-2927f4e..281e.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
677f882d2ed8..dule.js gzip	7.02 kB	7.02 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-1382a2d..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
_error.js	1.06 MB	1.06 MB	⚠️ +242 B
404.html	4.73 kB	4.73 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	⚠️ +242 B
link.js	1.1 MB	1.11 MB	⚠️ +242 B
routerDirect.js	1.1 MB	1.1 MB	⚠️ +242 B
withRouter.js	1.1 MB	1.1 MB	⚠️ +242 B
Overall change	5.43 MB	5.43 MB	⚠️ +1.21 kB

Commit: 9fa2c42

ijjk · 2020-10-27T05:29:04Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
buildDuration	13.1s	13.1s	⚠️ +24ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +973 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.384	2.416	⚠️ +0.03
/ avg req/sec	1048.59	1034.71	⚠️ -13.88
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.29	1.343	⚠️ +0.05
/error-in-render avg req/sec	1937.36	1861.45	⚠️ -75.91

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
677f882d2ed8..d3ae.js gzip	11.2 kB	11.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-2927f4e..281e.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
677f882d2ed8..dule.js gzip	7.01 kB	7.01 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-1382a2d..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	994 B	994 B	✓
Overall change	3 kB	3 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
buildDuration	14.6s	15s	⚠️ +378ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +973 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
677f882d2ed8..d3ae.js gzip	11.2 kB	11.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-2927f4e..281e.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
677f882d2ed8..dule.js gzip	7.01 kB	7.01 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-1382a2d..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js gssp/not-found	Change
_error.js	1.06 MB	1.06 MB	⚠️ +242 B
404.html	4.73 kB	4.73 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	⚠️ +242 B
link.js	1.1 MB	1.11 MB	⚠️ +242 B
routerDirect.js	1.1 MB	1.1 MB	⚠️ +242 B
withRouter.js	1.1 MB	1.1 MB	⚠️ +242 B
Overall change	5.43 MB	5.43 MB	⚠️ +1.21 kB

Commit: abde5c6

PepijnSenders · 2020-11-18T16:07:37Z

packages/next/types/index.d.ts

-  props?: P
-  unstable_redirect?: Redirect
-}
+export type GetServerSidePropsResult<P> =


Hey @ijjk, this change broke typescript for us, can you check this issue? #19271

Add support for notFound in getServerSideProps

a0c7c54

ijjk added the type: next label Oct 26, 2020

This comment has been minimized.

Sign in to view

ijjk added 2 commits October 26, 2020 19:09

Merge remote-tracking branch 'upstream/canary' into gssp/not-found

aa3e0dd

Fix serverless case and add tests for getServerSideProps

42b26ad

ijjk marked this pull request as ready for review October 27, 2020 00:32

ijjk requested review from lfades, Timer and timneutkens as code owners October 27, 2020 00:32

ijjk added 2 commits October 26, 2020 23:28

Merge remote-tracking branch 'upstream/canary' into gssp/not-found

6e49927

Update type

9fa2c42

Timer approved these changes Oct 27, 2020

View reviewed changes

Merge branch 'canary' into gssp/not-found

abde5c6

Timer added the hacktoberfest-accepted label Oct 27, 2020

kodiakhq bot merged commit 4782bda into vercel:canary Oct 27, 2020

ijjk deleted the gssp/not-found branch October 27, 2020 05:42

This was referenced Oct 28, 2020

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 blubfoo/next.js#251

Open

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 blubfoo/next.js#252

Open

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 blubfoo/next.js#253

Open

ijjk mentioned this pull request Nov 2, 2020

Ensure redirect and notFound return values are documented #18691

Closed

PepijnSenders reviewed Nov 18, 2020

View reviewed changes

elad165 mentioned this pull request Feb 9, 2021

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 elad165/next.js#67

Open

This was referenced Mar 7, 2021

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 elad165/next.js#93

Open

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 elad165/next.js#94

Open

This was referenced Mar 7, 2021

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 Jcrowell74/next.js#6

Open

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 Jcrowell74/next.js#7

Open

This was referenced Jan 12, 2022

[Snyk] Security upgrade next from 9.4.1 to 10.0.0 opendoor-labs/next.js#9

Closed

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 opendoor-labs/next.js#15

Closed

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 opendoor-labs/next.js#20

Closed

snyk-bot mentioned this pull request Jan 23, 2022

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 opendoor-labs/next.js#37

Closed

vercel locked as resolved and limited conversation to collaborators Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for notFound in getServerSideProps #18241

Add support for notFound in getServerSideProps #18241

ijjk commented Oct 26, 2020 •

edited

This comment has been minimized.

This comment has been minimized.

ijjk commented Oct 27, 2020

ijjk commented Oct 27, 2020

ijjk commented Oct 27, 2020

PepijnSenders Nov 18, 2020

Add support for notFound in getServerSideProps #18241

Add support for notFound in getServerSideProps #18241

Conversation

ijjk commented Oct 26, 2020 • edited

This comment has been minimized.

This comment has been minimized.

ijjk commented Oct 27, 2020

Stats from current PR

ijjk commented Oct 27, 2020

Stats from current PR

ijjk commented Oct 27, 2020

Stats from current PR

PepijnSenders Nov 18, 2020

Choose a reason for hiding this comment

ijjk commented Oct 26, 2020 •

edited