Re-add domain locale redirect handling #18274

ijjk · 2020-10-26T22:05:59Z

As discussed this re-adds redirecting locale specific domains to the accept-language preferred (unless NEXT_COKIE is used) to help prevent duplicate content on separate domains

x-ref: #17370
continuation of: #18240

ijjk · 2020-10-26T22:15:22Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
buildDuration	12.3s	12.7s	⚠️ +380ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +245 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.157	2.315	⚠️ +0.16
/ avg req/sec	1159.04	1079.94	⚠️ -79.1
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.237	1.319	⚠️ +0.08
/error-in-render avg req/sec	2021.46	1896.09	⚠️ -125.37

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
677f882d2ed8..574c.js gzip	11.2 kB	11.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-44c1a22..6e4a.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
677f882d2ed8..dule.js gzip	7.02 kB	7.02 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-e8f31b5..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	995 B	995 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
buildDuration	13.4s	13.7s	⚠️ +291ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +245 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
677f882d2ed8..574c.js gzip	11.2 kB	11.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-44c1a22..6e4a.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
677f882d2ed8..dule.js gzip	7.02 kB	7.02 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-e8f31b5..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
_error.js	1.06 MB	1.06 MB	✓
404.html	4.73 kB	4.73 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.1 MB	1.1 MB	✓
withRouter.js	1.1 MB	1.1 MB	✓
Overall change	5.42 MB	5.42 MB	✓

Commit: 431ad4b

ijjk · 2020-10-27T00:02:41Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
buildDuration	13.6s	13.3s	-364ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +2.41 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.38	2.477	⚠️ +0.1
/ avg req/sec	1050.52	1009.35	⚠️ -41.17
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.36	1.418	⚠️ +0.06
/error-in-render avg req/sec	1838.63	1762.87	⚠️ -75.76

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
677f882d2ed8..574c.js gzip	11.2 kB	11.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-44c1a22..6e4a.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
677f882d2ed8..dule.js gzip	7.02 kB	7.02 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-e8f31b5..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	995 B	995 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
buildDuration	15.7s	15.3s	-395ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +2.41 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
677f882d2ed8..574c.js gzip	11.2 kB	11.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-44c1a22..6e4a.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
677f882d2ed8..dule.js gzip	7.02 kB	7.02 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-e8f31b5..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	ijjk/next.js i18n/domain-locale-redirecting	Change
_error.js	1.06 MB	1.06 MB	✓
404.html	4.73 kB	4.73 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.1 MB	1.1 MB	✓
withRouter.js	1.1 MB	1.1 MB	✓
Overall change	5.42 MB	5.42 MB	✓

Commit: b6fe1c0

andresgutgon · 2021-01-24T12:30:08Z

packages/next/next-server/server/config.ts

+                  `Both ${item.domain} and ${domainItem.domain} configured the locale (${locale}) but only one can. Remove it from one i18n.domains config to continue`
+                )
+                hasInvalidLocale = true
+                break


@Timer What if we want to have 2 domains translated in the same language?
Exampe:

example.es defaultLocale: 'es' locales: 'en' example.fr defaultLocale: 'fr' locales: 'en'

Is this possible?

Another example more realistic. What if we have two domains for Belgium and Switzerland. In both countries French is a spoken language and we want to offer the content in french in example.ch and example.be.

Hi, if you want the domain to be available for multiple domains you can not configure it for any domains and only in the main locales array and it will fallback to path based locale detection. Note: this can potentially negatively affect SEO since it can register as duplicate content on separate domains

Hi @ijjk I opened an issue as recommended by @Timer :) #21892

Update domain locale handling to re-add restricing locales to domain

431ad4b

ijjk added the type: next label Oct 26, 2020

Make sure to only redirect domain on locale root

b6fe1c0

ijjk mentioned this pull request Oct 26, 2020

[next] Add redirecting domain specific locales vercel/vercel#5333

Merged

ijjk marked this pull request as ready for review October 26, 2020 23:56

ijjk requested review from lfades, Timer and timneutkens as code owners October 26, 2020 23:56

ijjk changed the title ~~Update domain locale handling to re-add restricting locales to domain~~ Update domain locale handling to re-add domain redirect handling Oct 27, 2020

timneutkens approved these changes Oct 27, 2020

View reviewed changes

Merge branch 'canary' into i18n/domain-locale-redirecting

e14ea58

Timer changed the title ~~Update domain locale handling to re-add domain redirect handling~~ Re-add domain locale redirect handling Oct 27, 2020

Timer merged commit 7cb68f7 into vercel:canary Oct 27, 2020

Timer deleted the i18n/domain-locale-redirecting branch October 27, 2020 08:45

This was referenced Oct 28, 2020

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 blubfoo/next.js#251

Open

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 blubfoo/next.js#252

Open

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 blubfoo/next.js#253

Open

timneutkens added the hacktoberfest-accepted label Nov 1, 2020

andresgutgon reviewed Jan 24, 2021

View reviewed changes

andresgutgon mentioned this pull request Feb 5, 2021

Allow same locale under different domains #21892

Closed

elad165 mentioned this pull request Feb 9, 2021

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 elad165/next.js#67

Open

This was referenced Mar 7, 2021

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 elad165/next.js#93

Open

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 elad165/next.js#94

Open

This was referenced Mar 7, 2021

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 Jcrowell74/next.js#6

Open

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 Jcrowell74/next.js#7

Open

This was referenced Mar 7, 2021

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 elad165/next.js#95

Open

[Snyk] Security upgrade next from 9.4.1 to 10.0.0 elad165/next.js#96

Open

Jcrowell74 mentioned this pull request Mar 7, 2021

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 Jcrowell74/next.js#8

Open

This was referenced Jan 12, 2022

[Snyk] Security upgrade next from 9.4.1 to 10.0.0 opendoor-labs/next.js#9

Closed

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 opendoor-labs/next.js#15

Closed

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 opendoor-labs/next.js#20

Closed

snyk-bot mentioned this pull request Jan 23, 2022

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 opendoor-labs/next.js#37

Closed

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Re-add domain locale redirect handling #18274

Re-add domain locale redirect handling #18274

ijjk commented Oct 26, 2020 •

edited

ijjk commented Oct 26, 2020

ijjk commented Oct 27, 2020

andresgutgon Jan 24, 2021 •

edited

andresgutgon Jan 24, 2021 •

edited

ijjk Jan 27, 2021

andresgutgon Feb 5, 2021

Re-add domain locale redirect handling #18274

Re-add domain locale redirect handling #18274

Conversation

ijjk commented Oct 26, 2020 • edited

ijjk commented Oct 26, 2020

Stats from current PR

ijjk commented Oct 27, 2020

Stats from current PR

andresgutgon Jan 24, 2021 • edited

Choose a reason for hiding this comment

andresgutgon Jan 24, 2021 • edited

Choose a reason for hiding this comment

ijjk Jan 27, 2021

Choose a reason for hiding this comment

andresgutgon Feb 5, 2021

Choose a reason for hiding this comment

ijjk commented Oct 26, 2020 •

edited

andresgutgon Jan 24, 2021 •

edited

andresgutgon Jan 24, 2021 •

edited