Ensure getStaticProps is called for SSG 404 in blocking mode #18300

ijjk · 2020-10-27T14:01:10Z

This ensures that when using a pages/404 file with getStaticProps that we call getStaticProps in fallback: 'blocking' mode

Fixes: #18293

…cking-ssg-404

ijjk · 2020-10-27T14:11:29Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
buildDuration	13.5s	13.5s	-69ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +184 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.459	2.612	⚠️ +0.15
/ avg req/sec	1016.57	957.16	⚠️ -59.41
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.405	1.324	-0.08
/error-in-render avg req/sec	1779.26	1888.1	+108.84

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
677f882d2ed8..3aa9.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-b0b4491..c54e.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
677f882d2ed8..dule.js gzip	7.03 kB	7.03 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-6e1c435..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	995 B	995 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
buildDuration	15.7s	15.6s	-39ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +184 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
677f882d2ed8..3aa9.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-b0b4491..c54e.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
677f882d2ed8..dule.js gzip	7.03 kB	7.03 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-6e1c435..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_error.js	1.06 MB	1.06 MB	⚠️ +3 B
404.html	4.73 kB	4.73 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	⚠️ +3 B
link.js	1.11 MB	1.11 MB	⚠️ +3 B
routerDirect.js	1.1 MB	1.1 MB	⚠️ +3 B
withRouter.js	1.1 MB	1.1 MB	⚠️ +3 B
Overall change	5.43 MB	5.43 MB	⚠️ +15 B

Commit: 3c93039

ijjk · 2020-10-27T14:25:52Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
buildDuration	13.1s	13.3s	⚠️ +159ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +184 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.445	2.423	-0.02
/ avg req/sec	1022.68	1031.69	+9.01
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.3	1.36	⚠️ +0.06
/error-in-render avg req/sec	1923.11	1838.74	⚠️ -84.37

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
677f882d2ed8..3aa9.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-b0b4491..c54e.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
677f882d2ed8..dule.js gzip	7.03 kB	7.03 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-6e1c435..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	995 B	995 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
buildDuration	14.8s	15s	⚠️ +257ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +184 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
677f882d2ed8..3aa9.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-b0b4491..c54e.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
677f882d2ed8..dule.js gzip	7.03 kB	7.03 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-6e1c435..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_error.js	1.06 MB	1.06 MB	⚠️ +3 B
404.html	4.73 kB	4.73 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	⚠️ +3 B
link.js	1.11 MB	1.11 MB	⚠️ +3 B
routerDirect.js	1.1 MB	1.1 MB	⚠️ +3 B
withRouter.js	1.1 MB	1.1 MB	⚠️ +3 B
Overall change	5.43 MB	5.43 MB	⚠️ +15 B

Commit: df4de02

ijjk · 2020-10-27T14:40:56Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
buildDuration	13.1s	13.3s	⚠️ +175ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +184 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.507	2.501	-0.01
/ avg req/sec	997.06	999.61	+2.55
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.376	1.33	-0.05
/error-in-render avg req/sec	1816.36	1879.56	+63.2

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
677f882d2ed8..3aa9.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-b0b4491..c54e.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
677f882d2ed8..dule.js gzip	7.03 kB	7.03 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-6e1c435..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	995 B	995 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
buildDuration	15.5s	15.2s	-263ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +184 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
677f882d2ed8..3aa9.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-b0b4491..c54e.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
677f882d2ed8..dule.js gzip	7.03 kB	7.03 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-6e1c435..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_error.js	1.06 MB	1.06 MB	⚠️ +3 B
404.html	4.73 kB	4.73 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	⚠️ +3 B
link.js	1.11 MB	1.11 MB	⚠️ +3 B
routerDirect.js	1.1 MB	1.1 MB	⚠️ +3 B
withRouter.js	1.1 MB	1.1 MB	⚠️ +3 B
Overall change	5.43 MB	5.43 MB	⚠️ +15 B

Commit: f8fd63a

….js into not-found/fix-blocking-ssg-404

ijjk · 2020-10-27T14:58:00Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
buildDuration	12.6s	13.1s	⚠️ +534ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +184 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.443	2.513	⚠️ +0.07
/ avg req/sec	1023.2	994.78	⚠️ -28.42
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.356	1.322	-0.03
/error-in-render avg req/sec	1844.19	1890.92	+46.73

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
677f882d2ed8..3aa9.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-b0b4491..c54e.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
677f882d2ed8..dule.js gzip	7.03 kB	7.03 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-6e1c435..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	995 B	995 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
buildDuration	14.5s	14.2s	-217ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +184 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
677f882d2ed8..3aa9.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-b0b4491..c54e.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
677f882d2ed8..dule.js gzip	7.03 kB	7.03 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-6e1c435..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js not-found/fix-blocking-ssg-404	Change
_error.js	1.06 MB	1.06 MB	⚠️ +3 B
404.html	4.73 kB	4.73 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	⚠️ +3 B
link.js	1.11 MB	1.11 MB	⚠️ +3 B
routerDirect.js	1.1 MB	1.1 MB	⚠️ +3 B
withRouter.js	1.1 MB	1.1 MB	⚠️ +3 B
Overall change	5.43 MB	5.43 MB	⚠️ +15 B

Commit: 345338a

ijjk added 2 commits October 27, 2020 08:59

Ensure getStaticProps is called for SSG 404 in blocking mode

b1ad6e7

Merge remote-tracking branch 'upstream/canary' into not-found/fix-blo…

3c93039

…cking-ssg-404

ijjk requested review from lfades, Timer and timneutkens as code owners October 27, 2020 14:01

ijjk added the type: next label Oct 27, 2020

timneutkens approved these changes Oct 27, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

Merge branch 'canary' into not-found/fix-blocking-ssg-404

df4de02

timneutkens previously approved these changes Oct 27, 2020

View reviewed changes

Merge branch 'canary' into not-found/fix-blocking-ssg-404

f8fd63a

This comment has been minimized.

Sign in to view

ijjk added 2 commits October 27, 2020 09:47

Update manifest test

3b28644

Merge branch 'not-found/fix-blocking-ssg-404' of github.com:ijjk/next…

345338a

….js into not-found/fix-blocking-ssg-404

ijjk dismissed timneutkens’s stale review via 345338a October 27, 2020 14:47

ijjk requested a review from timneutkens October 27, 2020 14:48

timneutkens approved these changes Oct 27, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

kodiakhq bot merged commit 0f25051 into vercel:canary Oct 27, 2020

ijjk deleted the not-found/fix-blocking-ssg-404 branch October 27, 2020 15:12

This was referenced Oct 28, 2020

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 blubfoo/next.js#251

Open

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 blubfoo/next.js#252

Open

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 blubfoo/next.js#253

Open

timneutkens added the hacktoberfest-accepted label Nov 1, 2020

elad165 mentioned this pull request Feb 9, 2021

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 elad165/next.js#67

Open

elad165 mentioned this pull request Mar 7, 2021

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 elad165/next.js#93

Open

This was referenced Jan 12, 2022

[Snyk] Security upgrade next from 9.4.1 to 10.0.0 opendoor-labs/next.js#9

Closed

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 opendoor-labs/next.js#15

Closed

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 opendoor-labs/next.js#20

Closed

snyk-bot mentioned this pull request Jan 23, 2022

[Snyk] Security upgrade next from 9.5.5 to 10.0.0 opendoor-labs/next.js#37

Closed

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure getStaticProps is called for SSG 404 in blocking mode #18300

Ensure getStaticProps is called for SSG 404 in blocking mode #18300

ijjk commented Oct 27, 2020

ijjk commented Oct 27, 2020

This comment has been minimized.

ijjk commented Oct 27, 2020

This comment has been minimized.

ijjk commented Oct 27, 2020

This comment has been minimized.

ijjk commented Oct 27, 2020

Ensure getStaticProps is called for SSG 404 in blocking mode #18300

Ensure getStaticProps is called for SSG 404 in blocking mode #18300

Conversation

ijjk commented Oct 27, 2020

ijjk commented Oct 27, 2020

Stats from current PR

This comment has been minimized.

ijjk commented Oct 27, 2020

Stats from current PR

This comment has been minimized.

ijjk commented Oct 27, 2020

Stats from current PR

This comment has been minimized.

ijjk commented Oct 27, 2020

Stats from current PR