Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(contributing): Search GitHub for an open or closed PR that relates to your submission #22533

Merged
merged 4 commits into from Feb 6, 2022
Merged

docs(contributing): Search GitHub for an open or closed PR that relates to your submission #22533

merged 4 commits into from Feb 6, 2022

Conversation

getspooky
Copy link
Contributor

In Order to avoid duplicate effort contributor should search GitHub for an open or closed PR that relates to submission

@ijjk
Copy link
Member

ijjk commented Feb 25, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary getspooky/next.js my-docs-branch Change
buildDuration 10.9s 11.4s ⚠️ +487ms
nodeModulesSize 42.7 MB 42.7 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary getspooky/next.js my-docs-branch Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.025 2.186 ⚠️ +0.16
/ avg req/sec 1234.56 1143.6 ⚠️ -90.96
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.563 1.561 0
/error-in-render avg req/sec 1599.42 1601.89 +2.47
Client Bundles (main, webpack, commons)
vercel/next.js canary getspooky/next.js my-docs-branch Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary getspooky/next.js my-docs-branch Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary getspooky/next.js my-docs-branch Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary getspooky/next.js my-docs-branch Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary getspooky/next.js my-docs-branch Change
index.html gzip 613 B 613 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary getspooky/next.js my-docs-branch Change
buildDuration 12.8s 13s ⚠️ +206ms
nodeModulesSize 42.7 MB 42.7 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary getspooky/next.js my-docs-branch Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary getspooky/next.js my-docs-branch Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary getspooky/next.js my-docs-branch Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary getspooky/next.js my-docs-branch Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles
vercel/next.js canary getspooky/next.js my-docs-branch Change
_error.js 1.01 MB 1.01 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.4 kB 10.4 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.01 MB 1.01 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.21 MB 5.21 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General
vercel/next.js canary getspooky/next.js my-docs-branch Change
buildDuration 13s 12.8s -240ms
nodeModulesSize 42.7 MB 42.7 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary getspooky/next.js my-docs-branch Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.033 2.072 ⚠️ +0.04
/ avg req/sec 1229.83 1206.56 ⚠️ -23.27
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.424 1.457 ⚠️ +0.03
/error-in-render avg req/sec 1755.29 1716.42 ⚠️ -38.87
Client Bundles (main, webpack, commons)
vercel/next.js canary getspooky/next.js my-docs-branch Change
597-74632e79..1d47.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60.1 kB 60.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary getspooky/next.js my-docs-branch Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary getspooky/next.js my-docs-branch Change
_app-aedc815..1421.js gzip 1.26 kB 1.26 kB ✓
_error-71ec2..1a96.js gzip 3.38 kB 3.38 kB ✓
amp-33a09cb0..6745.js gzip 536 B 536 B ✓
hooks-4e968a..f870.js gzip 902 B 902 B ✓
index-5c6845..f75c.js gzip 230 B 230 B ✓
link-99f0c6c..b84a.js gzip 1.65 kB 1.65 kB ✓
routerDirect..bb56.js gzip 306 B 306 B ✓
withRouter-7..2133.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary getspooky/next.js my-docs-branch Change
_buildManifest.js gzip 326 B 326 B ✓
Overall change 326 B 326 B ✓
Rendered Page Sizes
vercel/next.js canary getspooky/next.js my-docs-branch Change
index.html gzip 587 B 587 B ✓
link.html gzip 594 B 594 B ✓
withRouter.html gzip 582 B 582 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "5jq-1Y6EBOvfM2dnHRTe3",
+        "buildId": "c4xfhfaH1SoZA4AnlY7Lx",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/5jq-1Y6EBOvfM2dnHRTe3/_buildManifest.js"
+      src="/_next/static/c4xfhfaH1SoZA4AnlY7Lx/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/5jq-1Y6EBOvfM2dnHRTe3/_ssgManifest.js"
+      src="/_next/static/c4xfhfaH1SoZA4AnlY7Lx/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "5jq-1Y6EBOvfM2dnHRTe3",
+        "buildId": "c4xfhfaH1SoZA4AnlY7Lx",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/5jq-1Y6EBOvfM2dnHRTe3/_buildManifest.js"
+      src="/_next/static/c4xfhfaH1SoZA4AnlY7Lx/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/5jq-1Y6EBOvfM2dnHRTe3/_ssgManifest.js"
+      src="/_next/static/c4xfhfaH1SoZA4AnlY7Lx/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "5jq-1Y6EBOvfM2dnHRTe3",
+        "buildId": "c4xfhfaH1SoZA4AnlY7Lx",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/5jq-1Y6EBOvfM2dnHRTe3/_buildManifest.js"
+      src="/_next/static/c4xfhfaH1SoZA4AnlY7Lx/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/5jq-1Y6EBOvfM2dnHRTe3/_ssgManifest.js"
+      src="/_next/static/c4xfhfaH1SoZA4AnlY7Lx/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 593aa49

@ijjk
Copy link
Member

ijjk commented Feb 25, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary getspooky/next.js my-docs-branch Change
buildDuration 10.4s 11s ⚠️ +611ms
nodeModulesSize 42.7 MB 42.7 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary getspooky/next.js my-docs-branch Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.959 2.043 ⚠️ +0.08
/ avg req/sec 1276.1 1223.74 ⚠️ -52.36
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.164 1.229 ⚠️ +0.07
/error-in-render avg req/sec 2147.99 2033.46 ⚠️ -114.53
Client Bundles (main, webpack, commons)
vercel/next.js canary getspooky/next.js my-docs-branch Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary getspooky/next.js my-docs-branch Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary getspooky/next.js my-docs-branch Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary getspooky/next.js my-docs-branch Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary getspooky/next.js my-docs-branch Change
index.html gzip 613 B 613 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary getspooky/next.js my-docs-branch Change
buildDuration 12.8s 12.8s ⚠️ +23ms
nodeModulesSize 42.7 MB 42.7 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary getspooky/next.js my-docs-branch Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary getspooky/next.js my-docs-branch Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary getspooky/next.js my-docs-branch Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary getspooky/next.js my-docs-branch Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles
vercel/next.js canary getspooky/next.js my-docs-branch Change
_error.js 1.01 MB 1.01 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.4 kB 10.4 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.01 MB 1.01 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.21 MB 5.21 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General
vercel/next.js canary getspooky/next.js my-docs-branch Change
buildDuration 12.9s 12.5s -334ms
nodeModulesSize 42.7 MB 42.7 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary getspooky/next.js my-docs-branch Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.997 1.938 -0.06
/ avg req/sec 1251.94 1289.72 +37.78
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.264 1.247 -0.02
/error-in-render avg req/sec 1978.3 2004.79 +26.49
Client Bundles (main, webpack, commons)
vercel/next.js canary getspooky/next.js my-docs-branch Change
597-74632e79..1d47.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60.1 kB 60.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary getspooky/next.js my-docs-branch Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary getspooky/next.js my-docs-branch Change
_app-aedc815..1421.js gzip 1.26 kB 1.26 kB ✓
_error-71ec2..1a96.js gzip 3.38 kB 3.38 kB ✓
amp-33a09cb0..6745.js gzip 536 B 536 B ✓
hooks-4e968a..f870.js gzip 902 B 902 B ✓
index-5c6845..f75c.js gzip 230 B 230 B ✓
link-99f0c6c..b84a.js gzip 1.65 kB 1.65 kB ✓
routerDirect..bb56.js gzip 306 B 306 B ✓
withRouter-7..2133.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary getspooky/next.js my-docs-branch Change
_buildManifest.js gzip 326 B 326 B ✓
Overall change 326 B 326 B ✓
Rendered Page Sizes
vercel/next.js canary getspooky/next.js my-docs-branch Change
index.html gzip 587 B 587 B ✓
link.html gzip 594 B 594 B ✓
withRouter.html gzip 582 B 582 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "obwAl3T-uW7c-ICMR9ryi",
+        "buildId": "4HqrfKtyy3LB0dXQRpug4",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/obwAl3T-uW7c-ICMR9ryi/_buildManifest.js"
+      src="/_next/static/4HqrfKtyy3LB0dXQRpug4/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/obwAl3T-uW7c-ICMR9ryi/_ssgManifest.js"
+      src="/_next/static/4HqrfKtyy3LB0dXQRpug4/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "obwAl3T-uW7c-ICMR9ryi",
+        "buildId": "4HqrfKtyy3LB0dXQRpug4",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/obwAl3T-uW7c-ICMR9ryi/_buildManifest.js"
+      src="/_next/static/4HqrfKtyy3LB0dXQRpug4/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/obwAl3T-uW7c-ICMR9ryi/_ssgManifest.js"
+      src="/_next/static/4HqrfKtyy3LB0dXQRpug4/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "obwAl3T-uW7c-ICMR9ryi",
+        "buildId": "4HqrfKtyy3LB0dXQRpug4",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/obwAl3T-uW7c-ICMR9ryi/_buildManifest.js"
+      src="/_next/static/4HqrfKtyy3LB0dXQRpug4/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/obwAl3T-uW7c-ICMR9ryi/_ssgManifest.js"
+      src="/_next/static/4HqrfKtyy3LB0dXQRpug4/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 15cab52

ijjk
ijjk approved these changes Feb 6, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ijjk ijjk merged commit fbb16fb into vercel:canary Feb 6, 2022
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
@getspooky @ijjk @natew
docs(contributing): Search GitHub for an open or closed PR that relat…
bf7459c 
…es to your submission (vercel#22533)

* docs(contributing): Search Github for an open or closed PR that relates to your submission

* move note up

Co-authored-by: JJ Kasper <jj@jjsweb.site>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@getspooky @ijjk