Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra work on cli functions #22855

Merged
merged 4 commits into from Mar 8, 2021
Merged

Remove extra work on cli functions #22855

merged 4 commits into from Mar 8, 2021

Conversation

sromexs
Copy link
Contributor

@sromexs sromexs commented Mar 7, 2021 •
edited

Hi I saw you wrote extra async await code for command line function that doesn't need. I fixed that and code become very smaller and prettier.

@ijjk ijjk added the type: next label Mar 7, 2021
@ijjk
Copy link
Member

ijjk commented Mar 7, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
buildDuration 11.5s 11.8s ⚠️ +238ms
nodeModulesSize 42.8 MB 42.8 MB -205 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.003 2.126 ⚠️ +0.12
/ avg req/sec 1248.14 1176.03 ⚠️ -72.11
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.398 1.418 ⚠️ +0.02
/error-in-render avg req/sec 1788.12 1763.27 ⚠️ -24.85
Client Bundles (main, webpack, commons)
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
index.html gzip 615 B 615 B ✓
link.html gzip 623 B 623 B ✓
withRouter.html gzip 609 B 609 B ✓
Overall change 1.85 kB 1.85 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
buildDuration 14.2s 14.1s -135ms
nodeModulesSize 42.8 MB 42.8 MB -205 B
Client Bundles (main, webpack, commons)
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.5 kB 10.5 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
buildDuration 13.5s 14.4s ⚠️ +885ms
nodeModulesSize 42.8 MB 42.8 MB -205 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.942 2.258 ⚠️ +0.32
/ avg req/sec 1287.34 1107.38 ⚠️ -179.96
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.301 1.474 ⚠️ +0.17
/error-in-render avg req/sec 1922.2 1696.61 ⚠️ -225.59
Client Bundles (main, webpack, commons)
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
597-2bc2376a..203d.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_app-aedc815..1421.js gzip 1.26 kB 1.26 kB ✓
_error-71ec2..1a96.js gzip 3.38 kB 3.38 kB ✓
amp-33a09cb0..6745.js gzip 536 B 536 B ✓
hooks-4e968a..f870.js gzip 902 B 902 B ✓
index-5c6845..f75c.js gzip 230 B 230 B ✓
link-99f0c6c..b84a.js gzip 1.65 kB 1.65 kB ✓
routerDirect..bb56.js gzip 306 B 306 B ✓
withRouter-7..2133.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_buildManifest.js gzip 326 B 326 B ✓
Overall change 326 B 326 B ✓
Rendered Page Sizes
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
index.html gzip 586 B 586 B ✓
link.html gzip 594 B 594 B ✓
withRouter.html gzip 582 B 582 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "yHiygshJWA6HKKh4SuYkB",
+        "buildId": "fuoWhziwi4lxRX6pm6Qi2",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/yHiygshJWA6HKKh4SuYkB/_buildManifest.js"
+      src="/_next/static/fuoWhziwi4lxRX6pm6Qi2/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/yHiygshJWA6HKKh4SuYkB/_ssgManifest.js"
+      src="/_next/static/fuoWhziwi4lxRX6pm6Qi2/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "yHiygshJWA6HKKh4SuYkB",
+        "buildId": "fuoWhziwi4lxRX6pm6Qi2",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/yHiygshJWA6HKKh4SuYkB/_buildManifest.js"
+      src="/_next/static/fuoWhziwi4lxRX6pm6Qi2/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/yHiygshJWA6HKKh4SuYkB/_ssgManifest.js"
+      src="/_next/static/fuoWhziwi4lxRX6pm6Qi2/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "yHiygshJWA6HKKh4SuYkB",
+        "buildId": "fuoWhziwi4lxRX6pm6Qi2",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/yHiygshJWA6HKKh4SuYkB/_buildManifest.js"
+      src="/_next/static/fuoWhziwi4lxRX6pm6Qi2/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/yHiygshJWA6HKKh4SuYkB/_ssgManifest.js"
+      src="/_next/static/fuoWhziwi4lxRX6pm6Qi2/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 3b10cca

@ijjk
Copy link
Member

ijjk commented Mar 8, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
buildDuration 10.2s 10.2s ⚠️ +24ms
nodeModulesSize 42.8 MB 42.8 MB -205 B
Page Load Tests Overall increase ✓
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.794 1.85 ⚠️ +0.06
/ avg req/sec 1393.87 1351.13 ⚠️ -42.74
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.185 1.095 -0.09
/error-in-render avg req/sec 2109.45 2283.42 +173.97
Client Bundles (main, webpack, commons)
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
index.html gzip 615 B 615 B ✓
link.html gzip 623 B 623 B ✓
withRouter.html gzip 609 B 609 B ✓
Overall change 1.85 kB 1.85 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
buildDuration 12.1s 12.1s -59ms
nodeModulesSize 42.8 MB 42.8 MB -205 B
Client Bundles (main, webpack, commons)
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.5 kB 10.5 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
buildDuration 12s 12.1s ⚠️ +48ms
nodeModulesSize 42.8 MB 42.8 MB -205 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.75 1.913 ⚠️ +0.16
/ avg req/sec 1428.41 1307.14 ⚠️ -121.27
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.115 1.145 ⚠️ +0.03
/error-in-render avg req/sec 2241.61 2183.32 ⚠️ -58.29
Client Bundles (main, webpack, commons)
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
597-2bc2376a..203d.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_app-aedc815..1421.js gzip 1.26 kB 1.26 kB ✓
_error-71ec2..1a96.js gzip 3.38 kB 3.38 kB ✓
amp-33a09cb0..6745.js gzip 536 B 536 B ✓
hooks-4e968a..f870.js gzip 902 B 902 B ✓
index-5c6845..f75c.js gzip 230 B 230 B ✓
link-99f0c6c..b84a.js gzip 1.65 kB 1.65 kB ✓
routerDirect..bb56.js gzip 306 B 306 B ✓
withRouter-7..2133.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_buildManifest.js gzip 326 B 326 B ✓
Overall change 326 B 326 B ✓
Rendered Page Sizes
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
index.html gzip 586 B 586 B ✓
link.html gzip 594 B 594 B ✓
withRouter.html gzip 582 B 582 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "9bVzRrLWP_zfR23cx59PR",
+        "buildId": "e0ijvaEBmnsc_YZaydVdo",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/9bVzRrLWP_zfR23cx59PR/_buildManifest.js"
+      src="/_next/static/e0ijvaEBmnsc_YZaydVdo/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/9bVzRrLWP_zfR23cx59PR/_ssgManifest.js"
+      src="/_next/static/e0ijvaEBmnsc_YZaydVdo/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "9bVzRrLWP_zfR23cx59PR",
+        "buildId": "e0ijvaEBmnsc_YZaydVdo",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/9bVzRrLWP_zfR23cx59PR/_buildManifest.js"
+      src="/_next/static/e0ijvaEBmnsc_YZaydVdo/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/9bVzRrLWP_zfR23cx59PR/_ssgManifest.js"
+      src="/_next/static/e0ijvaEBmnsc_YZaydVdo/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "9bVzRrLWP_zfR23cx59PR",
+        "buildId": "e0ijvaEBmnsc_YZaydVdo",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/9bVzRrLWP_zfR23cx59PR/_buildManifest.js"
+      src="/_next/static/e0ijvaEBmnsc_YZaydVdo/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/9bVzRrLWP_zfR23cx59PR/_ssgManifest.js"
+      src="/_next/static/e0ijvaEBmnsc_YZaydVdo/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 8c798cc

timneutkens
timneutkens approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a reason for this but I can't remember what exactly. Given that the tests pass this is fine to land. Thanks!

@ijjk
Copy link
Member

ijjk commented Mar 8, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
buildDuration 12.2s 12.1s -129ms
nodeModulesSize 42.8 MB 42.8 MB -205 B
Page Load Tests Overall increase ✓
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.161 1.988 -0.17
/ avg req/sec 1156.97 1257.83 +100.86
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.359 1.305 -0.05
/error-in-render avg req/sec 1839.43 1915.92 +76.49
Client Bundles (main, webpack, commons)
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 609 B 609 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
buildDuration 13.9s 14.5s ⚠️ +573ms
nodeModulesSize 42.8 MB 42.8 MB -205 B
Client Bundles (main, webpack, commons)
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.5 kB 10.5 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
buildDuration 13.9s 14.1s ⚠️ +109ms
nodeModulesSize 42.8 MB 42.8 MB -205 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.017 2.107 ⚠️ +0.09
/ avg req/sec 1239.48 1186.67 ⚠️ -52.81
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.318 1.307 -0.01
/error-in-render avg req/sec 1897.16 1912.84 +15.68
Client Bundles (main, webpack, commons)
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
597-2bc2376a..203d.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_app-aedc815..1421.js gzip 1.26 kB 1.26 kB ✓
_error-71ec2..1a96.js gzip 3.38 kB 3.38 kB ✓
amp-33a09cb0..6745.js gzip 536 B 536 B ✓
hooks-4e968a..f870.js gzip 902 B 902 B ✓
index-5c6845..f75c.js gzip 230 B 230 B ✓
link-99f0c6c..b84a.js gzip 1.65 kB 1.65 kB ✓
routerDirect..bb56.js gzip 306 B 306 B ✓
withRouter-7..2133.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_buildManifest.js gzip 326 B 326 B ✓
Overall change 326 B 326 B ✓
Rendered Page Sizes
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
index.html gzip 586 B 586 B ✓
link.html gzip 592 B 592 B ✓
withRouter.html gzip 580 B 580 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "KOzDzzRNpgFYb8lyNygFG",
+        "buildId": "YobcBNWupoXezxm9fKitG",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/KOzDzzRNpgFYb8lyNygFG/_buildManifest.js"
+      src="/_next/static/YobcBNWupoXezxm9fKitG/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/KOzDzzRNpgFYb8lyNygFG/_ssgManifest.js"
+      src="/_next/static/YobcBNWupoXezxm9fKitG/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "KOzDzzRNpgFYb8lyNygFG",
+        "buildId": "YobcBNWupoXezxm9fKitG",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/KOzDzzRNpgFYb8lyNygFG/_buildManifest.js"
+      src="/_next/static/YobcBNWupoXezxm9fKitG/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/KOzDzzRNpgFYb8lyNygFG/_ssgManifest.js"
+      src="/_next/static/YobcBNWupoXezxm9fKitG/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "KOzDzzRNpgFYb8lyNygFG",
+        "buildId": "YobcBNWupoXezxm9fKitG",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/KOzDzzRNpgFYb8lyNygFG/_buildManifest.js"
+      src="/_next/static/YobcBNWupoXezxm9fKitG/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/KOzDzzRNpgFYb8lyNygFG/_ssgManifest.js"
+      src="/_next/static/YobcBNWupoXezxm9fKitG/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 026c4c1

@ijjk
Copy link
Member

ijjk commented Mar 8, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
buildDuration 12.1s 12.4s ⚠️ +294ms
nodeModulesSize 42.8 MB 42.8 MB -205 B
Page Load Tests Overall increase ✓
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.3 2.303 0
/ avg req/sec 1087.16 1085.62 ⚠️ -1.54
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.555 1.539 -0.02
/error-in-render avg req/sec 1608.06 1624.81 +16.75
Client Bundles (main, webpack, commons)
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 609 B 609 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
buildDuration 15.3s 14.4s -896ms
nodeModulesSize 42.8 MB 42.8 MB -205 B
Client Bundles (main, webpack, commons)
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.5 kB 10.5 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
buildDuration 14.9s 14.8s -104ms
nodeModulesSize 42.8 MB 42.8 MB -205 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.237 2.385 ⚠️ +0.15
/ avg req/sec 1117.68 1048.03 ⚠️ -69.65
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.569 1.627 ⚠️ +0.06
/error-in-render avg req/sec 1593.84 1536.45 ⚠️ -57.39
Client Bundles (main, webpack, commons)
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
597-2bc2376a..203d.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_app-aedc815..1421.js gzip 1.26 kB 1.26 kB ✓
_error-71ec2..1a96.js gzip 3.38 kB 3.38 kB ✓
amp-33a09cb0..6745.js gzip 536 B 536 B ✓
hooks-4e968a..f870.js gzip 902 B 902 B ✓
index-5c6845..f75c.js gzip 230 B 230 B ✓
link-99f0c6c..b84a.js gzip 1.65 kB 1.65 kB ✓
routerDirect..bb56.js gzip 306 B 306 B ✓
withRouter-7..2133.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
_buildManifest.js gzip 326 B 326 B ✓
Overall change 326 B 326 B ✓
Rendered Page Sizes
vercel/next.js canary sromexs/next.js fix-extra-working-on-fanction Change
index.html gzip 586 B 586 B ✓
link.html gzip 592 B 592 B ✓
withRouter.html gzip 580 B 580 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "mOthClO68VF9YjimLhY0q",
+        "buildId": "0blzikPN8IpxwFKRXuy7A",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/mOthClO68VF9YjimLhY0q/_buildManifest.js"
+      src="/_next/static/0blzikPN8IpxwFKRXuy7A/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/mOthClO68VF9YjimLhY0q/_ssgManifest.js"
+      src="/_next/static/0blzikPN8IpxwFKRXuy7A/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "mOthClO68VF9YjimLhY0q",
+        "buildId": "0blzikPN8IpxwFKRXuy7A",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/mOthClO68VF9YjimLhY0q/_buildManifest.js"
+      src="/_next/static/0blzikPN8IpxwFKRXuy7A/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/mOthClO68VF9YjimLhY0q/_ssgManifest.js"
+      src="/_next/static/0blzikPN8IpxwFKRXuy7A/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "mOthClO68VF9YjimLhY0q",
+        "buildId": "0blzikPN8IpxwFKRXuy7A",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/mOthClO68VF9YjimLhY0q/_buildManifest.js"
+      src="/_next/static/0blzikPN8IpxwFKRXuy7A/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/mOthClO68VF9YjimLhY0q/_ssgManifest.js"
+      src="/_next/static/0blzikPN8IpxwFKRXuy7A/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 52aac80

@kodiakhq kodiakhq bot merged commit 42b3b16 into vercel:canary Mar 8, 2021
@sromexs
Copy link
Contributor Author

sromexs commented Mar 8, 2021

Thanks.

@sromexs sromexs deleted the fix-extra-working-on-fanction branch March 8, 2021 15:24
This was referenced Mar 15, 2021
Merged
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Merged
This was referenced Mar 16, 2021
Merged
Merged
Closed
Closed
Merged
Closed
Closed
Merged
Merged
Closed
Closed
Merged
Closed
Merged
Closed
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Merged
Merged
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sromexs @ijjk @timneutkens