Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure process exits after build completes #23207

Merged
merged 3 commits into from
Mar 19, 2021
Merged

Ensure process exits after build completes #23207

merged 3 commits into from
Mar 19, 2021
+12 −1

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Mar 18, 2021

This ensures we exit the build process after the build completes even if timers/connections are left open since this can cause the process to hang indefinitely. This was the previous behavior although got changed un-intentionally in e27b7e9

This updates our production test with an open timer to ensure it doesn't block the process from completing.

ijjk added 2 commits March 18, 2021 17:12
@ijjk
Ensure process exits after build completes

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 171355C5AEB45F59
Learn about vigilant mode
5315609
@ijjk
Merge remote-tracking branch 'upstream/canary' into add/process-exit

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 171355C5AEB45F59
Learn about vigilant mode
93de595
@ijjk
only exit explicitly for build

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 171355C5AEB45F59
Learn about vigilant mode
08154d7
@ijjk
Copy link
Member Author

ijjk commented Mar 18, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/process-exit Change
buildDuration 10.4s 10.2s -157ms
nodeModulesSize 43.6 MB 43.6 MB ⚠️ +633 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js add/process-exit Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.926 1.892 -0.03
/ avg req/sec 1297.85 1321.4 +23.55
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.312 1.319 ⚠️ +0.01
/error-in-render avg req/sec 1905.89 1895.42 ⚠️ -10.47
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/process-exit Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/process-exit Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js add/process-exit Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js add/process-exit Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/process-exit Change
index.html gzip 612 B 612 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/process-exit Change
buildDuration 11.8s 11.6s -185ms
nodeModulesSize 43.6 MB 43.6 MB ⚠️ +633 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/process-exit Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/process-exit Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js add/process-exit Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js add/process-exit Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js add/process-exit Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.6 kB 10.6 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/process-exit Change
buildDuration 11.9s 12.1s ⚠️ +200ms
nodeModulesSize 43.6 MB 43.6 MB ⚠️ +633 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js add/process-exit Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.959 1.916 -0.04
/ avg req/sec 1276.4 1304.78 +28.38
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.308 1.312 0
/error-in-render avg req/sec 1910.91 1906.2 ⚠️ -4.71
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/process-exit Change
597-12fee761..569d.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 7.1 kB 7.1 kB ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/process-exit Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js add/process-exit Change
_app-d0eb668..79ef.js gzip 1.28 kB 1.28 kB ✓
_error-d12ff..6063.js gzip 3.4 kB 3.4 kB ✓
amp-127483e4..9cd8.js gzip 560 B 560 B ✓
hooks-75994b..62d3.js gzip 924 B 924 B ✓
index-ac1ee6..819e.js gzip 243 B 243 B ✓
link-1cd4709..71e5.js gzip 1.65 kB 1.65 kB ✓
routerDirect..4d90.js gzip 333 B 333 B ✓
withRouter-0..60b0.js gzip 329 B 329 B ✓
Overall change 8.72 kB 8.72 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js add/process-exit Change
_buildManifest.js gzip 324 B 324 B ✓
Overall change 324 B 324 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/process-exit Change
index.html gzip 588 B 588 B ✓
link.html gzip 595 B 595 B ✓
withRouter.html gzip 581 B 581 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "U6XrvCwEReekFg8PONz9a",
+        "buildId": "pp0sS-A_aIRCxbHq1YM9j",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/U6XrvCwEReekFg8PONz9a/_buildManifest.js"
+      src="/_next/static/pp0sS-A_aIRCxbHq1YM9j/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/U6XrvCwEReekFg8PONz9a/_ssgManifest.js"
+      src="/_next/static/pp0sS-A_aIRCxbHq1YM9j/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "U6XrvCwEReekFg8PONz9a",
+        "buildId": "pp0sS-A_aIRCxbHq1YM9j",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/U6XrvCwEReekFg8PONz9a/_buildManifest.js"
+      src="/_next/static/pp0sS-A_aIRCxbHq1YM9j/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/U6XrvCwEReekFg8PONz9a/_ssgManifest.js"
+      src="/_next/static/pp0sS-A_aIRCxbHq1YM9j/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "U6XrvCwEReekFg8PONz9a",
+        "buildId": "pp0sS-A_aIRCxbHq1YM9j",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/U6XrvCwEReekFg8PONz9a/_buildManifest.js"
+      src="/_next/static/pp0sS-A_aIRCxbHq1YM9j/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/U6XrvCwEReekFg8PONz9a/_ssgManifest.js"
+      src="/_next/static/pp0sS-A_aIRCxbHq1YM9j/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 08154d7

@kodiakhq kodiakhq bot merged commit b6bb110 into vercel:canary Mar 19, 2021
@ijjk ijjk deleted the add/process-exit branch March 19, 2021 13:41
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Apr 29, 2021
@ijjk
Ensure process exits after build completes (vercel#23207)
4b720cc 
This ensures we exit the build process after the build completes even if timers/connections are left open since this can cause the process to hang indefinitely. This was the previous behavior although got changed un-intentionally in vercel@e27b7e9

This updates our production test with an open timer to ensure it doesn't block the process from completing.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens

@divmain divmain

@lfades lfades

@Timer Timer

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @timneutkens