Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add polyfills for node_modules that are covered in webpack 4 to webpack 5 #23316

Merged
merged 4 commits into from
Mar 23, 2021
Merged

Add polyfills for node_modules that are covered in webpack 4 to webpack 5 #23316

merged 4 commits into from
Mar 23, 2021
+311 −17

Conversation

timneutkens
Copy link
Member

Brings back the remaining Node.js module polyfills to not break existing apps upgrading from webpack 4 to webpack 5.

Fixes #23169

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

Sorry, something went wrong.

@timneutkens
Add polyfills for node_modules that are covered in webpack 4 to webpa…
ae688d4 
…ck 5

Brings back the remaining Node.js module polyfills to not break existing apps upgrading from webpack 4 to webpack 5.

Fixes vercel#23169
@ijjk
Copy link
Member

ijjk commented Mar 23, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
buildDuration 12.9s 12.4s -578ms
nodeModulesSize 43.6 MB 45.5 MB ⚠️ +1.88 MB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.312 2.31 0
/ avg req/sec 1081.35 1082.07 +0.72
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.611 1.577 -0.03
/error-in-render avg req/sec 1552.25 1584.84 +32.59
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
index.html gzip 612 B 612 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
buildDuration 14.9s 14.8s -73ms
nodeModulesSize 43.6 MB 45.5 MB ⚠️ +1.88 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.6 kB 10.6 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
buildDuration 15.2s 15.8s ⚠️ +566ms
nodeModulesSize 43.6 MB 45.5 MB ⚠️ +1.88 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.224 2.323 ⚠️ +0.1
/ avg req/sec 1124.17 1076.34 ⚠️ -47.83
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.571 1.597 ⚠️ +0.03
/error-in-render avg req/sec 1591 1565.23 ⚠️ -25.77
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
597-12fee761..569d.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 7.11 kB 7.11 kB ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
_app-b5edc60..e5c2.js gzip 1.29 kB 1.29 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-3631090..4cab.js gzip 1.65 kB 1.65 kB ✓
routerDirect..20d7.js gzip 328 B 328 B ✓
withRouter-b..a4b9.js gzip 326 B 326 B ✓
Overall change 8.72 kB 8.72 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
_buildManifest.js gzip 325 B 325 B ✓
Overall change 325 B 325 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
index.html gzip 585 B 585 B ✓
link.html gzip 594 B 594 B ✓
withRouter.html gzip 582 B 582 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "0BObafnQz4bf332enuF_9",
+        "buildId": "wMLH56t4cyseZDjX1BsJI",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/0BObafnQz4bf332enuF_9/_buildManifest.js"
+      src="/_next/static/wMLH56t4cyseZDjX1BsJI/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/0BObafnQz4bf332enuF_9/_ssgManifest.js"
+      src="/_next/static/wMLH56t4cyseZDjX1BsJI/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "0BObafnQz4bf332enuF_9",
+        "buildId": "wMLH56t4cyseZDjX1BsJI",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/0BObafnQz4bf332enuF_9/_buildManifest.js"
+      src="/_next/static/wMLH56t4cyseZDjX1BsJI/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/0BObafnQz4bf332enuF_9/_ssgManifest.js"
+      src="/_next/static/wMLH56t4cyseZDjX1BsJI/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "0BObafnQz4bf332enuF_9",
+        "buildId": "wMLH56t4cyseZDjX1BsJI",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/0BObafnQz4bf332enuF_9/_buildManifest.js"
+      src="/_next/static/wMLH56t4cyseZDjX1BsJI/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/0BObafnQz4bf332enuF_9/_ssgManifest.js"
+      src="/_next/static/wMLH56t4cyseZDjX1BsJI/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: b3b8742

sokra
sokra previously approved these changes Mar 23, 2021
View reviewed changes
@timneutkens timneutkens mentioned this pull request Mar 23, 2021
Merged
@ijjk
Copy link
Member

ijjk commented Mar 23, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
buildDuration 10.3s 10.3s -65ms
nodeModulesSize 43.6 MB 45.5 MB ⚠️ +1.88 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.833 1.856 ⚠️ +0.02
/ avg req/sec 1364.19 1347.01 ⚠️ -17.18
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.148 1.201 ⚠️ +0.05
/error-in-render avg req/sec 2178.58 2081 ⚠️ -97.58
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
index.html gzip 612 B 612 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
buildDuration 12.3s 12.1s -158ms
nodeModulesSize 43.6 MB 45.5 MB ⚠️ +1.88 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.6 kB 10.6 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
buildDuration 12.3s 12.5s ⚠️ +231ms
nodeModulesSize 43.6 MB 45.5 MB ⚠️ +1.88 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.861 1.944 ⚠️ +0.08
/ avg req/sec 1343.58 1286.29 ⚠️ -57.29
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.162 1.148 -0.01
/error-in-render avg req/sec 2151.5 2177.21 +25.71
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
597-12fee761..569d.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 7.11 kB 7.11 kB ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
_app-b5edc60..e5c2.js gzip 1.29 kB 1.29 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-3631090..4cab.js gzip 1.65 kB 1.65 kB ✓
routerDirect..20d7.js gzip 328 B 328 B ✓
withRouter-b..a4b9.js gzip 326 B 326 B ✓
Overall change 8.72 kB 8.72 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
_buildManifest.js gzip 325 B 325 B ✓
Overall change 325 B 325 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
index.html gzip 585 B 585 B ✓
link.html gzip 594 B 594 B ✓
withRouter.html gzip 582 B 582 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "yaGHLkoCTXF8EjDH3fmXk",
+        "buildId": "Lk1Bmc-iDwxTxFY_1Ss53",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/yaGHLkoCTXF8EjDH3fmXk/_buildManifest.js"
+      src="/_next/static/Lk1Bmc-iDwxTxFY_1Ss53/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/yaGHLkoCTXF8EjDH3fmXk/_ssgManifest.js"
+      src="/_next/static/Lk1Bmc-iDwxTxFY_1Ss53/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "yaGHLkoCTXF8EjDH3fmXk",
+        "buildId": "Lk1Bmc-iDwxTxFY_1Ss53",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/yaGHLkoCTXF8EjDH3fmXk/_buildManifest.js"
+      src="/_next/static/Lk1Bmc-iDwxTxFY_1Ss53/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/yaGHLkoCTXF8EjDH3fmXk/_ssgManifest.js"
+      src="/_next/static/Lk1Bmc-iDwxTxFY_1Ss53/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "yaGHLkoCTXF8EjDH3fmXk",
+        "buildId": "Lk1Bmc-iDwxTxFY_1Ss53",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/yaGHLkoCTXF8EjDH3fmXk/_buildManifest.js"
+      src="/_next/static/Lk1Bmc-iDwxTxFY_1Ss53/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/yaGHLkoCTXF8EjDH3fmXk/_ssgManifest.js"
+      src="/_next/static/Lk1Bmc-iDwxTxFY_1Ss53/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 60426f3

@ijjk
Merge branch 'canary' into fix/add-node-modules-polyfills

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
cdee5cc
@ijjk
Copy link
Member

ijjk commented Mar 23, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
buildDuration 12.8s 12.8s -53ms
nodeModulesSize 43.6 MB 45.5 MB ⚠️ +1.88 MB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.323 2.258 -0.06
/ avg req/sec 1076.03 1107.25 +31.22
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.642 1.557 -0.08
/error-in-render avg req/sec 1522.97 1606.07 +83.1
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
index.html gzip 612 B 612 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
buildDuration 15s 14.9s -85ms
nodeModulesSize 43.6 MB 45.5 MB ⚠️ +1.88 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.6 kB 10.6 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
buildDuration 15.2s 15.4s ⚠️ +242ms
nodeModulesSize 43.6 MB 45.5 MB ⚠️ +1.88 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.278 2.284 ⚠️ +0.01
/ avg req/sec 1097.39 1094.81 ⚠️ -2.58
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.565 1.589 ⚠️ +0.02
/error-in-render avg req/sec 1597.11 1572.95 ⚠️ -24.16
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
597-12fee761..569d.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 7.11 kB 7.11 kB ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
_app-b5edc60..e5c2.js gzip 1.29 kB 1.29 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-3631090..4cab.js gzip 1.65 kB 1.65 kB ✓
routerDirect..20d7.js gzip 328 B 328 B ✓
withRouter-b..a4b9.js gzip 326 B 326 B ✓
Overall change 8.72 kB 8.72 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
_buildManifest.js gzip 325 B 325 B ✓
Overall change 325 B 325 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/add-node-modules-polyfills Change
index.html gzip 585 B 585 B ✓
link.html gzip 594 B 594 B ✓
withRouter.html gzip 582 B 582 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "IsaF5DOWmanq-nKJ2evYa",
+        "buildId": "iVwPRcXW4HgOl5b_N5C2C",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/IsaF5DOWmanq-nKJ2evYa/_buildManifest.js"
+      src="/_next/static/iVwPRcXW4HgOl5b_N5C2C/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/IsaF5DOWmanq-nKJ2evYa/_ssgManifest.js"
+      src="/_next/static/iVwPRcXW4HgOl5b_N5C2C/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "IsaF5DOWmanq-nKJ2evYa",
+        "buildId": "iVwPRcXW4HgOl5b_N5C2C",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/IsaF5DOWmanq-nKJ2evYa/_buildManifest.js"
+      src="/_next/static/iVwPRcXW4HgOl5b_N5C2C/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/IsaF5DOWmanq-nKJ2evYa/_ssgManifest.js"
+      src="/_next/static/iVwPRcXW4HgOl5b_N5C2C/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "IsaF5DOWmanq-nKJ2evYa",
+        "buildId": "iVwPRcXW4HgOl5b_N5C2C",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/IsaF5DOWmanq-nKJ2evYa/_buildManifest.js"
+      src="/_next/static/iVwPRcXW4HgOl5b_N5C2C/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/IsaF5DOWmanq-nKJ2evYa/_ssgManifest.js"
+      src="/_next/static/iVwPRcXW4HgOl5b_N5C2C/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: cdee5cc

@kodiakhq kodiakhq bot merged commit c219c1d into vercel:canary Mar 23, 2021
@timneutkens timneutkens deleted the fix/add-node-modules-polyfills branch March 24, 2021 08:53
merceyz
merceyz reviewed Mar 24, 2021
View reviewed changes
packages/next/build/webpack-config.ts
domain: require.resolve('domain-browser'),
http: require.resolve('stream-http'),
https: require.resolve('https-browserify'),
os: require.resolve('os-browserify/browser'),
Copy link
Contributor

@merceyz merceyz Mar 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undeclared dependency alert - Tests didn't catch it until #22323

Edit: Fixed in #23354

SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 20, 2021
@timneutkens @SokratisVidros
Add polyfills for node_modules that are covered in webpack 4 to webpa…
479d26e 
…ck 5 (vercel#23316)

Brings back the remaining Node.js module polyfills to not break existing apps upgrading from webpack 4 to webpack 5.

Fixes vercel#23169



## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.

## Documentation / Examples

- [ ] Make sure the linting passes
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Apr 29, 2021
@timneutkens
Add polyfills for node_modules that are covered in webpack 4 to webpa…
995cd4e 
…ck 5 (vercel#23316)

Brings back the remaining Node.js module polyfills to not break existing apps upgrading from webpack 4 to webpack 5.

Fixes vercel#23169



## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.

## Documentation / Examples

- [ ] Make sure the linting passes
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@merceyz merceyz

@ijjk ijjk

@sokra sokra

@divmain divmain

@lfades lfades

@shuding shuding

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing webpack fallbacks for http and https
4 participants
@timneutkens @ijjk @sokra @merceyz