Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not remove placeholder for data URL #24704

Merged
merged 1 commit into from Jun 8, 2021
Merged

Do not remove placeholder for data URL #24704

merged 1 commit into from Jun 8, 2021

Conversation

ykzts
Copy link
Contributor

@ykzts ykzts commented May 2, 2021 •
edited

Follow-up #24153
Fixes #24703

Bug

  • Related issues linked using fixes #24703
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk added the type: next label May 2, 2021
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
Joonpark13
Joonpark13 reviewed May 7, 2021
View reviewed changes
Copy link
Contributor

@Joonpark13 Joonpark13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently looking into #24703 but I also wanted to clarify that the priority attribute in the existing integration test case shouldn't make a difference since that callout was left in there by mistake.

packages/next/client/image.tsx
@@ -228,14 +228,16 @@ function removePlaceholder(
placeholder: PlaceholderValue
) {
if (placeholder === 'blur' && element) {
if (element.complete) {
if (element.complete && !element.src.startsWith('data:')) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain a bit more about your reasoning behind checking the src?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When isVisible === false, the value of src always starts with data:.

@ijjk
Copy link
Member

ijjk commented Jun 3, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ykzts/next.js data-url Change
buildDuration 13.7s 14.5s ⚠️ +835ms
buildDurationCached 4.1s 3.8s -371ms
nodeModulesSize 46.7 MB 46.8 MB ⚠️ +302 B
Page Load Tests Overall increase ✓
vercel/next.js canary ykzts/next.js data-url Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.407 2.238 -0.17
/ avg req/sec 1038.73 1117.1 +78.37
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.415 1.217 -0.2
/error-in-render avg req/sec 1766.6 2053.63 +287.03
Client Bundles (main, webpack, commons)
vercel/next.js canary ykzts/next.js data-url Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ykzts/next.js data-url Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ykzts/next.js data-url Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.07 kB 3.07 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary ykzts/next.js data-url Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Rendered Page Sizes
vercel/next.js canary ykzts/next.js data-url Change
index.html gzip 573 B 573 B ✓
link.html gzip 580 B 580 B ✓
withRouter.html gzip 568 B 568 B ✓
Overall change 1.72 kB 1.72 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ykzts/next.js data-url Change
buildDuration 15.5s 15.9s ⚠️ +467ms
buildDurationCached 4.9s 4.9s ⚠️ +11ms
nodeModulesSize 46.7 MB 46.8 MB ⚠️ +302 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ykzts/next.js data-url Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ykzts/next.js data-url Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ykzts/next.js data-url Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.07 kB 3.07 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary ykzts/next.js data-url Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary ykzts/next.js data-url Change
_error.js 16.9 kB 16.9 kB ✓
404.html 2.44 kB 2.44 kB ✓
500.html 2.43 kB 2.43 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.63 kB 1.63 kB ✓
css.html 1.81 kB 1.81 kB ✓
hooks.html 1.69 kB 1.69 kB ✓
index.js 17.2 kB 17.2 kB -2 B
link.js 17.4 kB 17.4 kB ✓
routerDirect.js 17.4 kB 17.4 kB ⚠️ +2 B
withRouter.js 17.4 kB 17.4 kB -2 B
Overall change 107 kB 107 kB -2 B
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ykzts/next.js data-url Change
buildDuration 12.5s 12.9s ⚠️ +346ms
buildDurationCached 5.6s 5.6s -27ms
nodeModulesSize 46.7 MB 46.8 MB ⚠️ +302 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ykzts/next.js data-url Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.359 2.574 ⚠️ +0.21
/ avg req/sec 1059.67 971.12 ⚠️ -88.55
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.139 1.403 ⚠️ +0.26
/error-in-render avg req/sec 2195.78 1781.93 ⚠️ -413.85
Client Bundles (main, webpack, commons)
vercel/next.js canary ykzts/next.js data-url Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.99 kB 7.99 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 61.1 kB 61.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ykzts/next.js data-url Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ykzts/next.js data-url Change
_app-HASH.js gzip 1.07 kB 1.07 kB ✓
_error-HASH.js gzip 3.74 kB 3.74 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.63 kB 1.63 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.16 kB 9.16 kB ✓
Client Build Manifests
vercel/next.js canary ykzts/next.js data-url Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary ykzts/next.js data-url Change
index.html gzip 626 B 626 B ✓
link.html gzip 632 B 632 B ✓
withRouter.html gzip 620 B 620 B ✓
Overall change 1.88 kB 1.88 kB ✓
Commit: 767a66d

atcastle
atcastle approved these changes Jun 7, 2021
View reviewed changes
Copy link
Collaborator

@atcastle atcastle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense to me. Thanks @ykzts

@timneutkens timneutkens merged commit 0a1d418 into vercel:canary Jun 8, 2021
@ykzts ykzts deleted the data-url branch June 8, 2021 07:06
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 16, 2021
Closed
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
@ykzts
Do not remove placeholder for data URL (vercel#24704)
748c0d8
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Joonpark13 Joonpark13 Joonpark13 left review comments

@atcastle atcastle atcastle approved these changes

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Placeholder are always blank during lazy loading.
5 participants
@ykzts @ijjk @Joonpark13 @atcastle @timneutkens